subject:"\[Dev\] \[DEV\]\[Puppet Modules\] Unnecessary lookup for wso2\:\:secure_vault_configs"

Re: [Dev] [DEV][Puppet Modules] Unnecessary lookup for wso2::secure_vault_configs

2016-05-09 Thread Thanuja Uruththirakodeeswaran

Hi Chamila, On Mon, May 9, 2016 at 1:50 PM, Chamila De Alwis wrote: > Hi, > > In wso2base/manifests/init.pp [1], we do a Hiera lookup > for wso2::secure_vault_configs, without checking if SecureVault > configurations are needed. IMO we should only do this lookup if the >

[Dev] [DEV][Puppet Modules] Unnecessary lookup for wso2::secure_vault_configs

2016-05-09 Thread Chamila De Alwis

Hi, In wso2base/manifests/init.pp [1], we do a Hiera lookup for wso2::secure_vault_configs, without checking if SecureVault configurations are needed. IMO we should only do this lookup if the previous lookup for wso2::enable_secure_vault is true. Otherwise