Re: [Dev] Please review and commit

Thanks. On Thu, Jan 19, 2017 at 12:22 PM, Chamila De Alwis wrote: > Hi Thanuja, > > The above are now committed. > > > Regards, > Chamila de Alwis > Committer and PMC Member - Apache Stratos > Senior Software Engineer | WSO2 > Blog: https://medium.com/@chamilad > > > > On Wed, Jan 18, 2017 at 10

Re: [Dev] Please review and commit

Hi Thanuja, The above are now committed. Regards, Chamila de Alwis Committer and PMC Member - Apache Stratos Senior Software Engineer | WSO2 Blog: https://medium.com/@chamilad On Wed, Jan 18, 2017 at 10:34 PM, Thanuja Jayasinghe wrote: > Hi Chamila, > > Please use following diffs for the 4.

Re: [Dev] Please review and commit

Hi Chamila, Please use following diffs for the 4.2.0 branch. Thanks, On Wed, Jan 18, 2017 at 12:52 PM, Chamila De Alwis wrote: > Will do. > > > Regards, > Chamila de Alwis > Committer and PMC Member - Apache Stratos > Senior Software Engineer | WSO2 > Blog: https://medium.com/@chamilad > > > >

Re: [Dev] Please review and commit

Will do. Regards, Chamila de Alwis Committer and PMC Member - Apache Stratos Senior Software Engineer | WSO2 Blog: https://medium.com/@chamilad On Wed, Jan 18, 2017 at 12:45 PM, Niranjan Karunanandham wrote: > Hi ChamilaD, > > Can you look into this? > > Regards, > Nira > > On Wed, Jan 18, 2

Re: [Dev] Please review and commit

Hi ChamilaD, Can you look into this? Regards, Nira On Wed, Jan 18, 2017 at 11:47 AM, Thanuja Jayasinghe wrote: > Hi Team, > > The same fix [1] added for carbon-kernel 4.4.x branch and created the > issue [2] also. > > [1] - https://github.com/wso2/carbon-kernel/pull/1273 > [2] - https://github

Re: [Dev] Please review and commit

Hi Team, The same fix [1] added for carbon-kernel 4.4.x branch and created the issue [2] also. [1] - https://github.com/wso2/carbon-kernel/pull/1273 [2] - https://github.com/wso2/carbon-kernel/issues/1272 Thanks, Thanuja On Wed, Jan 18, 2017 at 9:54 AM, Thanuja Jayasinghe wrote: > Hi Team, >

[Dev] Please review and commit

Hi Team, Please find the attached svn diffs created to resolve issue [1] and [2]. Please review and commit them. [1] - https://wso2.org/jira/browse/IDENTITY-5551 [2] - https://wso2.org/jira/browse/IDENTITY-3457 Thanks, Thanuja -- *Thanuja Lakmal* Senior Software Engineer WSO2 Inc. http://wso2.

Re: [Dev] Please review and commit

Merged. Thanks. On Mon, Jun 15, 2015 at 5:58 PM, Godwin Amila Shrimal wrote: > Hi, > > https://github.com/wso2/carbon-identity/pull/438 > > Thanks > Godwin > > -- > *Godwin Amila Shrimal* > Senior Software Engineer > WSO2 Inc.; http://wso2.com > lean.enterprise.middleware > > mobile: *+94772264

[Dev] Please review and commit

Hi, https://github.com/wso2/carbon-identity/pull/438 Thanks Godwin -- *Godwin Amila Shrimal* Senior Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: *+94772264165* linkedin: *http://lnkd.in/KUum6D * twitter: https://twitter.com/godwinamila

Re: [Dev] Please review and commit the fix for REGISTRY-2561

Hi Manoj, I got this fix reviewed by Carbon and Registry teams ((Kishanthan, Sagara, Chandana). In the fix review it was decided to add this DataHolder class. Thanks, Bhathiya On Tue, Jun 9, 2015 at 5:05 PM, Manoj Kumara wrote: > Hi Bhathiya, > > I can see that you have introduced a new Data

Re: [Dev] Please review and commit the fix for REGISTRY-2561

Hi Bhathiya, I can see that you have introduced a new DataHolder class with the fix. Even though this is the proper pattern to follow since we are not allowing introducing such changes with patches how to proceed on this. Regards, Manoj *Manoj Kumara |* Senior Software Engineer Inc. *| **lean.

[Dev] Please review and commit the fix for REGISTRY-2561

Hi Kishanthan, Please review and commit the fix[1] to patch 11. Fix diff is attached to the JIRA itself. [1] https://wso2.org/jira/browse/REGISTRY-2561 Thanks, -- *Bhathiya Jayasekara* *Senior Software Engineer,* *WSO2 inc., http://wso2.com * *Phone: +94715478185* *LinkedIn: h

Re: [Dev] Please review and commit

Committed revision 212440. On Mon, May 11, 2015 at 7:52 PM, Madhawa Gunasekara wrote: > Hi Devs, > > Please find the correct svn diff. > > Thanks, > Madhawa > > On Mon, May 11, 2015 at 4:51 PM, Madhawa Gunasekara > wrote: > >> Hi Devs, >> >> Please review and commit, Please find the attached sv

Re: [Dev] Please review and commit

Hi Devs, Please find the correct svn diff. Thanks, Madhawa On Mon, May 11, 2015 at 4:51 PM, Madhawa Gunasekara wrote: > Hi Devs, > > Please review and commit, Please find the attached svn diff for the JIRA > issue https://wso2.org/jira/browse/CARBON-15239 > > > Thanks, > Madhawa > -- > *Madhaw

[Dev] Please review and commit

Hi Devs, Please review and commit, Please find the attached svn diff for the JIRA issue https://wso2.org/jira/browse/CARBON-15239 Thanks, Madhawa -- *Madhawa Gunasekara* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 719411002 <+94+719411002> blog: *http://

Re: [Dev] Please review and commit

Kind reminder. On Sun, Apr 26, 2015 at 11:37 PM, Godwin Amila Shrimal wrote: > Hi, > > Please review and commit the diff attached in [1] > > [1] https://wso2.org/jira/browse/IDENTITY-3166 > > > Thanks > Godwin > > > -- > *Godwin Amila Shrimal* > Senior Software Engineer > WSO2 Inc.; http://wso2.

[Dev] Please review and commit

Hi, Please review and commit the diff attached in [1] [1] https://wso2.org/jira/browse/IDENTITY-3166 Thanks Godwin -- *Godwin Amila Shrimal* Senior Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: *+94772264165* linkedin: *http://lnkd.in/KUum6D

Re: [Dev] Please review and commit attached test cases

Adding Sanjeewa On Fri, Jan 16, 2015 at 10:54 AM, Dinesh J Weerakkody wrote: > Hi, > > I have attached herewith test cases and configuration files for > >- Custom sequence execution on API invocation >- Performance test for My subscription page of API Store > > Please review and commit t

Re: [Dev] Please Review and Commit

Done, revision r210870. On Tue, Jan 6, 2015 at 12:59 PM, Sam Sivayogam wrote: > Hi Nuwan > > I attached the test classes for the following jira > https://wso2.org/jira/browse/APIMANAGER-3154 > > Pls review and commit > > > Thanks > -- > *Sam Sivayogam* > > Software Engineer > Mobile : +94 772 9

[Dev] Please Review and Commit

Hi Nuwan I attached the test classes for the following jira https://wso2.org/jira/browse/APIMANAGER-3154 Pls review and commit Thanks -- *Sam Sivayogam* Software Engineer Mobile : +94 772 906 439 Office : +94 112 145 345 *WSO2, Inc. :** wso2.com * lean.enterprise.middlewa

[Dev] Please review and commit patches

Hi, Please review and commit following JIRAs. https://wso2.org/jira/browse/IDENTITY-2914 https://wso2.org/jira/browse/IDENTITY-2948 https://wso2.org/jira/browse/IDENTITY-2949 https://wso2.org/jira/browse/IDENTITY-2959 Thanks, Malithi. -- *Malithi Edirisinghe* Senior Software Engineer WSO2 Inc

Re: [Dev] Please review and commit

On Tue, Dec 23, 2014 at 2:54 PM, Lahiru Cooray wrote: > Hi, > > Please merge the PR > https://github.com/wso2/app-manager/pull/108 > Done. Thanks . > > -- > *Lahiru Cooray* > Software Engineer > WSO2, Inc.;http://wso2.com/ > lean.enterprise.middleware > > Mobile: +94 715 654154 > -- Dinusha

[Dev] Please review and commit

Hi, Please merge the PR https://github.com/wso2/app-manager/pull/108 -- *Lahiru Cooray* Software Engineer WSO2, Inc.;http://wso2.com/ lean.enterprise.middleware Mobile: +94 715 654154 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/l

[Dev] Please review and commit : APPM-265

Hi, Please merge the PR https://github.com/wso2/app-manager/pull/94 -- *Lahiru Cooray* Software Engineer WSO2, Inc.;http://wso2.com/ lean.enterprise.middleware Mobile: +94 715 654154 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/lis

[Dev] Please review and commit APIMANAGER-3218

Hi, Please review and commit [1] [1] https://wso2.org/jira/browse/APIMANAGER-3218 Thank you. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 Twitter | Google+ | LinkedIn

Re: [Dev] Please review and commit : APPM-155

Hi Ruwan, Yes, there are many similar hard coded texts in the existing code base and I think we need to change all the occurrences.. Thanks.. On Tue, Dec 16, 2014 at 10:25 PM, Ruwan Yatawara wrote: > > Hi Lahiru, > > Small suggestion. Noticed that a bunch of text such as Allows 5 > request(s)

Re: [Dev] Please review and commit : APPM-155

Hi Lahiru, Small suggestion. Noticed that a bunch of text such as Allows 5 request(s) per minute. are hard coded. Actually these tier value are subject to change once the tiers.xml is changed. Hence it would be best to load these values dynamically, else it would be reported as another bug later

[Dev] Please review and commit : APPM-155

Hi, Please merge the PR https://github.com/wso2/app-manager/pull/92 -- *Lahiru Cooray* Software Engineer WSO2, Inc.;http://wso2.com/ lean.enterprise.middleware Mobile: +94 715 654154 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/l

[Dev] Please review and commit APIMANAGER-3203

Hi, Please review and commit the changes for, https://wso2.org/jira/browse/APIMANAGER-3203 Thank you. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 Twitter | Google+ | LinkedIn

[Dev] Please review and commit : APPM-224

Hi, Please merge the PR https://github.com/wso2/app-manager/pull/89 (fix for : https://wso2.org/jira/browse/APPM-224) -- *Lahiru Cooray* Software Engineer WSO2, Inc.;http://wso2.com/ lean.enterprise.middleware Mobile: +94 715 654154 ___ Dev mailing l

[Dev] [DEV] Please review and commit

Hi, I have attached a diff file herewith which has test cases and some improvements to TestUtil class. This diff contain testcases for following jiras https://wso2.org/jira/browse/APIMANAGER-3017 https://wso2.org/jira/browse/APIMANAGER-3149 https://wso2.org/jira/browse/APIMANAGER-2957 Modificati

[Dev] Please review and commit

Hi, Please review and commit these jiras. [1] https://wso2.org/jira/browse/APIMANAGER-3119 [2] https://wso2.org/jira/browse/APIMANAGER-2835 [3] https://wso2.org/jira/browse/APIMANAGER-2656 Thanks -- Lakshman Udayakantha WSO2 Inc. www.wso2.com lean.enterprise.middleware Mobile: *0711241005* __