Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-16 Thread Sriskandarajah Suhothayan
Ok great On Sun, Dec 17, 2017 at 11:45 AM, Damith Wickramasinghe wrote: > @Suho yes this is fixed. > > > Regards, > Damith > > On Sun, Dec 17, 2017 at 9:40 AM, Eranga Liyanage wrote: > >> Damith has already fixed this Suho. >> >> Best regards >> Eranga >> >> On Sun, Dec 17, 2017 at 9:27 AM, Sri

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-16 Thread Damith Wickramasinghe
@Suho yes this is fixed. Regards, Damith On Sun, Dec 17, 2017 at 9:40 AM, Eranga Liyanage wrote: > Damith has already fixed this Suho. > > Best regards > Eranga > > On Sun, Dec 17, 2017 at 9:27 AM, Sriskandarajah Suhothayan > wrote: > >> Can we get it fixed ASAP. >> >> Regards >> Suho >> >> O

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-16 Thread Eranga Liyanage
Damith has already fixed this Suho. Best regards Eranga On Sun, Dec 17, 2017 at 9:27 AM, Sriskandarajah Suhothayan wrote: > Can we get it fixed ASAP. > > Regards > Suho > > On Thu, Dec 14, 2017 at 2:03 AM Damith Wickramasinghe > wrote: > >> @Grainier . Thanks for pointing it out . yes we need

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-16 Thread Sriskandarajah Suhothayan
Can we get it fixed ASAP. Regards Suho On Thu, Dec 14, 2017 at 2:03 AM Damith Wickramasinghe wrote: > @Grainier . Thanks for pointing it out . yes we need to use the substring > method. we have use the same split in other areas. we need to fix this. > > Regards, > Damith > > On Thu, Dec 14, 201

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-13 Thread Damith Wickramasinghe
@Grainier . Thanks for pointing it out . yes we need to use the substring method. we have use the same split in other areas. we need to fix this. Regards, Damith On Thu, Dec 14, 2017 at 1:54 AM, Grainier Perera wrote: > @Raveen, You have used to text.split(".")[0] to to remove .siddhi postfix >

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-13 Thread Grainier Perera
@Raveen, You have used to text.split(".")[0] to to remove .siddhi postfix right. But Siddhi allows having full stop ".", and ".siddhi" in the Siddhi App name. So this might not work... Try something like text.substring(0, text.lastIndexOf(".siddhi")) @Others, please check whether the editor works

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-11 Thread Raveen Rathnayake
Hi all, I have removed displaying ".siddhi" clause from the tab and removed the ".siddhi" postfix from ".siddhi" in save to file placeholder as well. This PR[1] relevant changes. [1] https://github.com/wso2/carbon-analytics/pull/849 Thank you. Raveen. On Sat, Dec 9, 2017 at 11:53 PM, Damit

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-09 Thread Damith Wickramasinghe
Hi All, Yes +1 . I will inc-operate the changes . Regards, Damith On Fri, Dec 8, 2017 at 6:57 PM, Ramindu De Silva wrote: > Hi all, > > +1 for Erangas suggestion. > We may need to remove the ".siddhi" postfix from ".siddhi" in save to > file placeholder as well. Currently, we, either way,

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-08 Thread Ramindu De Silva
Hi all, +1 for Erangas suggestion. We may need to remove the ".siddhi" postfix from ".siddhi" in save to file placeholder as well. Currently, we, either way, add .siddhi extension when saving the file. Best Regards, Ramindu. On Fri, Dec 8, 2017 at 11:16 AM, Eranga Liyanage wrote: > Hi All,

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-07 Thread Eranga Liyanage
Hi All, Yes, we can show the .siddhi extension on workspace tree. Users first interaction with the file is either Save, Open, or Import. On those interfaces also we show that it's a .siddhi extension file, so users won't get confused by removing it from the tab. Best regards. Eranga On Fri, Dec

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-07 Thread Jason De Silva
Hi Damith / Eranga, If I am the user I would like to know the extension of the file. So +1 to at least show the .siddhi extension in workspace tree/dropdown if we are removing it from the tabs. Regards, Jason Jason De Silva *Software Engineer - QA* Mobile: +94 (0) 772 097 678 Email: jas...@wso2.

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-07 Thread Damith Wickramasinghe
Hi Eranga, I understand your point but my only issue is not conveying user that these files use .siddhi extension. So shall we at least keep the .siddhi extension in workspace dropdown as we are showing the actual files there. So that user knows it. And we can remove the .siddhi extensions in tabs

Re: [Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-06 Thread Eranga Liyanage
Hi Damith, In editors usually, we can edit multiple file types. So when the respective file is opened it shows the file type with it for easy identification. But in our case, we support only .siddhi files and we open files from our own workspace which contains only siddhi files. Many single file

[Dev] Stream Processor Editor - Removing .siddhi file extension from showing on the ui

2017-12-06 Thread Damith Wickramasinghe
Hi Eranga/ All, In stream processor we support only files with .siddhi extension. Even though it is the case IMO user needs to know that the file should have .siddhi extension. Because one can just copy paste a file to workspace directory of editor without adding the .siddhi extension when he see