Re: [Dev] kafka UI improvement (ESBJAVA-3915)

Have you tested the other inbound type after the change? On Mon, Jul 20, 2015 at 10:50 AM, Shakila Sivagnanarajah shak...@wso2.com wrote: Hi Malaka, I have modified the code according to your comment. Please find the PR [1]. [1] https://github.com/wso2/carbon-mediation/pull/294 Thank you

Re: [Dev] kafka UI improvement (ESBJAVA-3915)

Hi Shakila, You can run the ESB Kafka Inbound sample 904 and make sure other Kafka functionality is not affected. Thanks, Kathees On Mon, Jul 20, 2015 at 9:51 PM, Shakila Sivagnanarajah shak...@wso2.com wrote: Yes Malaka, I have tested with this change. This does not affect others. On Mon,

Re: [Dev] kafka UI improvement (ESBJAVA-3915)

Yes Malaka, I have tested with this change. This does not affect others. On Mon, Jul 20, 2015 at 5:47 PM, Malaka Silva mal...@wso2.com wrote: Have you tested the other inbound type after the change? On Mon, Jul 20, 2015 at 10:50 AM, Shakila Sivagnanarajah shak...@wso2.com wrote: Hi

Re: [Dev] kafka UI improvement (ESBJAVA-3915)

in your pull request i can see unwanted binary file (.DS_Store) . Please remove it from the PR On Mon, Jul 20, 2015 at 11:23 AM, Kathees Rajendram kath...@wso2.com wrote: Hi Shakila, You can run the ESB Kafka Inbound sample 904 and make sure other Kafka functionality is not affected.

Re: [Dev] kafka UI improvement (ESBJAVA-3915)

Thanks Vanjikumaran, Now I have removed the file. On Tue, Jul 21, 2015 at 1:43 AM, Vanjikumaran Sivajothy va...@wso2.com wrote: in your pull request i can see unwanted binary file (.DS_Store) . Please remove it from the PR On Mon, Jul 20, 2015 at 11:23 AM, Kathees Rajendram kath...@wso2.com

Re: [Dev] kafka UI improvement (ESBJAVA-3915)

Hi Malaka, I have modified the code according to your comment. Please find the PR [1]. [1] https://github.com/wso2/carbon-mediation/pull/294 Thank you On Fri, Jul 17, 2015 at 5:21 PM, Malaka Silva mal...@wso2.com wrote: Hi Shakila, Added some comments. Did you check other inbound

Re: [Dev] kafka UI improvement (ESBJAVA-3915)

Hi Shakila, Added some comments. Did you check other inbound protocols with this change? Don't we need to apply the same for update page as well? On Fri, Jul 17, 2015 at 4:55 PM, Shakila Sivagnanarajah shak...@wso2.com wrote: Hi Malaka, Please review and merge PR[1] for $subject. [1]

[Dev] kafka UI improvement (ESBJAVA-3915)

Hi Malaka, Please review and merge PR[1] for $subject. [1] https://github.com/wso2/carbon-mediation/pull/294 Thank you -- Shakila Sivagnanarajah Associate Software Engineer Mobile :+94 (0) 770 760240 shak...@wso2.com ___ Dev mailing list