Re: [Dev] Please review and merge PR

On Thu, Feb 22, 2018 at 10:29 AM, SajithAR Ariyarathna wrote: > Hi Devs, > > Please review & merged PR https://github.com/wso2/carbon-appmgt/pull/709 > which fixes https://github.com/wso2/carbon-appmgt/issues/708 . > Merged. Regards, Dinusha > > Thanks. > > -- > Sajith Janaprasad Ariyarathna >

Re: [Dev] Please review and merge PR

Hi, I,m using salesforce connector in EI-6.1.1. I use this to query the salesforce objects using query and queryMore functions. The first query works, but of you do not do anything for about three hours and then call again. EI get a connection in the connection pool and make an http call and ret

Re: [Dev] Please review and merge PR

Hi Kim, Thank you for your contribution. We are reviewing your PR. As we are trying to reproduce the issue, can you please provide the exact scenario where you faced this issue? Thank you and regards, Nishadi On Sun, Feb 4, 2018 at 9:31 PM, 김대경 wrote: > > I wonder how it is progressing... > >

Re: [Dev] Please review and merge PR

I wonder how it is progressing... 2018. 1. 26. 오후 1:31에 "김대경" 님이 작성: Can you please review and merge PR[1] . [1] https://github.com/wso2/wso2-commons-httpclient/pull/18 Best Regards. Daekyung Kim. ___ Dev mailing list Dev@wso2.org http://wso2.org/cg

Re: [Dev] Please review and merge PR

Hi Nuwandi, PR is now merged. Thanks *Prasanna Dangalla* Senior Software Engineer, WSO2, Inc.; http://wso2.com/ lean.enterprise.middleware *cell: +94 718 11 27 51* *twitter: @prasa77* On Mon, Dec 4, 2017 at 10:35 AM, Nuwandi Wickramasinghe wrote: > Hi, > > Please review and merge [1] > > [1

Re: [Dev] Please review and merge PR

Hi Kim, Thanks a lot for your contribution. We'll do the needful. Thanks. On Mon, Nov 13, 2017 at 8:53 AM, Harsha Kumara wrote: > > > On Sun, Nov 12, 2017 at 7:28 PM, 김대경 wrote: > >> Can you please review and merge PR[1] and PR[2]. >> >> [1] https://github.com/wso2/wso2-synapse/pull/952 >> [2

Re: [Dev] Please review and merge PR

On Sun, Nov 12, 2017 at 7:28 PM, 김대경 wrote: > Can you please review and merge PR[1] and PR[2]. > > [1] https://github.com/wso2/wso2-synapse/pull/952 > [2] https://github.com/wso2/carbon-mediation/pull/906 > > Best Regards. > Daekyung Kim. > > ___ > Dev

Re: [Dev] Please review and merge PR

Hi Johann, Sorry for the mistake. I have sent two separate emails for the issue. On Thu, Oct 12, 2017 at 11:55 AM, Johann Nallathamby wrote: > Hi Isuranga, > > First of all thank you for your contribution to WSO2 Identity Server. > > However, can you please follow the following protocol in orde

Re: [Dev] Please review and merge PR

Hi Isuranga, First of all thank you for your contribution to WSO2 Identity Server. However, can you please follow the following protocol in order to get your PRs merged faster. 1. Create one JIRA per issue. Make sure you give the description clearly. Add the PRs related to the issue in the JIRA.

Re: [Dev] Please review and merge PR

Thanks Thusitha! On Tuesday, September 19, 2017, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Farasath, > > Merged the PR. > > > > > On Tue, Sep 19, 2017 at 6:36 PM, Farasath Ahamed > wrote: > >> Hi, >> >> Can you please review and merge the following PR[1]. This needs to go >> i

Re: [Dev] Please review and merge PR

Hi Farasath, Merged the PR. On Tue, Sep 19, 2017 at 6:36 PM, Farasath Ahamed wrote: > Hi, > > Can you please review and merge the following PR[1]. This needs to go into > Kernel 4.4.18 > > [1] https://github.com/wso2/carbon-kernel/pull/1538 > > > > > Thanks, > Farasath Ahamed > Software Engi

Re: [Dev] Please review and merge PR for kernel

@thusitha: since the PR is sent to the 4.4.x branch, it will not close the issue when the PR is merged. Therefore we will have to close the issue after merging the PR. Regards, Nira On Thu, Sep 14, 2017 at 11:28 AM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Pulasthi, > > PR me

Re: [Dev] Please review and merge PR for kernel

Hi Pulasthi, PR merged. Thanks Thusitha On Thu, Sep 14, 2017 at 6:51 PM, Pulasthi Mahawithana wrote: > Hi, > > Please review and merge [1], which fixes [2]. Related Identity JIRA is at > [3]. > > [1] https://github.com/wso2/carbon-kernel/pull/1527 >

Re: [Dev] Please review and merge PR

Thanks Godwin On Wednesday, 2 December 2015, Godwin Shrimal wrote: > Merged PR > https://github.com/wso2/carbon-identity/commit/55fff392dc59b0724645d7f5fbfcc55a2176a710 > > On Mon, Nov 30, 2015 at 11:25 AM, Nuwan Dias > wrote: > >> Hi Godwin, >> >> Can we get this merged please? APIM has a bloc

Re: [Dev] Please review and merge PR

Merged PR https://github.com/wso2/carbon-identity/commit/55fff392dc59b0724645d7f5fbfcc55a2176a710 On Mon, Nov 30, 2015 at 11:25 AM, Nuwan Dias wrote: > Hi Godwin, > > Can we get this merged please? APIM has a blocking issue depending on this > fix. > > Thanks, > NuwanD. > > On Fri, Nov 27, 2015

Re: [Dev] Please review and merge PR

Hi Godwin, Can we get this merged please? APIM has a blocking issue depending on this fix. Thanks, NuwanD. On Fri, Nov 27, 2015 at 12:36 PM, Malintha Amarasinghe wrote: > Hi Godwin, > > Added the fixes with [1] > > Thanks. > Malintha > > [1] > https://github.com/malinthaprasan/carbon-identity/

Re: [Dev] Please review and merge PR

Hi Godwin, Added the fixes with [1] Thanks. Malintha [1] https://github.com/malinthaprasan/carbon-identity/commit/b06e2039f4c86ee80c97186e36327b635feece31 On Fri, Nov 27, 2015 at 10:32 AM, Godwin Shrimal wrote: > Hi Malintha, > > Please check the comments in the PR. > > > Thanks > Godwin > >

Re: [Dev] Please review and merge PR

Hi Malintha, Please check the comments in the PR. Thanks Godwin On Thu, Nov 26, 2015 at 3:15 PM, Malintha Amarasinghe wrote: > Hi IS Team, > > Can you please merge the following PR [1]. This contains a new NTLM grant > handler which fixes the following JiRA [2]. > > [1] https://github.com/w

Re: [Dev] Please Review and Merge PR

Merged. Thanks Isura On Thu, Jul 16, 2015 at 10:34 AM, Chamila Wijayarathna wrote: > Hi, > > Please review and merge PR, > https://github.com/wso2/charon/pull/18 > > Thank You! > > -- > *Chamila Dilshan Wijayarathna,* > Software Engineer > Mobile:(+94)788193620 > WSO2 Inc., http://wso2.com/ >

Re: [Dev] Please review and merge PR

Thanks Anuruddha! I have now merged the pull request. On Mon, Jul 13, 2015 at 11:09 AM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi, > > $subject please for PR [1]. > This containing changes to add Hbase and mysql configurations to DAS > docker images. > > > [1] https://github.com/

Re: [Dev] Please review and merge PR for IDENTITY-3347

Created the PR [1] for adding the new html file for passive sts response. Please merge it as well. [1] https://github.com/wso2/carbon-identity/pull/551/files Thanks, TharinduE On Sat, Jul 4, 2015 at 1:09 AM, Kasun Bandara wrote: > Hi, > > Please $Subject the PR [1] as the Fix for the Public J

Re: [Dev] Please Review and Merge PR

merged On Wed, Jun 17, 2015 at 3:44 PM, Sriashalya Srivathsan wrote: > Hi Malaka, > > $subject for bitbucket > https://github.com/wso2/esb-connectors/pull/156 > > -- > Regards > S.Sriashalya, > WSO2 *Inc*. > lean . enterprise . middleware > -- Best Regards, Malaka Silva Senior Tech Lead M:

Re: [Dev] Please review and merge PR

Merged On Tue, Jun 16, 2015 at 4:45 PM, Sriashalya Srivathsan wrote: > Hi Malaka, > Please find zendesk also in the same pull request > > On Tue, Jun 16, 2015 at 3:19 PM, Sriashalya Srivathsan > wrote: > >> Hi Malaka, >> $subject for Gmail connector >> >> https://github.com/wso2/esb-connectors/

Re: [Dev] Please review and merge PR

Hi Malaka, Please find zendesk also in the same pull request On Tue, Jun 16, 2015 at 3:19 PM, Sriashalya Srivathsan wrote: > Hi Malaka, > $subject for Gmail connector > > https://github.com/wso2/esb-connectors/pull/138/ > > -- > Regards > S.Sriashalya, > WSO2 *Inc*. > lean . enterprise . middlew

Re: [Dev] Please review and merge PR

done. On Wed, Jun 10, 2015 at 9:05 AM, Jagath Sisirakumara Ariyarathne < jaga...@wso2.com> wrote: > Hi, > > Please review and merge PR[1] for JIRA issue[2]. > > [1] - https://github.com/wso2/wso2-synapse/pull/220 > [2] - https://wso2.org/jira/browse/ESBJAVA-3735 > > Thanks. > -- > Jagath Ariyarat

Re: [Dev] Please review and merge PR

Thanks Supun for bringing it up. On Mon, Jun 1, 2015 at 4:40 PM, Supun Sethunga wrote: > Great! sorry for the noise :) > > On Mon, Jun 1, 2015 at 4:36 PM, Nirmal Fernando wrote: > >> Yes, We've done various fixes with regards to dataset parsing. >> >> On Mon, Jun 1, 2015 at 4:16 PM, Manorama Pe

Re: [Dev] Please review and merge PR

Great! sorry for the noise :) On Mon, Jun 1, 2015 at 4:36 PM, Nirmal Fernando wrote: > Yes, We've done various fixes with regards to dataset parsing. > > On Mon, Jun 1, 2015 at 4:16 PM, Manorama Perera wrote: > >> Hi Supun, >> >> I've tested for quoted column headers using the linear regression

Re: [Dev] Please review and merge PR

Yes, We've done various fixes with regards to dataset parsing. On Mon, Jun 1, 2015 at 4:16 PM, Manorama Perera wrote: > Hi Supun, > > I've tested for quoted column headers using the linear regression sample, > by adding beginning and ending double quotes to the column headers of the > dataset. >

Re: [Dev] Please review and merge PR

Hi Supun, I've tested for quoted column headers using the linear regression sample, by adding beginning and ending double quotes to the column headers of the dataset. "fixed acidity","volatile acidity","citric acid",., "quality" Model building and prediction were successful. As you've menti

Re: [Dev] Please review and merge PR

Hi Manorama, Think this continues from there onwards as well. I mean, even if we continued from the UI, at the model building step, you will notice that the model building is failing. The issue was with the spark filter we used to remove the header. Reason behind this was, spark reads each row wi

Re: [Dev] Please review and merge PR

Ok, thanks for the clarification. On Mon, Jun 1, 2015 at 2:32 PM, Manorama Perera wrote: > The issue noticed is, the analysis steps cannot be proceeded after the > explore step. There's no exception trace shown. > > The ajax request sending fails when double quotes are included in the json > pay

Re: [Dev] Please review and merge PR

The issue noticed is, the analysis steps cannot be proceeded after the explore step. There's no exception trace shown. The ajax request sending fails when double quotes are included in the json payload. Thanks. On Mon, Jun 1, 2015 at 2:21 PM, Nirmal Fernando wrote: > Merged. Thanks. > > Can yo

Re: [Dev] Please review and merge PR

Merged. Thanks. Can you please add the exception stack trace to the Jira too? On Mon, Jun 1, 2015 at 2:14 PM, Manorama Perera wrote: > Hi, > > Please find the fix [1] for JIRA [2]. > > [1] https://github.com/wso2/product-ml/pull/154 > [2] https://wso2.org/jira/browse/ML-22 > > -- > Manorama Per

Re: [Dev] Please review and merge PR

Hi, PR is ready to merge. Thanks On Fri, May 29, 2015 at 10:29 AM, Malintha Amarasinghe wrote: > Hi, > > Please do not merge due to some modifications. > > Thanks. > > On Thu, May 28, 2015 at 4:54 PM, Malintha Amarasinghe > wrote: > >> Hi, >> >> Please review and merge PR [1] for Jira [2]. >>

Re: [Dev] Please review and merge PR

Hi, Please do not merge due to some modifications. Thanks. On Thu, May 28, 2015 at 4:54 PM, Malintha Amarasinghe wrote: > Hi, > > Please review and merge PR [1] for Jira [2]. > > Thanks. > > [1] https://github.com/wso2/carbon-apimgt/pull/528 > [2] https://wso2.org/jira/browse/APIMANAGER-3155 >

Re: [Dev] Please review and merge PR

Hi Manoj/Jagath, Please revert this change. We don't allow API Changes in patch releases. On Wed, May 20, 2015 at 9:10 AM, Manoj Kumara wrote: > Merged to master branch. Will be available on Carbon 4.4.1 release. > > > *Manoj Kumara* > Software Engineer > WSO2 Inc. http://wso2.com/ > *lean.en

Re: [Dev] Please review and merge PR

Great work Manorama!! On Thu, May 21, 2015 at 8:32 PM, Supun Sethunga wrote: > Thanks Manorama! > > On Thu, May 21, 2015 at 4:22 PM, Manorama Perera > wrote: > >> Hi, >> >> Please review and merge PR [1] - PMML extension. >> >> [1] https://github.com/wso2-gpl/siddhi/pull/9 >> >> Thanks >> -- >>

Re: [Dev] Please review and merge PR

Thanks Manorama! On Thu, May 21, 2015 at 4:22 PM, Manorama Perera wrote: > Hi, > > Please review and merge PR [1] - PMML extension. > > [1] https://github.com/wso2-gpl/siddhi/pull/9 > > Thanks > -- > Manorama Perera > Software Engineer > WSO2, Inc.; http://wso2.com/ > Mobile : +94716436216 >

Re: [Dev] Please review and merge PR

merged Thanks for the quick fix Suho On Thu, May 21, 2015 at 4:34 PM, Nirmal Fernando wrote: > [Looping CEP Team] > > On Thu, May 21, 2015 at 4:22 PM, Manorama Perera > wrote: > >> Hi, >> >> Please review and merge PR [1] - PMML extension. >> >> [1] https://github.com/wso2-gpl/siddhi/pull/9 >

Re: [Dev] Please review and merge PR

[Looping CEP Team] On Thu, May 21, 2015 at 4:22 PM, Manorama Perera wrote: > Hi, > > Please review and merge PR [1] - PMML extension. > > [1] https://github.com/wso2-gpl/siddhi/pull/9 > > Thanks > -- > Manorama Perera > Software Engineer > WSO2, Inc.; http://wso2.com/ > Mobile : +94716436216 >

Re: [Dev] Please review and merge PR for APIMANAGER-3596

Merged 2e0277ad3bf2622d97b7fea68a568d24db1b0b78 Thanks, NuwanD. On Wed, May 20, 2015 at 1:04 PM, Kasun Gunasekara wrote: > Hi, > > Please review and merge PR[1] for Jira [2] > > [1] https://github.com/wso2/carbon-apimgt/pull/433 > [2] https://wso2.org/jira/browse/APIMANAGER-3596 > > Regards. >

Re: [Dev] Please review and merge PR

Merged to master branch. Will be available on Carbon 4.4.1 release. *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Wed, Apr 8, 2015 at 10:22 PM, Jagath Sisirakumara Ariyarathne < jaga...@wso2.com> wrote: > Hi Sameera, > > This PR

Re: [Dev] Please review and merge PR for APIMANAGER-3573

Merged in e5a6583a9c77ed3792dd66fac2c9969f1e2bbf05. Please resolve the JiRA. Thanks, NuwanD. On Tue, May 19, 2015 at 2:55 PM, Sam Sivayogam wrote: > Hi, > > Please review and merge PR [1] for Jira [2] > [1] https://github.com/wso2/carbon-apimgt/pull/369 > [2] https://wso2.org/jira/browse/APIMAN

Re: [Dev] Please review and merge PR for APIMANAGER-3595

Merged in d184f5ff42651f388a48f099031f4712d5e57dd0 On Tue, May 19, 2015 at 2:35 PM, Kasun Gunasekara wrote: > Hi, > > Please review and merge PR [1] for Jira [2] > > [1] https://github.com/wso2/carbon-apimgt/pull/417 > [2] https://wso2.org/jira/browse/APIMANAGER-3595 > > Thank you. > > Kasun Gun

Re: [Dev] Please review and merge PR

Hi Suho, I've fixed those issues. Thanks. On Mon, May 18, 2015 at 2:02 PM, Sriskandarajah Suhothayan wrote: > added some comments fix them I'll merge > > Suho > > On Mon, May 18, 2015 at 12:32 PM, Supun Sethunga wrote: > >> [Adding Suho] >> >> On Mon, May 18, 2015 at 12:29 PM, Manorama Perera

Re: [Dev] Please review and merge PR

added some comments fix them I'll merge Suho On Mon, May 18, 2015 at 12:32 PM, Supun Sethunga wrote: > [Adding Suho] > > On Mon, May 18, 2015 at 12:29 PM, Manorama Perera > wrote: > >> Hi, >> >> Please review and merge PR[1] - CEP Extension for ML Predictions. >> >> [1] https://github.com/wso2

Re: [Dev] Please review and merge PR

[Adding Suho] On Mon, May 18, 2015 at 12:29 PM, Manorama Perera wrote: > Hi, > > Please review and merge PR[1] - CEP Extension for ML Predictions. > > [1] https://github.com/wso2/siddhi/pull/50 > > Thanks. > -- > Manorama Perera > Software Engineer > WSO2, Inc.; http://wso2.com/ > Mobile : +947

Re: [Dev] Please review and merge PR

CEP,BAM,MB Teams, Please note the following PR #90. We've fixed some issues with the POM. Please raise if you have any concerns. On Fri, May 15, 2015 at 6:57 PM, Malithi Edirisinghe wrote: > Hi All, > > Please review and merge PR [1]. > > [1] https://github.com/wso2/carbon-commons/pull/90 > > T

Re: [Dev] Please review and merge PR

Thanks On Fri, May 15, 2015 at 8:48 PM, Manoj Kumara wrote: > Merged #90 > > > *Manoj Kumara* > Software Engineer > WSO2 Inc. http://wso2.com/ > *lean.enterprise.middleware* > Mobile: +94713448188 > > On Fri, May 15, 2015 at 8:33 PM, Manoj Kumara wrote: > >> Merged the requested pull requests #

Re: [Dev] Please review and merge PR

Merged #90 *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Fri, May 15, 2015 at 8:33 PM, Manoj Kumara wrote: > Merged the requested pull requests #89 and #35 > > > *Manoj Kumara* > Software Engineer > WSO2 Inc. http://wso2.com/ >

Re: [Dev] Please review and merge PR

Merged the requested pull requests #89 and #35 *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Fri, May 15, 2015 at 4:11 PM, Malithi Edirisinghe wrote: > Hi Manoj, > > Feature is added to the build path on #89. The respective com

Re: [Dev] Please review and merge PR

Hi Manoj, Feature is added to the build path on #89. The respective component is already removed from the build path in carbon-multitenancy and the existing feature imports the added feature of carbon-commons. On Fri, May 15, 2015 at 3:57 PM, Manoj Kumara wrote: > Hi Malithi, > > Can you pleas

Re: [Dev] Please review and merge PR

Hi Malithi, Can you please add the feature to the build path on #89 and remove the from #35 *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Fri, May 15, 2015 at 2:42 PM, Malithi Edirisinghe wrote: > Hi All, > > Please review and

Re: [Dev] Please review and merge PR

For IS 5.1.0 release we are planning to go with the carbon-commons because we anyway will be releasing carbon-commons due to other issues, so this change will also get released. Otherwise we have to do a carbon-analytics-common-1.0.1 for this alone. We will migrate to analytics-commons from next ve

Re: [Dev] Please review and merge PR

Thanks Suho for the clarification. On 15 May 2015 at 12:18, Sriskandarajah Suhothayan wrote: > Yes we are deprecating data bridge in carbon-commons but not removed now > as it might break other products, so please don't use that any more, > migrate to the one on carbon-analytics-common. > After

Re: [Dev] Please review and merge PR

Yes we are deprecating data bridge in carbon-commons but not removed now as it might break other products, so please don't use that any more, migrate to the one on carbon-analytics-common. After the next release it will be removed from carbon-commons. Suho On Fri, May 15, 2015 at 11:44 AM, Lasant

Re: [Dev] Please review and merge PR

Hi Suho, Is data-bridge to be kept in carbon-commons repo? I thought we kept it in carbon-analytics-common? Sorry if this was communicated earlier and I had missed the mail.. Thanks, Lasantha On 15 May 2015 at 11:31, Sriskandarajah Suhothayan wrote: > looks good merged > > Suho > > On Fri, Ma

Re: [Dev] Please review and merge PR

looks good merged Suho On Fri, May 15, 2015 at 10:31 AM, Malithi Edirisinghe wrote: > Hi All, > > Please review and merge PR [1] that fixes libthrift and slf4j import > package versions of org.wso2.carbon.databridge.commons.thrift. > [1] https://github.com/wso2/carbon-commons/pull/88 > > -- > >

Re: [Dev] Please Review and Merge PR

Reviewed and merged. Thanks, Lakmali On 11 May 2015 at 20:56, Chamalee De Silva wrote: > Hi, > > Please $subject [1] for issue [2]. > > [1] https://github.com/wso2/carbon-apimgt/pull/368 > [2] https://wso2.org/jira/browse/APIMANAGER-3547 > > > -- > Thanks & Regards, > > *Chamalee De Silva* > So

Re: [Dev] Please review and merge PR for APIMANAGER-3413

On Wed, Apr 29, 2015 at 7:52 PM, Kasun Gunasekara wrote: > What I've done here is simply removing the "checked" by default attribute > from HTTP checkbox and adding a tooltip to warn users the insecurity of > using HTTP. I don't think it will affect the functionality of the API > Console or any o

Re: [Dev] Please review and merge PR for APIMANAGER-3413

What I've done here is simply removing the "checked" by default attribute from HTTP checkbox and adding a tooltip to warn users the insecurity of using HTTP. I don't think it will affect the functionality of the API Console or any other workflow. Regards. Kasun Gunasekara Software Engineering Int

Re: [Dev] Please review and merge PR for APIMANAGER-3413

Guys, please test the API Console functionality after this change. We might also have to highlight this fact in the docs, mentioning that the API by default is only available over https. People will have to be aware of the certificate issues that they will come across when trying out the basics. Sp

Re: [Dev] Please review and merge PR

Hi, I've include the modifications to the mediator as suggested in the reviews. Please find the updated PR [1]. [1] https://github.com/wso2/carbon-mediation/pull/100 Thanks On Wed, Apr 1, 2015 at 9:58 AM, Manorama Perera wrote: > Hi, > > Please review and merge PR[1] - Machine Learner Mediato

Re: [Dev] Please review and merge PR for APIMANAGER-3413

Done. Thanks. On Wed, Apr 29, 2015 at 4:51 PM, Kasun Gunasekara wrote: > Hi, > > Please review and merge the PR [1] for JIRA [2]. > > [1] https://github.com/wso2/carbon-apimgt/pull/269 > [2} https://wso2.org/jira/browse/APIMANAGER-3413 > > Thanks. > > Kasun Gunasekara > Software Engineering Int

Re: [Dev] Please review and merge PR for APIMANAGER-3472

Done. Regards Roshan. On Tue, Apr 28, 2015 at 11:54 AM, Kasun Gunasekara wrote: > Hi, > > Please find the fix PR [1] for JIRA APIMANAGER-3472 [2], review and merge. > > [1] https://github.com/wso2/carbon-apimgt/pull/248 > [2] https://wso2.org/jira/browse/APIMANAGER-3472 > > Regards. > > Kasun G

Re: [Dev] Please review and merge PR

Hi Jagath, We will not include this fix as patch to Carbon 4.4.0 patch releases. There is an API change here. I am afraid this is too late. Thanks, Sameera. On Wed, Apr 8, 2015 at 10:22 PM, Jagath Sisirakumara Ariyarathne < jaga...@wso2.com> wrote: > Hi Sameera, > > This PR contains a new funct

Re: [Dev] Please review and merge PR

Hi Sameera, This PR contains a new functionality required for the mentioned redmine issue [1]. This feature will be included in ESB 4.9.0 release. Is there any possibility to get above changes merged to an upcoming patch of carbon kernel or what would be the procedure to get this released? Thank

Re: [Dev] Please review and merge PR for APPM-731

Hi Dinusha, I have committed development as a feature. Please review and marge the PR[1] and PR[2]. [1]. https://github.com/wso2/carbon-appmgt/pull/28 [2]. https://github.com/wso2/product-app-manager/pull/188 *Sajith Abeywardhana* | Software Engineer WSO2, Inc | lean. enterprise. middleware. #20

Re: [Dev] Please review and merge PR for APPM-731

Thanks Sajith .. Usually custom mediators should go into repository/droppings directory .. But since this is a part of AppM functionality, it's good to include as feature and bundle into pack. So create a feature for this and include into appm aggregate feature. You may need to keep modified main s

Re: [Dev] Please review and merge PR for IDENTITY-3077

Merged with f988bec6efccc2e8db754f03949a031115ec40d9 On Sun, Mar 1, 2015 at 8:28 PM, Malithi Edirisinghe wrote: > Hi Johann, > > Resolved the conflicts. > Could you please have a look. > > Thanks, > Malithi. > > On Sun, Mar 1, 2015 at 7:12 PM, Malithi Edirisinghe > wrote: > >> Sure. Will have a

Re: [Dev] Please review and merge PR for IDENTITY-3077

Hi Johann, Resolved the conflicts. Could you please have a look. Thanks, Malithi. On Sun, Mar 1, 2015 at 7:12 PM, Malithi Edirisinghe wrote: > Sure. Will have a look > > > On Sun, Mar 1, 2015 at 6:41 PM, Johann Nallathamby > wrote: > >> Hi Malithi, >> >> There are merge conflicts in PR. Can y

Re: [Dev] Please review and merge PR for IDENTITY-3077

Sure. Will have a look On Sun, Mar 1, 2015 at 6:41 PM, Johann Nallathamby wrote: > Hi Malithi, > > There are merge conflicts in PR. Can you fix them ? > > Thanks. > > On Sun, Mar 1, 2015 at 6:32 PM, Malithi Edirisinghe > wrote: > >> Hi, >> >> $subject please for JIRA [1]. >> >> [1] *https://ws

Re: [Dev] Please review and merge PR for IDENTITY-3077

Hi Malithi, There are merge conflicts in PR. Can you fix them ? Thanks. On Sun, Mar 1, 2015 at 6:32 PM, Malithi Edirisinghe wrote: > Hi, > > $subject please for JIRA [1]. > > [1] *https://wso2.org/jira/browse/IDENTITY-3077 > * > > Thanks, > Malithi >

Re: [Dev] Please review and merge PR for IDENTITY-2048

Merged. On Sat, Feb 21, 2015 at 10:54 PM, Malithi Edirisinghe wrote: > [Removing support-dev and adding dev@] > > On Sat, Feb 21, 2015 at 7:13 PM, Malithi Edirisinghe > wrote: > >> >> Hi, >> >> $subject please for JIRA [1]. >> >> [1] https://wso2.org/jira/browse/IDENTITY-2048 >> >> Thanks, >> M

Re: [Dev] Please review and merge PR for IDENTITY-2785

Merged. On Sat, Feb 21, 2015 at 10:55 PM, Malithi Edirisinghe wrote: > [Removing support-dev and adding dev@] > > On Sat, Feb 21, 2015 at 10:51 PM, Malithi Edirisinghe > wrote: > >> Hi, >> >> $subject please for JIRA [1]. >> >> [1] *https://wso2.org/jira/browse/IDENTITY-2785 >>

Re: [Dev] Please review and merge PR for IDENTITY-2785

[Removing support-dev and adding dev@] On Sat, Feb 21, 2015 at 10:51 PM, Malithi Edirisinghe wrote: > Hi, > > $subject please for JIRA [1]. > > [1] *https://wso2.org/jira/browse/IDENTITY-2785 > * > > Thanks, > Malithi > -- > > *Malithi Edirisinghe* > S

Re: [Dev] Please review and merge PR for IDENTITY-2048

[Removing support-dev and adding dev@] On Sat, Feb 21, 2015 at 7:13 PM, Malithi Edirisinghe wrote: > > Hi, > > $subject please for JIRA [1]. > > [1] https://wso2.org/jira/browse/IDENTITY-2048 > > Thanks, > Malithi > -- > > *Malithi Edirisinghe* > Senior Software Engineer > WSO2 Inc. > > Mobile :

Re: [Dev] Please review and merge PR carbon-storage-management#2

On Thu, Jul 3, 2014 at 12:33 AM, Prabath Abeysekera wrote: > Hi Mohan, > Hi Prabath, > > Only now I managed to fix this. Apologies for the delay! Let me know if > you encounter any other issue further to this. > Thanks, Issue is fixed now.. Regards, Mohan > > Cheers, > Prabath > > > On Thu,

Re: [Dev] Please review and merge PR carbon-storage-management#2

Hi Mohan, Only now I managed to fix this. Apologies for the delay! Let me know if you encounter any other issue further to this. Cheers, Prabath On Thu, Jul 3, 2014 at 12:31 AM, Mohanadarshan Vivekanandalingam < mo...@wso2.com> wrote: > Thanks Prabath.. It seems changes are merged to the repo

Re: [Dev] Please review and merge PR carbon-storage-management#2

Thanks Prabath.. It seems changes are merged to the repo now... Regards, Mohan On Wed, Jul 2, 2014 at 7:22 PM, Mohanadarshan Vivekanandalingam < mo...@wso2.com> wrote: > Hi Prabath & Dhanuka, > > Above changes are not merged to carbon-storage-management of wso2 repo > yet... Can you guys pleas

Re: [Dev] Please review and merge PR carbon-storage-management#2

Hi Prabath & Dhanuka, Above changes are not merged to carbon-storage-management of wso2 repo yet... Can you guys please merge those.. Thanks, Mohan On Mon, Jun 30, 2014 at 2:23 PM, Mohanadarshan Vivekanandalingam < mo...@wso2.com> wrote: > Hi Prabath, > > I have re checked the changes that yo

Re: [Dev] Please review and merge PR carbon-storage-management#2

Hi Prabath, I have re checked the changes that you have done in a clean repo. It seems working fine.. Sorry for the noise.. By the way can you merge these changes to wso2 repo as well (send a pull request), then we can get proper snapshot component. Thanks, Mohan On Thu, Jun 26, 2014 at 8:03

Re: [Dev] Please review and merge PR carbon-storage-management#2

Yeah sure. Lemme check and get back to you. Cheers, Prabath On Thu, Jun 26, 2014 at 8:03 PM, Mohanadarshan Vivekanandalingam < mo...@wso2.com> wrote: > Hi Prabath, > > Sorry, we are still encountering the same issue. It seems issue is not > fixed (I have checkout the carbon-storage-management r

Re: [Dev] Please review and merge PR carbon-storage-management#2

Hi Prabath, Sorry, we are still encountering the same issue. It seems issue is not fixed (I have checkout the carbon-storage-management repo and built it).. Is it possible to look into this when you got some time.. Thanks, Mohan On Wed, Jun 25, 2014 at 10:59 AM, Mohanadarshan Vivekanandalingam

Re: [Dev] Please review and merge PR carbon-storage-management#2

Thanks a lot Prabath.. Regards, Mohan On Wed, Jun 25, 2014 at 8:51 AM, Prabath Abeysekera wrote: > Hi Mohan, > > This is done. Please check and verify. > > Cheers, > Prabath > > > On Tue, Jun 24, 2014 at 12:05 PM, Mohanadarshan Vivekanandalingam < > mo...@wso2.com> wrote: > >> Hi Prabath, >>

Re: [Dev] Please review and merge PR carbon-storage-management#2

Thanks Prabath! On 25 June 2014 08:51, Prabath Abeysekera wrote: > Hi Mohan, > > This is done. Please check and verify. > > Cheers, > Prabath > > > On Tue, Jun 24, 2014 at 12:05 PM, Mohanadarshan Vivekanandalingam < > mo...@wso2.com> wrote: > >> Hi Prabath, >> >> Are there any issues in merging

Re: [Dev] Please review and merge PR carbon-storage-management#2

Hi Mohan, This is done. Please check and verify. Cheers, Prabath On Tue, Jun 24, 2014 at 12:05 PM, Mohanadarshan Vivekanandalingam < mo...@wso2.com> wrote: > Hi Prabath, > > Are there any issues in merging these changes.. It is one of a blocker to > build a proper pack from github.. > Apprecia

Re: [Dev] Please review and merge PR carbon-storage-management#2

Hi Prabath, Are there any issues in merging these changes.. It is one of a blocker to build a proper pack from github.. Appreciate for a quick response.. Thanks, Mohan On Fri, Jun 6, 2014 at 8:17 AM, Prabath Abeysekera wrote: > Hi Lasantha, > > Will do. > > Cheers, > Prabath > > > On Thu, J

Re: [Dev] Please review and merge PR carbon-storage-management#2

Hi Lasantha, Will do. Cheers, Prabath On Thu, Jun 5, 2014 at 10:46 PM, Lasantha Fernando wrote: > Hi, > > Can you please review and merge pull request in [1]? > > [1] https://github.com/wso2-dev/carbon-storage-management/pull/2 > > Thanks, > Lasantha > > -- > *Lasantha Fernando* > Software En