Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1742
ah, sorry for missing this earlier. I didn't realize this is dev/test_* -
these are test scripts that do not have automated tests
---
If your project is set up for it, you can reply to this
Hi Trevor.
Your notebooks look very interesting for me. Especially about data sharing
between different interpreters. I think it might be helpful for people who
starts working with Zeppelin.
But it seems to me that we should better add them with different pull requests
linked to different
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1735
LGTM ð
Merge if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user lresende opened a pull request:
https://github.com/apache/zeppelin/pull/1757
[ZEPPELIN-1074] Enhance SSL Support
### What is this PR for?
- Run SLL on the defined SSL port
- If Client Authentication is not enabled does not use it's properties
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1736
Regarding `Link this paragraph `shortcut key, I just created this issue.
(#1736)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz Thanks for the quick reply.
1. I will post CI logs :)
2. I'v just created an issue for the livy intergration test failure:
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/1756
[ZEPPELIN-1804] Added "Link this paragraph" to keyboard shortcut
### What is this PR for?
Each paragraph menu, it has "Link this paragraph" function which is link
each of the paragraph but
Hoon Park created ZEPPELIN-1806:
---
Summary: CI build fails on
LivyInterpreterIT.testSparkSQLInterpreter
Key: ZEPPELIN-1806
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1806
Project: Zeppelin
Ahyoung Ryu created ZEPPELIN-1805:
-
Summary: Can't check CSS change immediately on zeppelin-web dev
mode
Key: ZEPPELIN-1805
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1805
Project: Zeppelin
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1716
@bzz Sure!
I will That.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1730
@tae-jun Nice feature indeed!
Most of cases are working like a charm.
But as @marchpig said above,
Spark 1.5 had another troubles \w `DepInterpreterTest`
```
16/12/13
Hi,
Thanks for explaining it. It was used to support old one and new one. Not
all interpreter are initialized by interpreter-setting.json thus we should
keep both of them. After we move to new mechanism fully, we need to talk to
modify those structures.
Regards,
Jongyoul Lee
On Wed, Dec 14,
Hi JL,
I think Igor means the property name appears twice in the
interpreter-setting.son
E.g. In the following setting, zeppelin.livy.url appears twice.
"zeppelin.livy.url": {
"envName": "ZEPPELIN_LIVY_HOST_URL",
"propertyName": "zeppelin.livy.url",
"defaultValue":
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1736
@soralee Regarding `ParagraphActionsIT.java` change, IMO it would be better
to be handled by another PR so that we can only focus on the scope of this
patch. There are already many issues
Hi,
Zeppelin supports two way to pass the configuration to interpreter.
propertyName is one of these way to do. I don't know what you talk about
exactly but interpreter's properties map is initialized by set of
propertyNames in interpreter-setting. If you remove propertyName, those key
are not
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1736
[ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut
### What is this PR for?
Currently, keyboard shortcuts can be only seen by keyboard icon.
It'll be very comfortable if
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1736
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1742
@felixcheung The script 'test_zeppelin_pr.py' could be run on only Python 2
before this PR.
Anyway, I made additional modifications to run in python 3 as well.
And the script
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1740
LGTM. CI failure looks irrelevant.
Merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1730
Thanks @Leemoonsoo ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1735
CI is green now. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1754
LGTM and merge to master if there're no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1746
@bitchelov Thanks for the contribution.
Do you mind update description of the PR?
PR description will be part of commit message when merged. So we expect
some meaningful description for
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1737
@zjffdu Thanks!
LGTM and merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1752
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1752
LGTM.
Merge it as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1733
Tested and LGTM.
Merge to master if there're no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1729
@zjffdu why not. i will wait.
thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1730
@tae-jun thanks for the great contribution!
LGTM and merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1675
LGTM and merge to master if there're no further discussions.
@khalidhuseynov Great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1722
LGTM and merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Ruslan Dautkhanov created ZEPPELIN-1803:
---
Summary: CSV export doesn't conform to RFC-4180: exported csv is
broken in some cases
Key: ZEPPELIN-1803
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1803
Github user ravwojdyla commented on the issue:
https://github.com/apache/zeppelin/pull/1754
@felixcheung thanks for the review - tests fail, but I doubt it's due to
this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Kavin Kumar created ZEPPELIN-1802:
-
Summary: Helium app output is not shown for paragraph in the
homescreen for notebook
Key: ZEPPELIN-1802
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1802
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1741
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1736
[ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut
### What is this PR for?
Currently, keyboard shortcuts can be only seen by keyboard icon.
It'll be very comfortable if
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1736
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1750
Great but the concerns are with dependencies on Flash with this approach
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user ravwojdyla opened a pull request:
https://github.com/apache/zeppelin/pull/1755
[ZEPPELIN-1801] To force end table - append %text
### What is this PR for?
It seems there is a bug in scio introduced by recent changes. Table
rendered from scio helper methods would
Rafal Wojdyla created ZEPPELIN-1801:
---
Summary: Scio interpreter's table should only include table's data
Key: ZEPPELIN-1801
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1801
Project: Zeppelin
GitHub user ravwojdyla opened a pull request:
https://github.com/apache/zeppelin/pull/1754
[ZEPPELIN-1800] Update scio doc - fix type $ should be %
### What is this PR for?
Update scio doc - fix type $ should be %
### What type of PR is it?
Documentation
Rafal Wojdyla created ZEPPELIN-1800:
---
Summary: Fix scio documentation
Key: ZEPPELIN-1800
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1800
Project: Zeppelin
Issue Type: Bug
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1744
Merge to master if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1753
[ZEPPELIN-1594] Supported personalized mode
### What is this PR for?
Enabling "Personalized Mode" for specific note
### What type of PR is it?
[Feature]
### Todos
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1753
@cloverhearts @1ambda Can you guys help me to implement some frontend side?
@Leemoonsoo Review this please. If I've missed something, let me know.
---
If your project is set up for it, you can
Hey Alex and Hyung,
Thanks so much for getting back to me so quickly! I'm glad you also
think this would be a good feature. I agree 200% Alex about this becoming
more robust as part of the workflow. I had envisioned--ultimately--there
may be some generalized metadata feature for all
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1747
Overall, the code changes LGTM.
As for the PR, I would recommend :
1. Add [MINOR] to the title, as this is going to be the commit title
2. Respond the "What is this pr for"
@Hoon Thanks for your information :-) I should use that next time!
2016년 12월 13일 (화) 오후 8:23, Park Hoon <1am...@gmail.com>님이 작성:
> I totally agree with your opinions. I will work on ZEPPELIN-1739,
> ZEPPELIN-1749 first i reported before.
>
> @Jun Kim. So true. We have to wait long time. FYI, we
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1752
LGTM!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Lemon312 created ZEPPELIN-1799:
--
Summary: NoSuchMethodException displayed after clicking "Run"
button serveral times.
Key: ZEPPELIN-1799
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1799
Project:
Hello,
I'm doing task https://issues.apache.org/jira/browse/ZEPPELIN-922 (introducing
new interpreter registration mechanism for Scalding) and I have a question
about interpreter-setting.json.
Why do we need "propertyName"? It always has the same value as a key in
properties map (or null). I
Github user PetroKostyuk commented on the issue:
https://github.com/apache/zeppelin/pull/1748
---
If your project is set up for it, you can
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1735
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1735
[ZEPPELIN-1767] Blank paragraph should not be run.
### What is this PR for?
This PR fixes not to run blank paragraph.
### What type of PR is it?
Improvement
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1744
Thank you @Leemoonsoo and @bzz help to review.
CI failure is not irrelevant to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/1752
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/1752
[HOT FIX] Fix broken display_formula.png by using relative path
### What is this PR for?
Currently `display_formula.png` (added by #1606) is broken in here:
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1566
I agree with @khalidhuseynov's opinion.
I was keep wondering it's possible impersonation on `shared` or `scoped`
mode.
My PR is just created for the testing and only tested on 'yarn'
Github user bitchelov commented on the issue:
https://github.com/apache/zeppelin/pull/1747
@lresende Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1566
That's correct, impersonation for spark interpreter can only be applied to
isolated mode. It is due to capability of spark.
---
If your project is set up for it, you can reply to this email and
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1566
So I've done some research and `--proxy-user` argument is used with either
`spark-submit` or `spark-shell` normally, and each of them creates new spark
context. The problem is that
Github user vinayshukla commented on the issue:
https://github.com/apache/zeppelin/pull/765
@corneadoug Can you please provide any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1729
@purechoc I am refactoring LivyHelper in #1751, could you wait and rebase
this PR after #1751 is merged ? Thanks
---
If your project is set up for it, you can reply to this email and have your
I totally agree with your opinions. I will work on ZEPPELIN-1739,
ZEPPELIN-1749 first i reported before.
@Jun Kim. So true. We have to wait long time. FYI, we can use our own
travis CI containers to test (I recently learned also!) by configuring
your-github-id/zeppelin-repo in travis CI
Thanks!
I definitely agree with you!
I reopened my PR twice recently to pass CI and it wasn't because of me.
CI takes about ~40min for a test, so I had to wait 1h and 20min to write a
comment after passing CI T_T
And the worst of it is that I don't believe CI's result more and more.
2016년 12월 13일 (화)
Hi Folks,
As you may notice that our travis CI is not stable recently. There's many
flaky test, and it waste every developer's time to figure out whether the
failure is due to your PR or flaky test. So I think it is time for us to
make the CI stable. Here's tickets for all the flaky test.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1750
@felixcheung
I just tested this patch only in dev mode(`npm run start`). But after I
checked at `localhost:8080` and found
```
404
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz Sorry for confusing. Let me explain more details.
- without `-Ploose-checkstyle`, maven will print all WARNINGs. So people
will see these warnings while developing (**default**)
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Looks great to me, thank you @1ambda @mfelgamal
Let's wait for CI results and merge to master, if nothing comes up and
there is no further discussion!
---
If your project is set up for it,
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Iâm a bit confused though - this PR seems not to have separate checkstyle
CI profile, right?
Didnât we want to have `CHECKSTLYLE=1 â¦` profile for all projects, and
then skip
Haruhiro Yoshimoto created ZEPPELIN-1798:
Summary: Example in document of Flink not working
Key: ZEPPELIN-1798
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1798
Project: Zeppelin
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@1ambda that sounds awesome job, thank you very much. Now the PR is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1734
Guys, if I may, I would suggest keep the discussion in PR focused on the
subject of the PR and move general topics of project's CI stability to the
public dev@ mailing list and appropriate JIRA
Alexander Bezzubov created ZEPPELIN-1797:
Summary: CI build fails on DependencyResolverTest.testLoad \w
spark-csv
Key: ZEPPELIN-1797
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1797
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
I'm sorry for a confusion - as soon as this issue is not about CI, but
about `Update checkstyle rule file, plugin`.
Let's move the CI discussion to the dev@ mailing list so all people in the
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1752
[HOT FIX] Fix broken display_formula.png by using relative path
### What is this PR for?
Currently `display_formula.png` (added by #1606) is broken in here:
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
\cc @zjffdu regarding to the `spark-csv` dependency issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Interesting, that is the first time I see it! AFAIK `spark-csv` has been
included in Spark since 2.0
The failing profile is Spark 1.6 with **Scala 2.11**, but it fails on
fetching
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1734
Thanks @1ambda. Seems it much better! Let me test again.
So true. Currently the CI test result makes us more confused and really
hard to find what the problem is :(
---
If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1734
Totally agree with @zjffdu's opinion. [Here are unresolved flaky
tests](https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20flaky%20ORDER%20BY%20status%20ASC)
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1734
I also notice this failed test in travis. I think there're several jiras
tracking the flaky test. The flaky test waste every developer's time. I think
we should spend some time to fix them. What
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1734
- Selenium tests passed by fixing
https://github.com/apache/zeppelin/pull/1734/commits/c377cf8f255fa714d4b65061daf5239e86e8f641
- The profile 3 (scala 2.10, spark 1.6.3) failed but irrelevant
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1751
LIVY-1786. Refactor LivyHelper
### What is this PR for?
This PR continue the work of livy refactoring. Here's the main changes in
this PR
* Move the code from `LivyHelper` to
Github user PetroKostyuk commented on the issue:
https://github.com/apache/zeppelin/pull/1748
I tought it wold be enought to give it same icon as is used for clearing
output in other places. Also, there is tooltip 'clear notes output' on that
button, as I have seen in other places
94 matches
Mail list logo
