[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun It's great feature! So, I would like to suggest one thing. Currently, the filter function in Zeppelin homepage doesn't work as expected and this issue is handled in

[GitHub] zeppelin pull request #1790: [ZEPPELIN-1845] InterpreterFactory.createOrGetI...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1784: [ZEPPELIN-1840] Allow fully qualified username ...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1784 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1805 Tested `console.log` in dev and dist. It now works as expected. LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-27 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 @khalidhuseynov Thanks for reply! > yeah that's good point, do you have something in mind regarding it? i was thinking whether it should be more of a mode switch (say different mode added

[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...

2016-12-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Sorry, I've missed your review @Leemoonsoo If your note has only one paragraph and you checked that menu of paragraph, it normally works like your screenshot. Because that paragraph doesn't

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-27 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1805 @Leemoonsoo ### Remove `console.log` in dist I missed it. Previously, grunt stripped all `console.log` using this config ``` uglify: { ...

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-27 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1775 @Leemoonsoo thanks for testing, right i could reproduce it. So in that case probably it shouldn't be allowed to change graph properties or pivot settings while viewing revisions, right?

[GitHub] zeppelin pull request #1694: [ZEPPELIN-1718] Prevent anonymous user to set n...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1694 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1773: [DOCS] Add doc about zeppelin.notebook.public

2016-12-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1773 Looks good! Thanks @zjffdu Merge into master if there are no more comments on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...

2016-12-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1767 @vinayshukla I think what @Leemoonsoo suggested was having only one documentation about this info. And IMO having detailed information to describe about "Authentication in Zeppelin", but

[GitHub] zeppelin pull request #1801: ZEPPELIN-1844 Apache Ignite dependency upgrade ...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1798: ZEPPELIN-1853. Add README for livy interpreter

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1798 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1792: Change gitignore for font files

2016-12-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1792 Merge into master if there are no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun Thanks for your great work! Merge if there are no more discussions :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2016-12-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1804 @AhyoungRyu I updated customHome.html and fixed your problem. Could you check again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Created] (ZEPPELIN-1865) zeppelin-web build fails behind proxy

2016-12-27 Thread Nathaniel Meyer (JIRA)
Nathaniel Meyer created ZEPPELIN-1865: - Summary: zeppelin-web build fails behind proxy Key: ZEPPELIN-1865 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1865 Project: Zeppelin Issue

[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...

2016-12-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1736 Tested again. And still not every items are displayed ![image](https://cloud.githubusercontent.com/assets/1540981/21507749/f6406426-cc2f-11e6-920d-79c9279061bd.png) @soralee

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1805 @1ambda Great improvement! Tested and it works well. One thing is, previously console.log() was printed only in dev mode. After this change, console.log() is printed both dev and

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1775 Tested this branch and found 1. select HEAD 2. and then switch to any revision. 3. change height of graph or change pivot setting 4. HEAD is changed by 3)

[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...

2016-12-27 Thread vinayshukla
Github user vinayshukla commented on the issue: https://github.com/apache/zeppelin/pull/1767 @Leemoonsoo The CI failure is unrelated, the 2 files changed are template and markdown. Is there a way to re-trigger the CI? --- If your project is set up for it, you can reply to this

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-27 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for?

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-27 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1730 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #1800: [ZEPPELIN-1855] cleanup temporary test folders ...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1800 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1802: [MINOR] fix: Validate before setting focus to p...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1802 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (ZEPPELIN-1864) Improvement to show folder and note after searching note

2016-12-27 Thread Sora Lee (JIRA)
Sora Lee created ZEPPELIN-1864: -- Summary: Improvement to show folder and note after searching note Key: ZEPPELIN-1864 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1864 Project: Zeppelin

[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...

2016-12-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 @Leemoonsoo I fixed the problem regarding not aligned text. Could you test and check again, please? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...

2016-12-27 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...

2016-12-27 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1736 [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut ### What is this PR for? Currently, keyboard shortcuts can be only seen by keyboard icon. It'll be very comfortable if

[GitHub] zeppelin pull request #1806: [HOTFIX] [ZEPPELIN-1863] Travis Selenium CI fai...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1806: [HOTFIX] [ZEPPELIN-1863] Travis Selenium CI fail

2016-12-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1806 @soralee CI is green now. Thanks for the quick fix! Merge into master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1807: ZEPPELIN-1861 Support custom interpreter.sh script to ...

2016-12-27 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1807 I have tested md for this new way but I didn't add that code because I didn't think it's good to add that example. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin pull request #1807: ZEPPELIN-1861 Support custom interpreter.sh scr...

2016-12-27 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1807 ZEPPELIN-1861 Support custom interpreter.sh script to run interpreter ### What is this PR for? Supporting custom interpreter.sh for an individual interpreter. Some interpreters doesn't need

[GitHub] zeppelin pull request #1806: [ZEPPELIN-1863] Travis Selenium CI fail

2016-12-27 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1806 [ZEPPELIN-1863] Travis Selenium CI fail ### What is this PR for? Currently, the Selenium CI test of Travis regarding every PR is failing. I think because it is after merging #1777 PR.