[GitHub] zeppelin pull request #1988: [ZEPPELIN-2080] Fix null column parse issue in ...

2017-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1988 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2034 Yeah, that seems a valid scenario. And looks like currently there's no document for these behavior, I think we need to add doc for it as well. --- If your project is set up for it, you can reply

[GitHub] zeppelin pull request #2022: [ZEPPELIN-2120] Flaky Test: NotebookTest.testRu...

2017-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #2030: [ZEPPELIN-2123] [WEBSITE] Add setting up travis...

2017-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2030 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1982 @1ambda oh i see :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 @Leemoonsoo cause I added config before to test :( https://github.com/1ambda/zeppelin-echo-spell/blob/master/package.json#L13-#L18 --- If your project is set up for it, you can reply to t

[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1982 > The published echo spell doesn't have repeat implementation since spell config feature is not merged. I'm little bit confused. Then how does spell page displays configuration if pub

[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 @Leemoonsoo Thanks for review. - Then we need to close the configuration panel after saving. I will update it. - You have to use echo spell provided by zeppelin (`examples/`). Published

[GitHub] zeppelin issue #1826: [ZEPPELIN-1859] Add MongoNotebookRepo

2017-02-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1826 @tae-jun Thanks for the great contribution! LGTM and merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] zeppelin issue #2016: [ZEPPELIN-2105] yarn installed by frontend-maven-plugi...

2017-02-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2016 @prabhjyotsingh - tested and it works well. - I'v changed implementation of this PR according to your suggestion. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #2013: [ZEPPELIN-2091] Disable add/remove operations in the w...

2017-02-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2013 Tested and LGTM. CI failure is not related. merge to master and branch-0.7 if no more discussions. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #2031: [MINOR] Improve travis_check.py script

2017-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2031 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2034 Sure I see your point. Just one more case that I wanted to discuss; say in an enterprise world where not all users are allowed to access settings page, or let me put it this way there is a

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2034 I think we don't need to differentiate Global/Per Note/Per User and/Per User + Impersonate. It should just close current session. And let `RemoteInterpreterProcess` to determinate whether to shut d

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2034 Before even implemeting a solution I thought to discuss as to what I think the behaviour should be. \| Global | per note| per

[GitHub] zeppelin issue #2029: [ZEPPELIN-2123] [DOC] Link contribution guide

2017-02-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2029 Merge to master if no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when switch...

2017-02-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2035 Merge to master and branch-0.7 if no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] zeppelin issue #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when switch...

2017-02-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2035 Thanks @cloverhearts for the fix. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] zeppelin issue #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when switch...

2017-02-18 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2035 @jongyoul @Leemoonsoo Could you review on this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] zeppelin pull request #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when...

2017-02-18 Thread cloverhearts
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/2035 [ZEPPELIN-2049 : z0.7.1] Note name is gone when switch to personal mode ### What is this PR for? Note name is gone when switch to personal mode There was a part of the note name that

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2034 @cloverhearts I see your point, let me try to improvise, also I'm open for suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] zeppelin issue #1276: Add Highcharts support

2017-02-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1276 fyi, now zeppelin-0.7.0 enables pluggable visualization. 0.8.0 (snapshot) even supports online registry for the package. http://zeppelin.apache.org/helium_packages.html There're some h

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2034 Agree with @cloverhearts, first we need to identify what's wrong in the current logic for the long term solution. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-18 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2034 > Leemoonsoo 3 hours ago Member I think void close(String sessionId) supposed not necessarily terminate process while an interpreter process can have multiple sessions. I als

[GitHub] zeppelin issue #2025: ZEPPELIN-2108. Livy interpreter job cancellation throw...

2017-02-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2025 @felixcheung Please help to commit to branch-0.7 as well, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2021: [ZEPPELIN-2116]. livy interpreter needs to restart aft...

2017-02-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2021 @prabhjyotsingh @felixcheung Thanks for review, the comments are addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your