[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-18 Thread GitBox
zjffdu commented on code in PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#discussion_r852616747 ## zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java: ## @@ -56,6 +56,8 @@ public static void main(String[] args)

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-18 Thread GitBox
zjffdu commented on code in PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#discussion_r852615303 ## zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java: ## @@ -56,6 +56,8 @@ public static void main(String[] args)

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-18 Thread GitBox
zjffdu commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852612929 ## jdbc/src/main/resources/interpreter-setting.json: ## @@ -143,6 +143,13 @@ "defaultValue": "1000", "description": "Query interval for hive

[GitHub] [zeppelin] huage1994 opened a new pull request, #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-18 Thread GitBox
huage1994 opened a new pull request, #4362: URL: https://github.com/apache/zeppelin/pull/4362 ### What is this PR for? Currently there's a cancelParagraph method in zeppelin client api, however, there's no cancelNote method. PR is to add a cancelNote method in zeppelin client api.

[jira] [Created] (ZEPPELIN-5728) Absence of cancelNote method in Zeppelin Client Api

2022-04-18 Thread Eric Gao (Jira)
Eric Gao created ZEPPELIN-5728: -- Summary: Absence of cancelNote method in Zeppelin Client Api Key: ZEPPELIN-5728 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5728 Project: Zeppelin Issue

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-18 Thread GitBox
huage1994 commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852553473 ## jdbc/src/main/resources/interpreter-setting.json: ## @@ -143,6 +143,13 @@ "defaultValue": "1000", "description": "Query interval for hive

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-18 Thread GitBox
zjffdu commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852185434 ## jdbc/src/main/resources/interpreter-setting.json: ## @@ -143,6 +143,13 @@ "defaultValue": "1000", "description": "Query interval for hive

[GitHub] [zeppelin] jongyoul merged pull request #4350: Bump hadoop-common from 2.3.0 to 3.2.3 in /beam

2022-04-18 Thread GitBox
jongyoul merged PR #4350: URL: https://github.com/apache/zeppelin/pull/4350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4350: Bump hadoop-common from 2.3.0 to 3.2.3 in /beam

2022-04-18 Thread GitBox
jongyoul commented on PR #4350: URL: https://github.com/apache/zeppelin/pull/4350#issuecomment-1101320146 Will merge it to keep history -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] jongyoul merged pull request #4357: MINOR Update asf.yaml to link with JIRA

2022-04-18 Thread GitBox
jongyoul merged PR #4357: URL: https://github.com/apache/zeppelin/pull/4357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: GitHub Merging

2022-04-18 Thread Jongyoul Lee
> BTW, we also need to update the jira ticket if using github merge Ah ... I should keep it in mind. :-) 2022년 4월 7일 (목) 오후 4:15, Philipp Dallig 님이 작성: > Thanks, I will try this out. > > Am 07.04.22 um 04:28 schrieb Jeff Zhang: > > Jongyoul's right, I think both approaches work. BTW, we also

[GitHub] [zeppelin] jongyoul commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph

2022-04-18 Thread GitBox
jongyoul commented on PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101312803 Will merge it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] jasmine-song commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph

2022-04-18 Thread GitBox
jasmine-song commented on PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101291221 > Is t his PR related to a new UI only? yes, just zeppline-web-angular -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zeppelin] jongyoul commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph

2022-04-18 Thread GitBox
jongyoul commented on PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101283047 Is t his PR related to a new UI only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4308: [Zeppelin-5655] OSSNotebookRepo support version control.

2022-04-18 Thread GitBox
huage1994 commented on code in PR #4308: URL: https://github.com/apache/zeppelin/pull/4308#discussion_r851999215 ## zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepo.java: ## @@ -17,43 +17,33 @@ package

[GitHub] [zeppelin] jasmine-song opened a new pull request, #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph

2022-04-18 Thread GitBox
jasmine-song opened a new pull request, #4361: URL: https://github.com/apache/zeppelin/pull/4361 ### What is this PR for? When use the SQL statement in paragraph, some keywords are not highlighted The reason is new web ui code bug(zeppeline-web-angular), front-end send the