huage1994 commented on PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#issuecomment-1088415263
Hi @Reamer and @zjffdu .
Your reviews is so valuable to me. 👍 👍
And I have corrected my code.
--
This is an automated message from the Apache Git Service.
To respond to t
huage1994 commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842507608
##
zeppelin-plugins/notebookrepo/oss/src/test/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepoTest.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Sof
zjffdu commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842483596
##
zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/storage/OSSOperator.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Softwa
zjffdu commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842482006
##
zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepo.java:
##
@@ -63,144 +53,130 @@ public void init(ZeppelinConfiguratio
dependabot[bot] opened a new pull request, #4342:
URL: https://github.com/apache/zeppelin/pull/4342
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.10.8
to 2.12.6.1.
Commits
See full diff in https://github.com/FasterXML/jackson/commits";>compare view
dependabot[bot] opened a new pull request, #4340:
URL: https://github.com/apache/zeppelin/pull/4340
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.5.1
to 2.12.6.1.
Commits
See full diff in https://github.com/FasterXML/jackson/commits";>compare view
dependabot[bot] opened a new pull request, #4341:
URL: https://github.com/apache/zeppelin/pull/4341
Bumps jackson-databind from 2.10.5.1 to 2.12.6.1.
[, the second screenshot is the logs after this PR.
The reason I updat
zjffdu commented on pull request #4307:
URL: https://github.com/apache/zeppelin/pull/4307#issuecomment-1083990147
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
zjffdu commented on pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#issuecomment-1083989410
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Reamer commented on a change in pull request #4336:
URL: https://github.com/apache/zeppelin/pull/4336#discussion_r838684505
##
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ConfInterpreter.java
##
@@ -67,6 +67,9 @@ public InterpreterResult interpret
jongyoul merged pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
jongyoul merged pull request #4334:
URL: https://github.com/apache/zeppelin/pull/4334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
jongyoul merged pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
Reamer opened a new pull request #4337:
URL: https://github.com/apache/zeppelin/pull/4337
### What is this PR for?
This PR corrects the code so that the Home Note feature works again.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* https://issues.a
pjfanning closed pull request #4327:
URL: https://github.com/apache/zeppelin/pull/4327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubsc
zjffdu opened a new pull request #4336:
URL: https://github.com/apache/zeppelin/pull/4336
### What is this PR for?
Trim the space for the key & value of ConfInterpreter. Unit test is added.
### What type of PR is it?
[Bug Fix ]
### Todos
* [ ] - Task
### Wha
asfgit closed pull request #4322:
URL: https://github.com/apache/zeppelin/pull/4322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
zjffdu commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1082639622
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zjffdu commented on pull request #4334:
URL: https://github.com/apache/zeppelin/pull/4334#issuecomment-1082514458
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zjffdu commented on pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#issuecomment-1082514236
> LGTM but I have an opinion. First of all, I'm not an expert on Flink so
you can freely tell me where I might misunderstand it. I saw the
`Flink113SqlInterpreter` and felt lik
zjffdu commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r837454291
##
File path: flink/flink1.12-shims/pom.xml
##
@@ -176,7 +176,7 @@
-unchecked
-deprecation
pjfanning commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081733597
@zjffdu looks like the rerun passed - so it does look like bouncycastle has
no effect
--
This is an automated message from the Apache Git Service.
To respond to the messag
zjffdu closed pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
zjffdu commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081654998
@pjfanning shiro depends on bouncycastle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pjfanning edited a comment on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081652246
@zjffdu you already reverted the bouncycastle upgrade in
https://github.com/apache/zeppelin/commit/49b2e59625f54e29d787e94c8483980a90952014
but it appears that for wh
pjfanning commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081652246
@zjffdu you already reverted the bouncycastle upgrade in
https://github.com/apache/zeppelin/commit/49b2e59625f54e29d787e94c8483980a90952014
but it appears that for when upgr
zjffdu commented on a change in pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#discussion_r837269684
##
File path:
flink/flink-scala-parent/src/main/scala/org/apache/zeppelin/flink/internal/FlinkILoop.scala
##
@@ -101,9 +104,12 @@ class FlinkILoop(
pr
zjffdu commented on a change in pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#discussion_r837265091
##
File path: docs/interpreter/flink.md
##
@@ -285,7 +285,11 @@ You can also add and set other Flink properties which are
not listed in the tabl
tru
zjffdu commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081644568
Thanks @pjfanning , I think it is better to separate them in different PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
zjffdu opened a new pull request #4335:
URL: https://github.com/apache/zeppelin/pull/4335
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/contri
pjfanning commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081055303
@jongyoul @zjffdu I ran this change with bouncycastle also updated to 1.68
(again) on my fork and the spark 3.7 tests pass there -
https://github.com/pjfanning/zeppelin/runs
pjfanning commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081008218
not sure - it may that there is an issue with the shiro upgrade affecting
the spark 3.7 test (but not spark 3.8 test)
--
This is an automated message from the Apache Git S
pjfanning opened a new pull request #4334:
URL: https://github.com/apache/zeppelin/pull/4334
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/con
pjfanning opened a new pull request #4333:
URL: https://github.com/apache/zeppelin/pull/4333
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/con
jongyoul merged pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836553204
##
File path: flink/flink1.14-shims/pom.xml
##
@@ -171,7 +171,7 @@
-unchecked
-deprecation
jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836553028
##
File path: flink/flink1.13-shims/pom.xml
##
@@ -178,7 +178,7 @@
-unchecked
-deprecation
jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836552806
##
File path: flink/flink1.12-shims/pom.xml
##
@@ -176,7 +176,7 @@
-unchecked
-deprecation
jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836541197
##
File path: flink/flink1.14-shims/pom.xml
##
@@ -171,7 +171,7 @@
-unchecked
-deprecation
jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836540877
##
File path: flink/flink1.13-shims/pom.xml
##
@@ -178,7 +178,7 @@
-unchecked
-deprecation
jongyoul commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r836540738
##
File path: flink/flink1.12-shims/pom.xml
##
@@ -176,7 +176,7 @@
-unchecked
-deprecation
jongyoul commented on a change in pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#discussion_r836538790
##
File path: docs/interpreter/flink.md
##
@@ -285,7 +285,11 @@ You can also add and set other Flink properties which are
not listed in the tabl
t
jongyoul commented on a change in pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#discussion_r836538458
##
File path:
flink/flink-scala-parent/src/main/scala/org/apache/zeppelin/flink/internal/FlinkILoop.scala
##
@@ -101,9 +104,12 @@ class FlinkILoop(
jongyoul commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1080770838
The failed CI is unrelated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jongyoul merged pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
asfgit closed pull request #4330:
URL: https://github.com/apache/zeppelin/pull/4330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
zjffdu commented on pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329#issuecomment-1080293818
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zjffdu commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1080292871
@pjfanning Could you do rebase do solve the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
asfgit closed pull request #4325:
URL: https://github.com/apache/zeppelin/pull/4325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
aib628 commented on a change in pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#discussion_r836122058
##
File path:
flink/flink-scala-parent/src/main/scala/org/apache/zeppelin/flink/internal/FlinkILoop.scala
##
@@ -101,9 +104,12 @@ class FlinkILoop(
pr
asfgit closed pull request #4260:
URL: https://github.com/apache/zeppelin/pull/4260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
aib628 commented on a change in pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#discussion_r836119078
##
File path: docs/interpreter/flink.md
##
@@ -285,7 +285,11 @@ You can also add and set other Flink properties which are
not listed in the tabl
tru
zjffdu commented on pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#issuecomment-1080282092
CI is passed, will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1080250649
That's right @jongyoul Now, CI is passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zjffdu commented on pull request #4322:
URL: https://github.com/apache/zeppelin/pull/4322#issuecomment-1080250287
CI is passed, will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1079624581
The error above might be related to #4331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
jongyoul commented on pull request #4331:
URL: https://github.com/apache/zeppelin/pull/4331#issuecomment-1079001184
Nope. I didn't find any trouble but I just would like to confirm which one
we are using it. Thank you for clarifying it.
--
This is an automated message from the Apache Gi
zjffdu opened a new pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332
### What is this PR for?
This PR is to support statement set with the same syntax of flink sql-client:
```
begin statement set;
...
end
```
as an alternative of `runAsOne`
asfgit closed pull request #4331:
URL: https://github.com/apache/zeppelin/pull/4331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
zjffdu merged pull request #4282:
URL: https://github.com/apache/zeppelin/pull/4282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
zjffdu commented on pull request #4331:
URL: https://github.com/apache/zeppelin/pull/4331#issuecomment-1078829103
I think both approaches work, do you notice any problems? @jongyoul
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
jongyoul edited a comment on pull request #4331:
URL: https://github.com/apache/zeppelin/pull/4331#issuecomment-1078800706
BTW, for merging it, we are still using our script instead of using `Squash
and merge`? I saw some are merged directly from Github and some are merged by
asfgit which
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078787851
BTW, I've checked the CI but the error is ...
```
ImportError: cannot import name 'Markup' from 'jinja2'
(/usr/share/miniconda/envs/python_3_with_R/lib/python3.7/site-pa
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078730387
@zjffdu Thank you for the clarification. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zjffdu opened a new pull request #4331:
URL: https://github.com/apache/zeppelin/pull/4331
### What is this PR for?
Specify the jinjia2 version explicitly so that we won't get the error
described in the jira.
### What type of PR is it?
[Bug Fix ]
### Todos
* [
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078712290
@jongyoul I mean the downloading in this maven pom.xml
(https://github.com/apache/zeppelin/blob/master/spark/interpreter/pom.xml#L355),
it is only for unit test. It won't incre
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078628304
@zjffdu Yes, correct. Agreed. Then, does the download work only for testing?
I just wonder if it's possible to reduce our whole binary or not. If it can,
we'd better consider
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078627564
I don't think so, we should enable user to run unit test locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
zjffdu commented on pull request #4330:
URL: https://github.com/apache/zeppelin/pull/4330#issuecomment-1078623054
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078619948
> @jongyoul After looking at the code, I realise that downloading pyspark
and sparkr can not be removed, they are required for unit test.
I have an idea about it. In my
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078617276
@jongyoul After looking at the code, I realise that downloading `pyspark`
and `sparkr` can not be removed, they are required for unit test.
--
This is an automated message
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078610324
Good point @jongyoul let me update that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078589520
LGTM especially, it will help us to reduce whole build time as well.
By the way, if we forgive embedded mode, can we remove downloading python
and R as well? We will re
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078416337
@zjffdu agreed. In an early stage, it was needed for expanding our community
by providing easiest way to use Zeppelin itself but thing's are changed. BTW,
we also need to cha
pjfanning opened a new pull request #4330:
URL: https://github.com/apache/zeppelin/pull/4330
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/con
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1077685049
@jongyoul That's right, actually the embedded spark only works in limited
functions, a lot of spark features are not available for this embedded spark.
Instead, this embedded s
jongyoul commented on a change in pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329#discussion_r834236216
##
File path: scalding/pom.xml
##
@@ -47,6 +47,8 @@
Concurrent Maven Repo
https://conjars.org/repo
+
+
Review comment:
O
pjfanning commented on a change in pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329#discussion_r834235219
##
File path: scalding/pom.xml
##
@@ -47,6 +47,8 @@
Concurrent Maven Repo
https://conjars.org/repo
+
+
Review comment:
jongyoul commented on a change in pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329#discussion_r834233403
##
File path: scalding/pom.xml
##
@@ -47,6 +47,8 @@
Concurrent Maven Repo
https://conjars.org/repo
+
+
Review comment:
I
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1077553706
I'm just curious that this means we need to download spark manually if we
would like to use Spark Interpreter?
--
This is an automated message from the Apache Git Service.
zjffdu commented on pull request #4316:
URL: https://github.com/apache/zeppelin/pull/4316#issuecomment-1077350568
@pjfanning This PR cause CI fail, I need to revert it first.
https://github.com/apache/zeppelin/actions/runs/2014897624
--
This is an automated message from the Apache Git Se
pjfanning commented on pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329#issuecomment-1076402109
Build affected by https://github.com/twitter/hadoop-lzo/issues/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pjfanning opened a new pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/con
zjffdu opened a new pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328
### What is this PR for?
Add one configuration `flink.scala_shell.tmp_dir` for configuring the tmp
folder for flink scala shell compiled jars.
### What type of PR is it?
[Feature]
zjffdu commented on pull request #4282:
URL: https://github.com/apache/zeppelin/pull/4282#issuecomment-1076230408
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zjffdu merged pull request #4319:
URL: https://github.com/apache/zeppelin/pull/4319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
1101 - 1200 of 3026 matches
Mail list logo
