Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2136
@soralee No worries. Thanks for the review.
Merge to master and branch-0.7 if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2137
[ZEPPELIN-2260] Skip node,npm install and bundle when no helium package is
selected
### What is this PR for?
Zeppelin 0.7.0 installs node and npm when it first starts for Helium
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2103
Now CI became green.
Merge to branch-0.7 as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2133
> You mean, do you think it would be better to show min and max values
ââwithout rotate and hide?
Sounds good! Let's look at the opinions of others and change min and max
in
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2138
[ZEPPELIN-2260] [branch-0.7] Skip node,npm install and bundle when no
helium package is selected
### What is this PR for?
Apply #2137 to `branch-0.7`
Zeppelin 0.7.0 installs
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2095
@FRosner fyi. Made a patch https://github.com/apache/zeppelin/pull/2137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2137
[ZEPPELIN-2260] Skip node,npm install and bundle when no helium package is
selected
### What is this PR for?
Zeppelin 0.7.0 installs node and npm when it first starts for Helium
package
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2136
[ZEPPELIN-2113] Paragraph border is not highlighted when focused
### What is this PR for?
https://github.com/apache/zeppelin/pull/2054 [removes `paragraph-col` css
class](https
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Jenkins build script didn't handle well when source branch name of
pullrequest is `master`.
I just updated the jenkins build script to handle the name `master`.
@dlukyanov Coul
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2100
@AhyoungRyu Sounds good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2068
Could you try rebase or merge master to this PR, so this PR branch includes
update on `travis_check.py` that #2094 made?
---
If your project is set up for it, you can reply to this email and
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2132
Tested and LGTM.
Merge to master and branch-0.7 if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2117
LGTM and merge to master and branch-0.7, if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2122
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2128
LGTM and merge to master and branch-0.7 if no more comment
Thanks @sravan-s for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2120
@FRosner Yes, that would be appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2120
@FRosner Jenkins checks `https://travis-ci.org/FRosner/zeppelin` instead of
`https://travis-ci.org/FRosner/incubator-zeppelin` fyi.
---
If your project is set up for it, you can reply to this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2114
#2110 is merged to master. @1ambda is this PR ready for `branch-0.7`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2111
Merge to master if no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2110
Merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2110
Tested and LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2109
LGTM and merge to master if no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2095
How about make Zeppelin skip install npm and node.js when no
visualization/spell is enabled?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2110
Tested and it fixes the problem.
However, since the change #2092, visualization is re-created everytime when
switching. I'd suggest find a way restore `ng-show` and address pr
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2111
Thanks @Remilito for the improvement. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2037
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s Can i know your JIRA ID? So i can resolve ZEPPELIN-2172 with
your name in assignee.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2039
Code change Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2095
Thanks @NohSeho. ZEPPELIN-2094 is marked as resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2103
[WIP] Fix CI build failure on branch-0.7
### What is this PR for?
CI build is failing on `branch-0.7`. This PR cherry-pick some necessary
commits from
https://github.com/apache
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2042
Sounds like a plan!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2042
Master branch is still being built by ASF's travis account and it's failing
after this PR merged.
![image](https://cloud.githubusercontent.com/assets/1540981/23637927/dfb
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2100
@AhyoungRyu Tested and it works well.
To me, label "Auto Run" is bit hard to guess that it is related with
dynamic form. Can you suggest another label which helps u
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2037
Looks great. zeppelin-web has build error. Can you take care of it and make
CI green?
```
[INFO] $ grunt pre-webpack-dist && webpack && grunt post-webpack-dist
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2095
@NohSeho And please let me know your apache JIRA id, so i can resolve
https://issues.apache.org/jira/browse/ZEPPELIN-2094 with your name in assignee.
---
If your project is set up for it, you
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2095
This PR is just merged to branch-0.7 but @asfgit does not close this PR
automatically. @NohSeho Can you manually close this PR?
---
If your project is set up for it, you can reply to this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s You can create or leave comment to JIRA issue. Or you can always
email dev@zeppelin.apache.org
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2095
LGTM and merge to branch-0.7 if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s Thanks, that would be helpful!
LGTM and merge to master and branch-0.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2096
@masyan
Do you mind open PR or JIRA issue and discuss there for more generic way of
run code before/after open/close ? I think it can be little complicated to
discuss here.
---
If
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2078
@felixcheung I think we can merge this one first. A way we're discuss in
#2096 may replace the this PR we don't have the implementation yet.
---
If your project is set up for i
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2096
@masyan Make sense!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2080
@astroshim This PR has been
[merged](https://github.com/apache/zeppelin/commit/f9630a58a86a4a456a8024c0bae73525634aa22c).
Somehow it's not closed by @asfgit. Could you manually close th
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Thanks @andreaTP for the contribution.
I left some comment. Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s To make Zeppelin's Jenkins check your travis-ci build status
correctly, you'll need to turn on 'Build pushes' switch from
https://travis-ci.org/sravan
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2094
Merge to master and branch-0.7 if no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2096
Thanks @tinkoff-dwh for the contribution.
I've seen #2078.
If `precode` is going to be added to all interpreter, how about create some
facility that runs code when initi
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2071
Thanks. Merge to master if no more comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2060
Merge to master if no further discussions.
@NohSeho I'd like to merge this improvement to `branch-0.7` as well, so it
can be included in `0.7.1` release. However, in `branc
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2045
@soralee I merged this PR to `branch-0.7`. But somehow this PR can not be
closed by `asfgit`. Can you close this PR manually?
---
If your project is set up for it, you can reply to this email
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2094
[ZEPPELIN-2162] [ZEPPELIN-2142] Make travis_check.py work with fork under
organization, and show guidance if travis is not configured
### What is this PR for?
When contributor uses
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2094
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2082
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2068
I've made a patch #2094 to make jenkins check repository under
organization. Once #2094 is merged, then Jenkins will able to check this PR
build status correctly.
---
If your project i
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2094
[ZEPPELIN-2162] [ZEPPELIN-2142] Make travis_check.py work with fork under
organization, and show guidance if travis is not configured
### What is this PR for?
When contributor uses
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2060
Thanks @NohSeho for the improvement.
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2071
@1ambda Can you rebase and see if CI becomes green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2045
Tested and LGTM.
Merge to branch-0.7 if no more comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Okay, LGTM.
Merge master and branch-0.7 if no further discussion.
Regarding documentation, if LdapGroupRealm and LdapRealm are
superset/subset relation, we can mark one deprecated
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2082
Merge to branch-0.7 if no further comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
@weand So far, we have a section for LdapRealm in
[shiroauthentication.md](https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#ldap
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2084
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2082
@jongyoul Okay, i cherry-picked related commits instead of making new
commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2070
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2082
[ZEPPELIN-2123] [branch-0.7] backport travis_check.py to branch-0.7
### What is this PR for?
ZEPPELIN-2123 introduces travis_check.py to scale out CI capacity.
However travis_check.py
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2081
[ZEPPELIN-2155] [HOTFIX] Flaky test: NotebookTest
### What is this PR for?
This PR fixes test failure described in ZEPPELIN-2155.
All the PR test fails with this problem at the
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2081
Test passed https://travis-ci.org/Leemoonsoo/zeppelin/builds/206156551
PR build status is yellow, because ASF Jenkins is unusually busy today.
Considering Jenkins job queue length
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2081
[ZEPPELIN-2155] [HOTFIX] Flaky test: NotebookTest
### What is this PR for?
This PR fixes test failure described in ZEPPELIN-2155.
All the PR test fails with this problem at the moment
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/zeppelin/commit/300f7532342d1ea47b85d3b777a8797a3e2248d4#commitcomment-21096395
In
zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationFactory.java:
In
zeppelin-zengine/src
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/zeppelin/commit/300f7532342d1ea47b85d3b777a8797a3e2248d4#commitcomment-21095869
In
zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationFactory.java:
In
zeppelin-zengine/src
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1582
Right!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1982
LGTM and merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2079
Thanks for the improvement.
Do you think this change worth to be mentioned in the [upgrade.md](
https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md#upgrading
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1582
Sorry for late response.
Sounds like a plan!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2072
Great. How does it work in report mode?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2000
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2060
Thanks for the contribution.
Please take a look 'Continuous Integration" section
http://zeppelin.apache.org/contribution/contributions.html#continuous-integration
.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1982
Shell we also remove `"version": "local"` from
zeppelin-examples/zeppelin-example-spell-echo/zeppelin-example-spell-echo.json
zeppelin-examples/zeppelin-exa
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Thanks @weand for improvmenet.
Have you turn on "Build Pushes" in travis-ci settings?
?
---
If your project is set up for it
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2052
CI failure doesn't look related, but to make sure, could you try restart
failed job https://travis-ci.org/astroshim/zeppelin/jobs/203861608 again?
Once failed job becomes green
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2041
The change LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2041
Yes, Jenkins couldn't run 'travis_check.py' because of this PR is based on
folk before 'travis_check.py' exists.
---
If your project is set up for it, you can rep
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2044
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2044
test ci
### What is this PR for?
test ci. this pr won't be merged.
### What type of PR is it?
test
You can merge this pull request into a Git repository by ru
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2036
@felixcheung added a comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2037
Thanks @AhyoungRyu for the great contribution.
> I put "NPM Packages" & "Maven Artifacts" button at top-right corner of
Helium menu.
My guess is,
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1582
Some build fail looks like oriented from flaky test.
Recently, a lot of flaky test has been fixed and i think it's better take
advantage of those fix by merge master to this b
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2036
[ZEPPELIN-2135]
### What is this PR for?
jdbc/src/main/java/org/apache/zeppelin/jdbc/SqlCompleter.java is taken from
SQLLine 1.0.2 (BSD license) and we can't relicen
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2019
Thanks @sotnich for the contribution.
Just a question, will `completer.initFromConnection(jdbcConnection, "%");`
behavior identical to `completer.initFromConnection(jdbc
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2016
CI failure is not related (fixed by #2033).
LGTM and merge to master and branch-0.7 if no further discussions
---
If your project is set up for it, you can reply to this email and have
601 - 700 of 1674 matches
Mail list logo
