Github user Leemoonsoo commented on the pull request:

    
https://github.com/apache/zeppelin/commit/300f7532342d1ea47b85d3b777a8797a3e2248d4#commitcomment-21096395
  
    In 
zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationFactory.java:
    In 
zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationFactory.java
 on line 94:
    Two related issues i'm aware of. If you think you need, please feel free to 
create.
    https://issues.apache.org/jira/browse/ZEPPELIN-2152
    https://issues.apache.org/jira/browse/ZEPPELIN-2094
    
    If `$http_proxy` and `$https_proxy` very common, i think it make sense use 
them instead of make one like `$ZEPPELIN_HTTP_PROXY`. 
    
    And there's one more feature that needs proxy support. Which is dependency 
loader. 
    https://issues.apache.org/jira/browse/ZEPPELIN-169
    Once we decide the variable name, then dependency loader can use the same 
variable to configure proxy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to