GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1912
[HOTFIX][ZEPPELIN-1980] - Test and update CI for matplotlib 2.0.0
### What is this PR for?
Matplotlib 2.0.0 was just released. It has introduced some major changes
including some to the
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1877
I am on vacation right now so I can't thoroughly examine this, but have you
confirmed that this isn't a problem for the pyspark interpreter?
---
If your project is set up for it, you
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1768
Thanks for the update! I probably should have done this when I made the
original PR.
Anyways, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1741
[HOTFIX][ZEPPELIN-1779]Flaky test: PySparkInterpreterMatplotlibTest
### What is this PR for?
The matplotlib tests have stalled as a result of conda downloading version
2.0.0b1. While this was
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1658
@Leemoonsoo FYI, #1632 added another set of tests. The interpreter result
format for these should be changed as well.
---
If your project is set up for it, you can reply to this email and have
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1658
Very nice @Leemoonsoo ð
I have tested this with the matplotlib tutorial notebook just to see if
[ZEPPELIN-1638](https://issues.apache.org/jira/browse/ZEPPELIN-1638) is also
resolved
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
@felixcheung @bzz
The final remaining travis error is unrelated, it seems to be occurring
with other recent PRs (https://travis-ci.org/apache/zeppelin/builds/179341529).
Perhaps we
GitHub user agoodm reopened a pull request:
https://github.com/apache/zeppelin/pull/1632
[ZEPPELIN-1639] Add tests with external python dependencies to CI build
### What is this PR for?
Take 2 of #1618 because I had some earlier problems with rebasing. Since,
then I have added
Github user agoodm closed the pull request at:
https://github.com/apache/zeppelin/pull/1632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
@felixcheung so I looked at the travis log more carefully, and I am pretty
sure the main thing I was missing was an additional "-Pscala-2.11" to the maven
build profile. Hopefully it wi
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
Oh for the love of... looks like I will need to update the cache again. Let
me run this one more time.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
Correct, the main reason being that caching it actually increases the build
time. I still have one slight nitpick myself, but I'll leave that up to others
if that is worth pursuing right now
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
To be honest, I don't see it being that big of a deal. Both profiles take
about 5 minutes each which I think is fairly short, since up until recently we
were spending 4 minutes just installin
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
@felixcheung @bzz
So the pyspark cluster test has two failures. One is a result of matplotlib
always printing a warning message when it is first loaded, and the other is how
python 3
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
I think the CI failures were due to me somehow inadvertently removing the
-Ppyspark from the build profile. Let's see how it goes now.
---
If your project is set up for it, you can reply to
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
@bzz done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
@felixcheung so I have tested caching the miniconda directory and found
that it actually slows down the build by 1-2 minutes on average. From what I
can tell the other big python projects are not
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1645
From what I can tell, the main intent of this PR is to support switching
between environments on the fly, which is in of itself a very useful feature.
Will this also support creating new
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
Thank you for the review @felixcheung , see my responses. Although this is
beyond the scope of the original intent of the PR, I have added the R
dependencies to the cache, which could potentially
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
ping @bzz @felixcheung @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1632
[ZEPPELIN-1639] Add tests with external python dependencies to CI build
### What is this PR for?
Take 2 of #1618 because I had some earlier problems with rebasing. Since,
then I have added
Github user agoodm closed the pull request at:
https://github.com/apache/zeppelin/pull/1618
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1628
[HOTFIX][ZEPPELIN-1656] z.show in Python interpreter does not work
### What is this PR for?
There have been reports of #1534 causing the python interpreter to always
show an error because `z
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1628
@bzz please test ASAP!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1626
Here you go @bzz !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1626
[ZEPPELIN-1655] Dynamic forms in Python interpreter do not work
### What is this PR for?
After #1534 , Dynamic Forms were no longer working in the python
interpreter. This is because the
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1618
This CI failure is not unrelated, it also happened on my fork. I have a
hunch that changing the path might have something to do with it, which would be
odd since I regularly use Zeppelin with
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1618
Add tests with external python dependencies to CI build
### What is this PR for?
Many of our python tests are excluded from the main build profile and
hence, the CI builds as well because
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
There is a JIRA issue:
([ZEPPELIN-1623](https://issues.apache.org/jira/browse/ZEPPELIN-1623))
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@felixcheung done, I have tested with the tutorial notebook and it seems to
work as well as before. Good to merge now?
---
If your project is set up for it, you can reply to this email and have
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@Leemoonsoo Tests are done, the only failure seems to be from a known flaky
test [ZEPPELIN-1623](https://issues.apache.org/jira/browse/ZEPPELIN-1623). Are
we good to merge?
---
If your project
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1596
@zjffdu Please see the most recent comments @Leemoonsoo and I made in
#1534. With the vanilla python interpreter, I can indeed confirm that the call
to `open()` is being made at the right time
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@Leemoonsoo Yep, I can confirm... right before you posted that comment, I
patched Never mind, I manually patched in the changes from that PR to my branch
and got the exact same stacktrace as you
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@Leemoonsoo Sure, I will do that after this is merged.
As for your error, I cannot reproduce it. I tested both the latest code
from master as well as my fork after rebasing. How are you
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1596
Well to be precise, the other reason I made the call to `open()` was to
make sure the hook registry was in effect before the first call to
`interpret()` from within `jobRun()`, and therefore, the
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1596
@Leemoonsoo @zjffdu I placed the extra call to `open()` in `jobRun` because
I wanted to have a convenient place to make calls to `registerHook()`. We can't
do this in the `Interpreter` constr
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@felixcheung
In that case, I think that should be fine. Will do shortly.
@Leemoonsoo
The latest commit should fix the issue I just mentioned. Two other
important things to
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@felixcheung
I updated the documentation and also added the example gif shown in this
PR. In regards to getting python dependencies installed for our CI tests, I
would be glad to help with
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@felixcheung The main idea is that the output is set to HTML if
`angular=False` (default). If `angular=True`, the figure data gets bound to the
angular display system by figure id and the output
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@Leemoonsoo Try it now, I think it should work. The main thing I changed
was printing the last image as HTML instead of ANGULAR (for the purpose of
saving the image in the notebook). I also
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
@Leemoonsoo
Yep, I also had trouble starting Zeppelin. I can run it on my main
development directory, but couldn't when I cloned the current master branch to
an empty directory and patch
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1534
Ok, that should do it for now. @Leemoonsoo @bzz @felixcheung please feel
free to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1534
[WIP]ZEPPELIN-1345 - Create a custom matplotlib backend that natively
supports inline plotting in a python interpreter cell
### What is this PR for?
This PR is the first of two major steps
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1470
@Leemoonsoo I have addressed your second comment, let me know if this looks
good to merge into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1470
@Leemoonsoo Thanks for the review, I have provided some responses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1470
@Leemoonsoo please review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1470
ZEPPELIN-1423 - Allow users to specify pre/post-execute hooks for
interpreters
### What is this PR for?
See #1439. This is a second attempt based on prior feedback, particularly
from
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1439
Going to close this for now since I have made another implementation on a
separate branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user agoodm closed the pull request at:
https://github.com/apache/zeppelin/pull/1439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1439
Thank you very much for the detailed explanation. To be precise, I made the
`cmd` argument that gets registered a String solely because
`Interpreter.interpret()` accepts a String representation of
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1439
@Leemoonsoo Thanks for the feedback.
Indeed I think your first point on the Experimental annotation made sense,
so I have changed it.
As for your second point, I am not really
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1439
@doanduyhai To be precise, I designed the callback registry system with two
different types of use cases. The first one is for the different interpreter
maintainers to implement in their
GitHub user agoodm reopened a pull request:
https://github.com/apache/zeppelin/pull/1439
[ZEPPELIN-1423] Allow users to specify pre/post-execute callbacks for
interpreters
### What is this PR for?
One feature built-in to Jupyter's ipykernel that is currently missi
Github user agoodm closed the pull request at:
https://github.com/apache/zeppelin/pull/1439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1439
@felixcheung Ok, I have changed the default behavior to now automatically
detect the REPL name from the paragraph input text. The Travis CI build isn't
running after I rebased my commi
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1439
@felixcheung Sure thing, I can do that in a bit.
As for the issue of the default value for `replName`, are you simply
referring to the use case for different interpreters, or some variants
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1439
Ok, TODO's are now done. @AhyoungRyu @Leemoonsoo @bzz Please review, I
myself am unsure if some of the errors I am seeing in some of the Travis CI
builds are related to these changes.
-
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1439
[ZEPPELIN-1423] Allow users to specify pre/post-execute callbacks for
interpreters
### What is this PR for?
One feature built-in to Jupyter's ipykernel that is currently missing in
Zep
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1352
@bustios Nice job, this works great now. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1352
@bustios
Nice job on removing the need to perform the python version check
completely. This certainly helps make the code look cleaner.
However I cannot get your changes to work
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1343
@bzz @bustios I tested the changes in a notebook for both python2/3 as well
as ran the unit tests. Hopefully we are good to go this time.
---
If your project is set up for it, you can reply to
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1343
@bustios Thanks for the catch. I agree that the second option you posted
would be a lot cleaner, so I'll go ahead and test it.
---
If your project is set up for it, you can reply to this
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1343
ZEPPELIN-1328 - z.show in python interpreter does not display PNG images in
python 3
### What is this PR for?
Support for plotting PNG images via matplotlib inline for the python
interpreter
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1329
@bzz Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1329
@bzz The way I see it the pros and cons of each format can be summed up as
follows:
### SVG
Pros:
- Vector so image quality will be consistent regardless of resolution
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1329
@felixcheung Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user agoodm opened a pull request:
https://github.com/apache/zeppelin/pull/1329
ZEPPELIN-1318 - Add support for png images in z.show()
### What is this PR for?
This PR adds support for plotting png images using the matplotlib helper
function within a python interpreter
67 matches
Mail list logo
