[GitHub] zeppelin issue #2645: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-12-04 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2645 @yiming187 I have made the changes and updated pull request. You can review now. ---

[GitHub] zeppelin issue #2645: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-06 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2645 @zjffdu Thanks for your comments and review. There seems something wrong with validating pull request. ---

[GitHub] zeppelin issue #2645: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-05 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2645 @zjffdu the CI checks seems to get stuck, even after rebase. ---

[GitHub] zeppelin issue #2645: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-02 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2645 @zjffdu please review. Thanks. ---

[GitHub] zeppelin issue #2645: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-02 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2645 @zjffdu sure, kylin interpreter has unit test class, and I will add the test when result set is empty. ---

[GitHub] zeppelin issue #2645: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-02 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2645 @zjffdu @felixcheung can you please review? I have rebased and created this new pull request. [was https://github.com/apache/zeppelin/pull/2634]. Thanks for your time! ---

[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-01 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2634 @zjffdu sure I will close this PR and have created another PR https://github.com/apache/zeppelin/pull/2645. Please review. ---

[GitHub] zeppelin pull request #2634: [ZEPPELIN-3014] NPE bug fix and Error message e...

2017-11-01 Thread jinxliu
Github user jinxliu closed the pull request at: https://github.com/apache/zeppelin/pull/2634 ---

[GitHub] zeppelin pull request #2645: ZEPPELIN-3014: NPE bug fix and Error message en...

2017-11-01 Thread jinxliu
GitHub user jinxliu opened a pull request: https://github.com/apache/zeppelin/pull/2645 ZEPPELIN-3014: NPE bug fix and Error message enhancement with Kylin I… …nterpreter ### What is this PR for? A few sentences describing the overall goals of the pull request&#

[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-01 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2634 @felixcheung it still does not work. ---

[GitHub] zeppelin pull request #2634: [ZEPPELIN-3014] NPE bug fix and Error message e...

2017-11-01 Thread jinxliu
GitHub user jinxliu reopened a pull request: https://github.com/apache/zeppelin/pull/2634 [ZEPPELIN-3014] NPE bug fix and Error message enhancement with Kylin Interpreter ### What is this PR for? A few sentences describing the overall goals of the pull request's co

[GitHub] zeppelin pull request #2634: [ZEPPELIN-3014] NPE bug fix and Error message e...

2017-11-01 Thread jinxliu
Github user jinxliu closed the pull request at: https://github.com/apache/zeppelin/pull/2634 ---

[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-01 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2634 I have tried several times since yesterday, hope this time it works. ---

[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...

2017-11-01 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2634 @felixcheung is there something wrong with travis-ci? ---

[GitHub] zeppelin issue #2634: Kylin intp

2017-10-27 Thread jinxliu
Github user jinxliu commented on the issue: https://github.com/apache/zeppelin/pull/2634 This PR has two commits, https://github.com/apache/zeppelin/pull/2634/commits/ec68d12437611dd6fb817fa058020bb926b7e163 is to enhance the error message parse and display, the second commit is

[GitHub] zeppelin pull request #2634: Kylin intp

2017-10-27 Thread jinxliu
GitHub user jinxliu opened a pull request: https://github.com/apache/zeppelin/pull/2634 Kylin intp ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apach