[GitHub] zeppelin issue #2696: [ZEPPELIN-3091] Correct aggregation functionality in c...

2017-12-11 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2696 @Leemoonsoo Thanks. I have added a test case as you mentioned. Please have a look. ---

[GitHub] zeppelin issue #2696: [ZEPPELIN-3091] Correct aggregation functionality in c...

2017-12-07 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2696 Ping ---

[GitHub] zeppelin pull request #2696: [ZEPPELIN-3091] Correct aggregation functionali...

2017-12-05 Thread namanmishra91
GitHub user namanmishra91 opened a pull request: https://github.com/apache/zeppelin/pull/2696 [ZEPPELIN-3091] Correct aggregation functionality in charts ### What is this PR for? The aggregation functions interpret NaN columns as 1 which leads to incorrect output being shown

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-30 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2619 Closed as PR 2627 addresses the same thing ---

[GitHub] zeppelin pull request #2619: Run all paragraphs sequentially

2017-10-30 Thread namanmishra91
Github user namanmishra91 closed the pull request at: https://github.com/apache/zeppelin/pull/2619 ---

[GitHub] zeppelin issue #2627: [ZEPPELIN-2368]. Option to run all paragraphs *sequent...

2017-10-29 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2627 Apologies for the late comment but at least you agree now that this feature will require frontend changes also. This "UI is frozen" information will also need to be passed to th

[GitHub] zeppelin issue #2627: [ZEPPELIN-2368]. Option to run all paragraphs *sequent...

2017-10-25 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2627 @zjffdu Yes, that's right. ---

[GitHub] zeppelin issue #2627: [ZEPPELIN-2368]. Option to run all paragraphs *sequent...

2017-10-25 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2627 What happens now if after doing run all , a later paragraph that isn't submitted yet is run explicitly? Will it run twice? ---

[GitHub] zeppelin issue #2605: [ZEPPELIN-2963] Fix paragraph aborting on next run aft...

2017-10-13 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2605 Agreed that should be the ideal solution but considering how tightly it is integrated with the core execution workflow, this will be a risky change and needs to be done with utmost care

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-13 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2619 @zjffdu Yeah, I can change the implementation to make `persistAndExecuteSingleParagraph` paragraph blocking. Then we won't need UI side changes for separate event handling etc. However, we

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-11 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2619 @zjffdu Thanks for the feedback. Directly modifying the `persistAndExecuteSingleParagraph` method will lead to the current behaviour getting lost completely. The reason I chose

[GitHub] zeppelin issue #2619: Run all paragraphs sequentially

2017-10-11 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2619 @zjffdu > What we need to do it to run it blocking way. The code does exactly that. It might look complicated overall as a lot of code is related to handling and pass

[GitHub] zeppelin pull request #2619: Run all paragraphs sequentially

2017-10-10 Thread namanmishra91
GitHub user namanmishra91 opened a pull request: https://github.com/apache/zeppelin/pull/2619 Run all paragraphs sequentially ### What is this PR for? This PR introduces "run all" behaviour for a note in a sequential manner. The "Run All paragraphs"

[GitHub] zeppelin issue #2605: [ZEPPELIN-2963] Fix paragraph aborting on next run aft...

2017-10-05 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/2605 Build failures don't seem to be related to changes in this PR (selenium webdriver tests and flaky interpreter tests). Not sure what needs to be done to make them succeed. ---

[GitHub] zeppelin pull request #2605: [ZEPPELIN-2963] Fix paragraph aborting on next ...

2017-10-03 Thread namanmishra91
GitHub user namanmishra91 opened a pull request: https://github.com/apache/zeppelin/pull/2605 [ZEPPELIN-2963] Fix paragraph aborting on next run after cancel ### What is this PR for? As mentioned in ZEPPELIN-2963, if a paragraph is cancelled while it was in scheduler's waiting

[GitHub] zeppelin issue #1968: [ZEPPELIN-1551] Remove the "default" text against inte...

2017-02-07 Thread namanmishra91
Github user namanmishra91 commented on the issue: https://github.com/apache/zeppelin/pull/1968 The test failures don't seem to be related to my change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #1968: [ZEPPELIN-1551] Remove the "default" text again...

2017-02-02 Thread namanmishra91
GitHub user namanmishra91 opened a pull request: https://github.com/apache/zeppelin/pull/1968 [ZEPPELIN-1551] Remove the "default" text against interpreters on interpreters screen as it is providing incorrect semantics ### What is this PR for? This PR