[GitHub] zeppelin pull request #3168: [ZEPPELIN-3753] Fix indent with TAB

2018-08-31 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3168 [ZEPPELIN-3753] Fix indent with TAB ### What is this PR for? Now when you select multiline text and press TAB, text replaces with "\t" char. With this PR text just shift ri

[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...

2018-08-28 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3057 ---

[GitHub] zeppelin pull request #3064: [ZEPPELIN-3596] Saving resources from pool to S...

2018-08-28 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3064 ---

[GitHub] zeppelin pull request #3117: [ZEPPELIN-3691] Scheduled note continues to wor...

2018-08-21 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3117 ---

[GitHub] zeppelin pull request #3117: [ZEPPELIN-3691] Scheduled note continues to wor...

2018-08-21 Thread oxygen311
GitHub user oxygen311 reopened a pull request: https://github.com/apache/zeppelin/pull/3117 [ZEPPELIN-3691] Scheduled note continues to work in the trash ### What is this PR for? Fix bug with scheduled note working in the trash. How to repeat bug: 1. Make scheduled

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-21 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu Sorry, you are right. Fixed ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-20 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu Looks like it's some bug with dependencies in master: `[ERROR] SLF4J: Class path contains multiple SLF4J bindings.` ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-20 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu resolved ---

[GitHub] zeppelin issue #3137: [ZEPPELIN-3709] Add releaseResource parameter to Cron ...

2018-08-17 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3137 @jongyoul Yes ---

[GitHub] zeppelin issue #3137: [ZEPPELIN-3709] Add releaseResource parameter to Cron ...

2018-08-17 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3137 @jongyoul You can find usage in [docs](https://zeppelin.apache.org/docs/0.8.0/usage/other_features/cron_scheduler.html#after-execution-stop-the-interpreter). ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-17 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu [Current Travis build](https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/416851939) ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-16 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu Added ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-15 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu So, I moved this check to `refreshCron()` method ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-15 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @felixcheung I have amended commit for checking is note in trash. ---

[GitHub] zeppelin pull request #3139: [ZEPPELIN-3712] Add `maxConnLifetime` parameter...

2018-08-14 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3139 [ZEPPELIN-3712] Add `maxConnLifetime` parameter to JDBC Interpreter ### What is this PR for? This parameter is necessary in that case: 1) Zeppelin open connection and keep it in pool

[GitHub] zeppelin pull request #3138: [ZEPPELIN-3710] Add to the SAP documentation li...

2018-08-14 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3138 [ZEPPELIN-3710] Add to the SAP documentation limit and distinct description ### What is this PR for? Add to the SAP documentation `limit` and `distinct` keywords description

[GitHub] zeppelin pull request #3137: [ZEPPELIN-3709] Add releaseResource parameter t...

2018-08-14 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3137 [ZEPPELIN-3709] Add releaseResource parameter to Cron REST API ### What is this PR for? Add `releaseResource` parameter to Cron REST API `Post` and `Get` methods. ### What type

[GitHub] zeppelin issue #3115: [ZEPPELIN-3687] Fix IndexError in python interpreter w...

2018-08-13 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3115 @zjffdu @felixcheung Travis tests fixed ---

[GitHub] zeppelin pull request #3115: [ZEPPELIN-3687] Fix IndexError in python interp...

2018-08-13 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3115 ---

[GitHub] zeppelin pull request #3115: [ZEPPELIN-3687] Fix IndexError in python interp...

2018-08-13 Thread oxygen311
GitHub user oxygen311 reopened a pull request: https://github.com/apache/zeppelin/pull/3115 [ZEPPELIN-3687] Fix IndexError in python interpreter with empty input ### What is this PR for? If input of python or pyspark interpreter is empty (contains only comments), it will fail

[GitHub] zeppelin pull request #3117: [ZEPPELIN-3691] Scheduled note continues to wor...

2018-08-08 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3117 [ZEPPELIN-3691] Scheduled note continues to work in the trash ### What is this PR for? Fix bug with scheduled note working in the trash. How to repeat bug: 1. Make scheduled

[GitHub] zeppelin issue #3115: [ZEPPELIN-3687] Fix IndexError in python interpreter w...

2018-08-08 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3115 @zjffdu Done ---

[GitHub] zeppelin pull request #3115: Fix IndexError in python interpreter with empty...

2018-08-07 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3115 Fix IndexError in python interpreter with empty input ### What is this PR for? If input of python or pyspark interpreter is empty (contains only comments), it will fail with `IndexError

[GitHub] zeppelin pull request #3106: [ZEPPELIN-3677] SAP Interpreter improvement

2018-08-01 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3106 [ZEPPELIN-3677] SAP Interpreter improvement ### What is this PR for? Improvements: - An empty result processing, message about no data will be shown; - Dimension's attributes auto

[GitHub] zeppelin pull request #3090: [ZEPPELIN-3645] Add LSP Protocol completion sup...

2018-07-27 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3090 ---

[GitHub] zeppelin issue #3090: [ZEPPELIN-3645] Add LSP Protocol completion support

2018-07-27 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3090 Solution must be improved to use by real users. ---

[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...

2018-07-26 Thread oxygen311
GitHub user oxygen311 reopened a pull request: https://github.com/apache/zeppelin/pull/3093 [ZEPPELIN-3655] Add missing roles information to api/notebook/job/ method ### What is this PR for? Fix bugs with private access interpreter launched with REST by adding missing roles

[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...

2018-07-26 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3093 ---

[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...

2018-07-26 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3093 @zjffdu Also this bug may occur in run paragraph methods, it's also fixed now. Other methods don't miss role info because they don't need to pass it farther. And `checkIfUserCanWrite

[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...

2018-07-26 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3093 @zjffdu done ---

[GitHub] zeppelin issue #3090: [ZEPPELIN-3645] Add LSP Protocol completion support

2018-07-25 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3090 1. LSP is usable and powerful solution: - LSP can understand imports in the start of paragraph; - We can use already made solution for every language and don't write new one; - LSP

[GitHub] zeppelin issue #3090: [ZEPPELIN-3645] Add LSP Protocol completion support

2018-07-25 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3090 @zjffdu If LSP has no complete for `sc.`, iPython complete will be shown. LSP does not support sessions, but it can keep connection. ---

[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...

2018-07-25 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3093 ---

[GitHub] zeppelin pull request #3093: [ZEPPELIN-3655] Add missing roles information t...

2018-07-25 Thread oxygen311
GitHub user oxygen311 reopened a pull request: https://github.com/apache/zeppelin/pull/3093 [ZEPPELIN-3655] Add missing roles information to api/notebook/job/ method ### What is this PR for? Fix bugs with private access interpreter launched with REST by adding missing roles

[GitHub] zeppelin issue #3093: [ZEPPELIN-3655] Add missing roles information to api/n...

2018-07-24 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3093 It's don't easy to check this bug with a unit test. Even in Paragraph is not running because of "user has no permission for interpreter" response in rest api would be "OK" ---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

2018-07-24 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3090 @felixcheung I have added property `zeppelin.python.useLsp` which is disabled by default. It does not seem unsecured for me now. We also can specify host and port by ourselves

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

2018-07-24 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3090 @zjffdu Sorry, correct line is `pip install python-language-server`, i will fix it. ---

[GitHub] zeppelin issue #3090: [Zeppelin-3645] Add LSP Protocol completion support

2018-07-23 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3090 Now this feature is enabled only in python interpreter. So you can specify `zeppelin.python.lspHost` and `zeppelin.python.lspPort` properties and use it. Server is a separate process. I have

[GitHub] zeppelin pull request #3090: [Zeppelin-3645] Add LSP Protocol completion sup...

2018-07-23 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3090 [Zeppelin-3645] Add LSP Protocol completion support ### What is this PR for? Add support of request autocomplete with LSP Protocol through TCP. ### What type of PR

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580] Adds rename note method to rest api

2018-07-19 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3049 @jongyoul Done ---

[GitHub] zeppelin issue #3064: [ZEPPELIN-3596] Saving resources from pool to SQL

2018-07-17 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3064 Scenario: get a list of client IDs from one source (flat file, base, SAP), send the list to the database and perform complex analytics with it. The data in the database is large

[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...

2018-07-17 Thread oxygen311
GitHub user oxygen311 reopened a pull request: https://github.com/apache/zeppelin/pull/3057 [ZEPPELIN-3582] Add type data to result of query from SQL ### What is this PR for? JDBCInterpreter knows type information for every SQL Query. We could save this info to pool and use

[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...

2018-07-17 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3057 ---

[GitHub] zeppelin issue #3064: [ZEPPELIN-3596] Saving resources from pool to SQL

2018-07-17 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3064 @zjffdu The user can transfer data not only from one database to another, but from flat files and interpreters, which are not available in the python (e.g. SAP). Sending data through

[GitHub] zeppelin pull request #3064: [ZEPPELIN-3596] Saving resources from pool to S...

2018-07-12 Thread oxygen311
GitHub user oxygen311 reopened a pull request: https://github.com/apache/zeppelin/pull/3064 [ZEPPELIN-3596] Saving resources from pool to SQL ### What is this PR for? > It's information in resourcePool, but it is only available for viewing. It would be nice if we can s

[GitHub] zeppelin pull request #3064: [ZEPPELIN-3596] Saving resources from pool to S...

2018-07-12 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3064 ---

[GitHub] zeppelin pull request #3057: [ZEPPELIN 3582] Add type data to result of quer...

2018-07-12 Thread oxygen311
Github user oxygen311 closed the pull request at: https://github.com/apache/zeppelin/pull/3057 ---

[GitHub] zeppelin pull request #3057: [ZEPPELIN 3582] Add type data to result of quer...

2018-07-12 Thread oxygen311
GitHub user oxygen311 reopened a pull request: https://github.com/apache/zeppelin/pull/3057 [ZEPPELIN 3582] Add type data to result of query from SQL ### What is this PR for? JDBCInterpreter knows type information for every SQL Query. We could save this info to pool and use

[GitHub] zeppelin issue #3064: [ZEPPELIN-3596] Saving resources from pool to SQL

2018-07-12 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3064 @zjffdu variable interpolation is about just using text variable. But with this feature you can transform `%table` text from ResourcePool to SQL table. ---

[GitHub] zeppelin pull request #3064: [ZEPPELIN-3596] Saving resources from pool to S...

2018-07-11 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3064 [ZEPPELIN-3596] Saving resources from pool to SQL ### What is this PR for? > It's information in resourcePool, but it is only available for viewing. It would be nice if we can s

[GitHub] zeppelin issue #3057: [ZEPPELIN 3582] Add type data to result of query from ...

2018-07-11 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3057 @zjffdu we plan to do it in next pool requests. ---

[GitHub] zeppelin pull request #3049: [ZEPPELIN-3580]

2018-07-03 Thread oxygen311
GitHub user oxygen311 opened a pull request: https://github.com/apache/zeppelin/pull/3049 [ZEPPELIN-3580] ### What is this PR for? Adds rename note method to rest api ### What type of PR is it? Improvement ### What is the Jira issue? issue on Jira