[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2017-01-02 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 I think this can be closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-11-21 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 this have been stale for quite a while, so I'll start looking into it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-09-28 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug I've just tried the scenario you have, and it was running correctly (without np) when you switch to different revisions. the only thing is that it was running the `head` version

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-30 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug thanks for letting me know, i'll look into that and get back to you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-30 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1304 @khalidhuseynov I found out that websocket events at Notebook level are already blocked in the revision (I don't receive anything, and my actions are not affecting the original note).

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-25 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 any ETA on this one, so that can plan accordingly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-16 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug please let us know if there still are any troubles, after #1254 got merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-11 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @bzz exactly, that's the point i was trying to make in #1254. @anthonycorbacho i'm completely agree with you, and that was the original starting premise. I'm happy that everyone go

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-11 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug thank you for explaining! So we are talking about WS API to fetch full notebook state from the history by it's revision? Wich on client-side looks like [websocketMsgSrv.getNoteRev

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-10 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1304 @khalidhuseynov are we really sure about sending `complex object` as a parameter in the URL? How will it be represented? encoded? IMO it is not a good idea, if you ask for a re

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-10 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1304 @bzz The front-end needs to be able to get the Notebook's revision and show it. To do that, there is a websocket event that originally looked like that: `websocketMsgSrv.getNoteRevisi

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-10 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1304 To avoid the confusion, could you guys quickly bring me up to speed with, what `API needs to be fixed to send Revision ID` means in this context? As far as I understood, we are talking in this

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-09 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug thanks for clarification. in this case, how do you think it would look like if `revisionId` cannot be represented as simple string and it's more like complex object? I

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-09 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1304 @khalidhuseynov that doesn't solve anything, I can't work with Revision, it needs to be RevisionId. If you visit a URL like: /notebook/:noteId/revision/:revisionId All you have is t

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-09 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug thanks for taking care of this! #1308 is merged and instead of `RevisionId` just send `Revision`. rebase should solve the problems. --- If your project is set up for it, you ca