Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1333
I tested branch-0.6 after reverting this PR, and I cannot reproduce the
issue.
```
remoteInterpreter.setEnv(env);
```
Above line of code only existed in master branch, and use of v
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1333
Merge it to master and branch-0.6 if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1333
Great work @zjffdu!
Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@Leemoonsoo @bzz I just fix the unit test. The root cause is that
`HeliumApplicationFactoryTest` will also register these interpreters. And all
these unit tests are in the same JVM. So I change `po
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1333
PR rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1333
Very similar test failure as we discussed above happened in un-related
#1363
[here](https://s3.amazonaws.com/archive.travis-ci.org/jobs/155836675/log.txt)
```
Failed tests:
In
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@zjffdu so there must be some state that persists between the runs.
@Leemoonsoo do you have any idea what that state might be that affects
`InterpreterFactoryTest `? There seems to be nothing
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1333
Thanks @bzz, I have fixed the code style issue. Another remaining thing is
that the unit test I added is failed when running it using maven with other
unit test. But it succeeded when I ran it indi
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1333
All 3 CI failing profiles: [Spark
2.0](https://s3.amazonaws.com/archive.travis-ci.org/jobs/153792236/log.txt) and
1.6 are very consistent
[INFO] Zeppelin: Zengine ...
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@zjffdu Looks great to me, modulo minor style issue above, thank you and
:+1: for tests!
One more thing - it's a bit strange ZEPPELIN-1334 has fix-for version ONLY
0.6.2 which implies merging
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@Leemoonsoo I have added unit test, please help review. failed test seems
irrelevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@zjffdu Tested and It looks good to me.
There is an unittest for set environment variable for remote interpreter at
[RemoteInterpreterTest.java](https://github.com/apache/zeppelin/blob/
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@bzz Sure, let me know if I need to create another PR for 0.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@zjffdu thank you for fixing it!
After the review we better merge this to both, _master_ and _branch-0.6_
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1333
Thanks @zjffdu for the fix. Let me take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@Leemoonsoo Please help to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
16 matches
Mail list logo
