Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1539
Tested and LGTM.
Merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
CI is green!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@1ambda Thank you for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@astroshim It is more clear since we already use that notations in the
interpreter tab :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@1ambda I added `placeholder` message for `Entity`. Does it make sense?
---
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@1ambda Thank you for the testing and great suggestion about the `Entity`
name.
Let me fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1539
Build Command: mvn clean package -DskipTests
Build Commit: **bf61afd** fix testcase (2 days ago) [astroshim]
Build & Runtime Java: 1.8.0_102
Tested Backends: Mysql 5.7, MariaDB
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@nathanscully I fixed that you issued. Could you review again?
@Leemoonsoo What `Entity` name did you set? `Entity` should be set as
`jdbc`.`InterpreterName`.
---
If your project is set
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
Thank you @Leemoonsoo and @nathanscully to review.
Let me address issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1539
Tested this branch but somehow i couldn't make it work.
- if i set 'default.user' and 'default.password', i can access the
database.
- Turn on authentication and remove
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
CI is green now. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@astroshim Could you rebase and see if CI becomes green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
rebuild CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@khalidhuseynov Thank you for sharing your good idea about the dropdown
list.
It might gives convenience users.
and I agree with @Leemoonsoo about define convention for `entity` name.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1539
it would be even better to let user chose interpreter from dropdown list of
interpreters in place of `entity` field in credentials menu, what do you think
@Leemoonsoo @astroshim ? Also
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1539
There's also an option of adding that Entity key in interpreter settings
via GUI (say `credetials.key` -> `entity`) and then using that `entity` when
searching through credentials
---
If
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@Leemoonsoo Thank you for review this.
I was curious about the `Entity` name should be same with interpreter's.
Could you tell me your idea?
---
If your project is set up for it, you
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1539
@astroshim Thanks for the contribution.
Proposed jdbc interpreter update looks like searching Entity name, the same
name with interpreter alias. I can think some possible problem
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1539
please review @jongyoul
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
20 matches
Mail list logo
