[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-20 Thread pmccaffrey6
Github user pmccaffrey6 commented on the issue: https://github.com/apache/zeppelin/pull/1776 Hey @bzz, Great catch! Sorry about that. I removed the unnecessary import. The error seems unrelated. It comes from: ``` 1470 21:03:56,259 ERROR org.apache.zeppelin.Abstra

[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-19 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1776 Thank you @pmccaffrey6 , it looks great to me, modulo few things noted above. Could you just double check that all feedback from reviews was addressed? --- If your project is set up for it,

[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-18 Thread pmccaffrey6
Github user pmccaffrey6 commented on the issue: https://github.com/apache/zeppelin/pull/1776 I went ahead and changed parsing of the "explore" keyword to use `split(" +")` instead of substring so that it wasn't tied to any particular word length etc.. and the `METADATA_KEYWORD` can be

[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-16 Thread pmccaffrey6
Github user pmccaffrey6 commented on the issue: https://github.com/apache/zeppelin/pull/1776 The failed test looks to be from `testSparkSQLInterpreter` from `LivyInterpreterIT.java`. More specifically, it comes from line 227 (and 226) in that file: ``` InterpreterResult

[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-16 Thread pmccaffrey6
Github user pmccaffrey6 commented on the issue: https://github.com/apache/zeppelin/pull/1776 Hey guys, Thanks so much for the review! I removed the unused variable (great catch). As for the other issues, I think they make a ton of sense. I wrote the `getMetaData()`

[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-16 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1776 LGTM. Test failure seems unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en