Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
Thanks, @Leemoonsoo for the information.
I am able to run e2e and it is green:
https://user-images.githubusercontent.com/1881135/32818801-70ed2d58-c9eb-11e7-9af6-7fd5f165e12a.png;>
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2568
Right, we don't have good documentation for TEST_SELENIUM, but WEB_E2E you
can find documentation
[here](https://github.com/apache/zeppelin/tree/master/zeppelin-web).
I'm running test
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@Leemoonsoo: I tried running selenium tests mentioned in the contributions
guide, but it didn't help.
https://zeppelin.apache.org/contribution/contributions.html
Could you please
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2568
Tried this branch and looks good.
But CI is failing in most profiles. Error does not look like related to
this change but since this PR made modification on front-end side, I think it's
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@Leemoonsoo I have created new icon font with remove and more icons.
https://user-images.githubusercontent.com/1881135/32284898-b67dd8ce-bf4e-11e7-8811-7b70029c05fb.png;>
At
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2568
> Do you mind if I replace the Simple Line Icon with a separate icon font
with all the thin icons and a few more additions
Sounds good. Thanks for taking care.
---
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@Leemoonsoo Yes, Simple line icon has 'close' icon, but it will not match
with the paragraph controls.
I have looked up the usage of Simple line icons and it seems there are only
18
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2568
Sorry, I missed this comment. Simple line icon has 'close' icon, cross
inside of a circle.
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@Leemoonsoo Unfortunately Simple Line Icons doesn't have the cross icon,
should we use the separate svg for that as well?
---
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@Leemoonsoo : I will fix the spacing issue.
Regarding more icon not visible, it seems we need to add it to the build.
I will change the delete icon to be cross rather than trash.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2568
Thanks @malayhm for great improvement.
Tried this branch and have few feedbacks.
1. looks like it's got more space between buttons. Is it intended? can we
keep the same space
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@1ambda As per this link, we can use it as there is no mention to give
credit to the designer:
http://blog.iconfinder.com/license-agreements-used-iconfinder/
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@Madhuka Happy to see the icon.
I just searched the license but couldn't find the license. It only says
"free for commercial usage". Could you check it can be used even in opensource?
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@1ambda Please see the
https://user-images.githubusercontent.com/1881135/30287842-2e72d740-9744-11e7-8468-f9a86766487b.png;>
new screenshot with the new icon:
---
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@1ambda It seems this icon is available in icon finder with free commercial
use:
https://www.iconfinder.com/icons/476329/continued_detail_details_ellipses_more_icon#size=16
What do
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@malayhm it's nice if we can remove `More` text and there is no license
problem ð
---
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@1ambda This is generally used for hamburger menu in mobile mode.
What do you think about a custom icon like this, this is used on Facebook?
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@malayhm What about this icon?
- http://fontawesome.io/icon/bars/
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@1ambda
> Can we use the thinner icon for remove?
I have changed the remove paragraph icon to trash.
