Re: Trying CTR for the project

2015-11-27 Thread Konstantin Boudnik
See in-lined... On Sat, Nov 28, 2015 at 04:25AM, moon soo Lee wrote: > > > > I don't see how it is possible. Empirically it isn't ever a case as well. > > Could you please elaborate how this might happen in your view? > > > > > Let me share some history about Zeppelin project, > It was developed i

[GitHub] incubator-zeppelin pull request: Fix paragraph actions dropdown st...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/478#issuecomment-160251176 Tested and LGTM. Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-zeppelin pull request: Option to restart interpreter fro...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-160251125 I think providing a button to restart interpreter in the notebook page is good idea. But 'Restart Interpreter' button seem to displayed when parag

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-466][DOCS] fix typos Po...

2015-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Modify style.css for the aestheti...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/477#issuecomment-160250467 LGTM Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/483#issuecomment-160250426 Merge if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] incubator-zeppelin pull request: progressbar is showing on top of ...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/481#issuecomment-160250281 Tested and LGTM. Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-467 Fix ace editor focus...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/482#issuecomment-160249457 Thanks @r-kamath for review. Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-428] [DOCS] [followup] ...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/486#issuecomment-160248292 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-428] [DOCS] [followup] ...

2015-11-27 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/486 [ZEPPELIN-428] [DOCS] [followup] fix formatting for code blocks Fix code block formatting http://zeppelin.incubator.apache.org/docs/0.5.5-incubating/manual/dynamicform.html

Re: Trying CTR for the project

2015-11-27 Thread moon soo Lee
On Sat, Nov 28, 2015 at 10:47 AM Konstantin Boudnik wrote: > On Sat, Nov 28, 2015 at 01:15AM, moon soo Lee wrote: > > Thanks for starting the thread. I was keep an eye on discussion about > > CTR/RTC on the general@incubator. > > > > I saw people think RTC means lack of trust in that discussion.

Re: Trying CTR for the project

2015-11-27 Thread Amos B. Elberg
> I have a PR that has been pending since *August*.  It’s the subject of 2  > jira’s, and I’d emailed members of the PMC about it several times.  It has  Have you emails the dev@ list?  Repeatedly. Actually, it isn't a requirement. Perhaps some one told you this mistakenly,  but it is not. Here's

Re: Trying CTR for the project

2015-11-27 Thread Konstantin Boudnik
On Fri, Nov 27, 2015 at 09:02PM, Amos B. Elberg wrote: > I think CTR may be a good idea.  > > Considering all the excellent efforts to build community by Moon and others, > I can understand why he has experienced the community in the way he > describes.  > > My experience, however, has been diffe

Re: Trying CTR for the project

2015-11-27 Thread Amos B. Elberg
I think CTR may be a good idea.  Considering all the excellent efforts to build community by Moon and others, I can understand why he has experienced the community in the way he describes.  My experience, however, has been different.  I’m not sure that community involvement is either as broad,

[GitHub] incubator-zeppelin pull request: ZEPPELIN-469 Interpreter process ...

2015-11-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/485#issuecomment-160238011 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Trying CTR for the project

2015-11-27 Thread Konstantin Boudnik
On Sat, Nov 28, 2015 at 01:15AM, moon soo Lee wrote: > Thanks for starting the thread. I was keep an eye on discussion about > CTR/RTC on the general@incubator. > > I saw people think RTC means lack of trust in that discussion. To me that > is complete nonsense. I can say, RTC trust others more, t

Re: Trying CTR for the project

2015-11-27 Thread moon soo Lee
Thanks for starting the thread. I was keep an eye on discussion about CTR/RTC on the general@incubator. I saw people think RTC means lack of trust in that discussion. To me that is complete nonsense. I can say, RTC trust others more, trust reviewer. So I don't agree the "reason" CTR over RTC in th

Trying CTR for the project

2015-11-27 Thread Konstantin Boudnik
Guys, as you might have seen on the general@incubator list, there's a lengthy discussion about benefits of Commit-Then-Review (CTR) development model over Review-Then-Commit (RTC) one. As the project is getting more mature, I would like to start the conversation on what the community think about

Re: [DISCUSS]Strict code style and PR guide

2015-11-27 Thread Konstantin Boudnik
Good points! There's another benefit to it: with a common set of coding styles it'd easier to onboard new contributors. And it is easier for reviewers by sticking to the same ground rules. Cos On Fri, Nov 27, 2015 at 10:48AM, Felix Cheung wrote: > +1, +1 also on discussing Coding guideline / Codi

RE: [DISCUSS]Strict code style and PR guide

2015-11-27 Thread Felix Cheung
+1, +1 also on discussing Coding guideline / Coding style on http://flink.apache.org/contribute-code.html - think we should adopt it as applicable to this community. > From: m...@apache.org > Date: Fri, 27 Nov 2015 08:23:53 + > Subject: Re: [DISCUSS]Strict code style and PR guide > To: dev@

[GitHub] incubator-zeppelin pull request: Modify style.css for the aestheti...

2015-11-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/477#issuecomment-160185762 @corneadoug Oh I didn't noticed that. I canceled the last commit ! --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-zeppelin pull request: JDBC generic interpreter

2015-11-27 Thread jiekechoo
Github user jiekechoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160135681 @jongyoul I mean how to use jdbc interpreter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: ZEPPELIN-469 Interpreter process ...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/485#issuecomment-160131146 Ready to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/483#issuecomment-160129427 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] incubator-zeppelin pull request: ZEPPELIN-469 Interpreter process ...

2015-11-27 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/485 ZEPPELIN-469 Interpreter process loads unnecessary classes Addresses issue https://issues.apache.org/jira/browse/ZEPPELIN-469 This PR fixes problem by remove `export ZEPPELIN_

[GitHub] incubator-zeppelin pull request: ZEPPELIN-458 Fix testAbortParagra...

2015-11-27 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/468#issuecomment-160115088 Thanks for the fix, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] incubator-zeppelin pull request: Distribution Management

2015-11-27 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/484 Distribution Management To manage distribution of the artifact and supporting files generated throughout the build process You can merge this pull request into a Git repository b

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-466][DOCS] fix typos Po...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/475#issuecomment-160104186 Merge if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-461] fix typos in geode...

2015-11-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/471#issuecomment-160103988 Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...

2015-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[jira] [Created] (ZEPPELIN-471) Could not find creator property with name ... with embedded spark binaries

2015-11-27 Thread Kevin Tsai (JIRA)
Kevin Tsai created ZEPPELIN-471: --- Summary: Could not find creator property with name ... with embedded spark binaries Key: ZEPPELIN-471 URL: https://issues.apache.org/jira/browse/ZEPPELIN-471 Project: Z

[jira] [Created] (ZEPPELIN-470) NoSuchMethodError: scala.Predef ... with defining SPARK_HOME

2015-11-27 Thread Kevin Tsai (JIRA)
Kevin Tsai created ZEPPELIN-470: --- Summary: NoSuchMethodError: scala.Predef ... with defining SPARK_HOME Key: ZEPPELIN-470 URL: https://issues.apache.org/jira/browse/ZEPPELIN-470 Project: Zeppelin

[GitHub] incubator-zeppelin pull request: Modify style.css for the aestheti...

2015-11-27 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/477#issuecomment-160086482 I fixed the navbar in #462 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-467 Fix ace editor focus...

2015-11-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/482#issuecomment-160082731 :+1: LGTM. works well on Chrome and Firefox --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS

2015-11-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/483#issuecomment-160080960 tested. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Created] (ZEPPELIN-469) Interpreter process loads unnecessary classes

2015-11-27 Thread Lee moon soo (JIRA)
Lee moon soo created ZEPPELIN-469: - Summary: Interpreter process loads unnecessary classes Key: ZEPPELIN-469 URL: https://issues.apache.org/jira/browse/ZEPPELIN-469 Project: Zeppelin Issue Ty

[GitHub] incubator-zeppelin pull request: Modify style.css for the aestheti...

2015-11-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/477#issuecomment-160069073 Originally I want to make some space between img in the documentation. However, as a result, I made a useless space in the mobile like below attached

Re: [DISCUSS]Strict code style and PR guide

2015-11-27 Thread moon soo Lee
So far, we have two related docs. http://zeppelin.incubator.apache.org/docs/latest/development/howtocontribute.html https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md Having a code-contribution guide, such as Flink's one is going to help not only code quality but also gettin

[DISCUSS]Strict code style and PR guide

2015-11-27 Thread Jongyoul Lee
Hi devs, I think It's time to make codes clean and clear. In the former stage of Zeppelin, It's important to add functions to enrich codes but, as time goes, with several codes style, it's hard to maintain code quality. I suggest it's good to follow Flink's way( http://flink.apache.org/contribute-