[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

2016-01-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-177152345 @felixcheung You're right. But I've thought this table is too big to identify at a glance :’-( Then, how about adding a note sentence below( or a

Re: [DISCUSS] Documentation improvement

2016-01-30 Thread 류아영
+ 1 It would be better, if we have a kind of FAQ. Then we can help our user's troubleshooting : ) On Fri, Jan 29, 2016 at 5:36 PM, Hyung Sung Shim wrote: > +1 > > 2016년 1월 29일 금요일, Victor Manuel Garcia님이 작성한 메시지: > > > +1 > > El 29/1/2016 6:53, "DuyHai Doan" > > > escribió: > > > > > +1 > > > >

[GitHub] incubator-zeppelin pull request: Utilities for Angular Display sys...

2016-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/591#issuecomment-177286964 Merge #591 and #650 if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[jira] [Created] (ZEPPELIN-642) Selecting "Run all paragraphs" in a note creates empty paragraph at the end

2016-01-30 Thread Prasad Wagle (JIRA)
Prasad Wagle created ZEPPELIN-642: - Summary: Selecting "Run all paragraphs" in a note creates empty paragraph at the end Key: ZEPPELIN-642 URL: https://issues.apache.org/jira/browse/ZEPPELIN-642 Proje

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-619] Shared Resource po...

2016-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/655#issuecomment-177298867 @doanduyhai Thanks for review and i think i addressed all your comment. Please take a look. Regarding ResourcePool and AngularObjectRegistry, here

[GitHub] incubator-zeppelin pull request: Fix dead link and add table tab t...

2016-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-177299837 Thanks @AhyoungRyu for the improvement. But I also think seeing environment variable and property in one table together is much easier to discover necessa

[GitHub] incubator-zeppelin pull request: [Zeppelin-630] Introduce new way ...

2016-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/673#issuecomment-177300313 LGTM and merge if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-619] Shared Resource po...

2016-01-30 Thread doanduyhai
Github user doanduyhai commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/655#issuecomment-177315262 @Leemoonsoo Thanks for the detailed explanation of differences between AngularObjectRegistry and ResourcePool. I guess that the AngularObjectRegistry is

[GitHub] incubator-zeppelin pull request: [Zeppelin-635] AngularJS utilitie...

2016-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/678#issuecomment-177319760 @doanduyhai Thanks for great work. I have look through this PR and while this PR covers wide range of improvement/new features, i'd suggest split it in

[GitHub] incubator-zeppelin pull request: Update commit merge script

2016-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/674#issuecomment-177320638 Let's merge and try --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-619] Shared Resource po...

2016-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/655#issuecomment-177322651 Thanks @doanduyhai for the review. Merge if there're no more discussions. --- If your project is set up for it, you can reply to this email and have y

[GitHub] incubator-zeppelin pull request: ZEPPELIN-375

2016-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/670#issuecomment-177325630 Adding a new entry under `matrix.include` section in the .travis.yml will run test on JDK8. for example ``` - jdk: "oraclejdk8"

[GitHub] incubator-zeppelin pull request: moved delete button to help prote...

2016-01-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/662 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Update commit merge script

2016-01-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[jira] [Created] (ZEPPELIN-643) Shell interpreter improvements

2016-01-30 Thread Felix Cheung (JIRA)
Felix Cheung created ZEPPELIN-643: - Summary: Shell interpreter improvements Key: ZEPPELIN-643 URL: https://issues.apache.org/jira/browse/ZEPPELIN-643 Project: Zeppelin Issue Type: Bug

Re: Deserialization issue for AngularObject in RemoteInterpreterServer

2016-01-30 Thread moon soo Lee
+1 for adding last step to catch all type and remove String case On Thu, Jan 28, 2016 at 6:26 PM DuyHai Doan wrote: > "I guess if List type of AngularObject is updated from front-end" --> It is > very possible now with my PR #678 > > I suggest that we add a last step to catch all types other tha