Re: [DISCUSS] Back to PRs 208 & 702...

2016-03-27 Thread Amos B. Elberg
Moon - I opened this discussion so it could take place with the community as a whole, not just you. Suffice it to say, I disagree with every one of the technical claims you've just made, and I don't trust your intent. Let the community process happen. > On Mar 28, 2016, at 2:47 AM, moon soo

Re: [DISCUSS] Back to PRs 208 & 702...

2016-03-27 Thread moon soo Lee
Hi, Simply put, - 702 and/or 208 will can merged as they're ready. [1] - 208 will not be merged while it does not pass CI. If you think code in 208 is not a problem but CI itself or other part of Zeppelin is problem, then that particular problem be fixed before merge 208. - 702 has proper integra

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-768] HBase 1.1.x and 1....

2016-03-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/800#issuecomment-202246080 @vrajat @bbuild11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-768] HBase 1.1.x and 1....

2016-03-27 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/800 [ZEPPELIN-768] HBase 1.1.x and 1.2.0 release support documentation ### What is this PR for? When run with HBase 1.1.x or HBase 1.2.0, this error is reported: ``` org.jruby

[jira] [Created] (ZEPPELIN-768) HBase interpreter does not work with HBase 1.1.4 (stable) or HBase 1.2.0

2016-03-27 Thread Felix Cheung (JIRA)
Felix Cheung created ZEPPELIN-768: - Summary: HBase interpreter does not work with HBase 1.1.4 (stable) or HBase 1.2.0 Key: ZEPPELIN-768 URL: https://issues.apache.org/jira/browse/ZEPPELIN-768 Project:

Re: [discuss] PR 789

2016-03-27 Thread moon soo Lee
Hi, Thanks for your feedback about PR-789. It's bit difficult to catch your point but, i tried best to summarize your feedback. 1. PR should have separate gui interface for environment variable configuration. 2. Configurations are placed multiple places. That cause conflict. 3. Order of precedenc

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202223003 @bzz Let me just add, to avoid any doubt --- I hope I'm wrong. If I am, then I'll be most appreciate, and most apologetic for misjudging you. In th

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202220759 @bzz Alex - The two "issues" that you identified on my repo are as follows: 1. Two files are flagged as requiring an Apache license header --- these

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202217468 From what I can see - same three issue I have listed above still hold for this PR from being merged. Updates on my help with CI are tracked under elbamos

[DISCUSS] Back to PRs 208 & 702...

2016-03-27 Thread Amos Elberg
I am saddened to have to start this thread *again*. While I thought we had reached consensus on this, several times over, apparently some people disagree. I hope this will be the last time. With this thread, I am asking the community to reach consensus (1) That 208 should be merged this week, wi

[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]

2016-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202187464 I think -Drscala.version is no longer necessary --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-767] HBase interpreter ...

2016-03-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/799#issuecomment-202187238 @vrajat @bbuild11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-767] HBase interpreter ...

2016-03-27 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/799 [ZEPPELIN-767] HBase interpreter does not work with HBase on a remote cluster ### What is this PR for? HBase interpreter fails with message "ERROR: KeeperErrorCode = ConnectionL

[jira] [Created] (ZEPPELIN-767) HBase interpreter does not work with HBase on a remote cluster

2016-03-27 Thread Felix Cheung (JIRA)
Felix Cheung created ZEPPELIN-767: - Summary: HBase interpreter does not work with HBase on a remote cluster Key: ZEPPELIN-767 URL: https://issues.apache.org/jira/browse/ZEPPELIN-767 Project: Zeppelin

[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]

2016-03-27 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202180743 @Leemoonsoo and @echarles does this still make use of `-Drscala.version=1.0.6` in the build settings? --- If your project is set up for it, you can r

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202180621 after these merged changes, does the build still make use of `-Drscala.version=1.0.6` --- If your project is set up for it, you can reply to this emai

[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]

2016-03-27 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202179470 thank you for the collaboration @Leemoonsoo and @echarles . I will review and test the changes. --- If your project is set up for it, you can reply t

[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202179412 Nothing in what you just said is truthful. If you think what you are attempting to do is anything but the opposite of what the community consensus was in th

[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]

2016-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202179148 > It is not at all a surprise that you would propose to merge 702---a few hours after I asked for community involvement on another PR, where you objected.

[discuss] PR 789

2016-03-27 Thread Amos Elberg
An issue has come up regarding PR 789 that I feel should be a community discussion. The PR takes configuration preferences, and converts them into environment variables, in particular for VMs launched as independent processes. It is not requested functionality and nothing else depends on it. I d

[GitHub] incubator-zeppelin pull request: Fix removing notes without specif...

2016-03-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/798#issuecomment-202171192 Looks good to me. Merging if there is no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202170740 @Leemoonsoo code looks good and rationale for customizing at least JVM properties now and leaving ui for env vars for further improvements makes sense.

[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202170557 It is not at all a surprise that you would propose to merge 702---a few hours after I asked for community involvement on another PR, where you objected.

Re: [GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread Amos B. Elberg
Moon - is there really such an urgency with this PR that it can't wait 12-24 hours for a discussion over whether we should do it before we have an interface to support it? > On Mar 27, 2016, at 7:10 PM, Leemoonsoo wrote: > > Github user Leemoonsoo commented on the pull request: > > > htt

[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]

2016-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202168397 @echarles Thanks for taking a look https://github.com/datalayer/zeppelin-datalayer/pull/7. I have tested latest commit and it works well for me. Also i

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202167530 @elbamos > I've explained the objection to you several times. False. Here's your objection https://github.com/apache/incubator-

[GitHub] incubator-zeppelin pull request: ZEPPELIN-748 make websocket maxTe...

2016-03-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/784#issuecomment-202166680 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-696] Add notification s...

2016-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-202155963 I have tested and working well. Looks good to me. @corneadoug Can you take a look, too? --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202133105 Moon I've explained the objection to you several times. You're choosing to ignore that. I am therefore telling you don't have a consensus and it needs to be

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-696] Add notification s...

2016-03-27 Thread doanduyhai
Github user doanduyhai commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-202130699 @corneadoug @Leemoonsoo Rebased from master, only JS change, can be reviewed and merged quickly. Do you want me to add also a test in Ze

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202128120 Please note that reason must be provided for objection to the code contribution. Unless this PR doesn't have any proper objection comes with reason, i'

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202127132 I'm not sure why it is you don't want to send the email to the list, but fine, I will do so later on. When you decided to submit this to apache the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202126499 @elbamos If you have objection in this PR, not me, but you'll need to explain your **reason** in this pullrequest comment. And i'm repeating that pullrequ

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202116183 Moon - will you be raising this on the mailing list or are you abandoning the issue? --- If your project is set up for it, you can reply to this email and h

[jira] [Created] (ZEPPELIN-766) change checkbox form value can not show result in Real-time

2016-03-27 Thread zijunyang (JIRA)
zijunyang created ZEPPELIN-766: -- Summary: change checkbox form value can not show result in Real-time Key: ZEPPELIN-766 URL: https://issues.apache.org/jira/browse/ZEPPELIN-766 Project: Zeppelin

[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]

2016-03-27 Thread echarles
Github user echarles commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202013345 I have merged datalayer#7. (a) Issues with `spark.home` not being taken into account is fixed. (b) Support of additional viz libs mentioned by @jeffst

[GitHub] incubator-zeppelin pull request: dont return null for bindings

2016-03-27 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/incubator-zeppelin/pull/798 dont return null for bindings ### What is this PR for? This PR fixes incorrect behavior when trying to remove note without saving its interpreter binding settings. ##

[jira] [Created] (ZEPPELIN-765) Fails to proper remove note when interpreter settings are not saved

2016-03-27 Thread Khalid Huseynov (JIRA)
Khalid Huseynov created ZEPPELIN-765: Summary: Fails to proper remove note when interpreter settings are not saved Key: ZEPPELIN-765 URL: https://issues.apache.org/jira/browse/ZEPPELIN-765 Project