[GitHub] incubator-zeppelin pull request: [ZEPPELIN-828] Use individual use...

2016-05-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/860#issuecomment-220488582 @prasadwagle Tried and looks good. I think separate issue can handle address HiveInterpreter changes. If you'd prefer. One thing is, crede

[GitHub] incubator-zeppelin pull request: Fix link to r interpreter doc

2016-05-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/898#issuecomment-220413194 Merging into master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-577] ASCII control char...

2016-05-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/894#issuecomment-220245108 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-848] Add support for en...

2016-05-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/886#issuecomment-220167056 I think there were some problem on "repository.apache.org" and i believe now it is stable. @natesammons-nasdaq Could you try once again re-trigg

[GitHub] incubator-zeppelin pull request: Fix interpreter.sh classpath

2016-05-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/889#issuecomment-220165691 Every jar under interpreter/spark/ supposed to be included in the classpath by [interpreter.sh#67](https://github.com/apache/incubator-zeppelin/blob

[GitHub] incubator-zeppelin pull request: Fix link to r interpreter doc

2016-05-18 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/898 Fix link to r interpreter doc ### What is this PR for? This PR is hot fix for broken link to r interpreter doc ### What type of PR is it? Hot Fix

[GitHub] incubator-zeppelin pull request: ZEPPELIN-773 : Livy interperter

2016-05-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-220086349 @prabhjyotsingh Thanks for the help. Commenting out spark.master from https://github.com/cloudera/livy/conf/spark-blacklist.conf made it work

[GitHub] incubator-zeppelin pull request: ZEPPELIN-773 : Livy interperter

2016-05-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-220023617 @prabhjyotsingh Thanks for explanation. I have tried with https://github.com/cloudera/hue/tree/master/apps/spark/java and LivyInterpreter works greatly

[GitHub] incubator-zeppelin pull request: Fix notebook folder structure nam...

2016-05-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/883#issuecomment-219919689 Merge it into master if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-848] Add support for en...

2016-05-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/886#issuecomment-219908546 While [all build profile failed](https://travis-ci.org/apache/incubator-zeppelin/builds/130849266) for last commit with some network issue, It's

[GitHub] incubator-zeppelin pull request: Revise documentation about basic ...

2016-05-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/877#issuecomment-219736646 Thanks @yoonjs2 for the nice improvement on documentation. LGTM and merge if there're no more discussions! --- If your project is set up for it

[GitHub] incubator-zeppelin pull request: import org.slf4j instead of parqu...

2016-05-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/892#issuecomment-219733633 @prabhjyotsingh Thanks for taking a look. CI failure is unrelated. Merge into master if there're no more discussions --- If your project i

[GitHub] incubator-zeppelin pull request: import org.slf4j instead of parqu...

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/892 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-zeppelin pull request: import org.slf4j instead of parqu...

2016-05-16 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/892 import org.slf4j instead of parquet.org.slf4j ### What is this PR for? Import org.slf4j package instead or parquet.org.slf4j in ZeppelinR.java Related to the error

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-281] Windows build

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/876#issuecomment-219584484 Thanks @fvaleri for the proxy settings on build instruction. LGTM and merge if there're no more discussions --- If your project is set up for it

[GitHub] incubator-zeppelin pull request: Fixing Zeppelin-838: Minor improv...

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/872#issuecomment-219581296 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Fix notebook folder structure nam...

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/883#issuecomment-219578496 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Note Permission: If userName does...

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/884#issuecomment-219578270 Thanks @wind0727 for the bug fix. Are modifications of line 141~163 and 713~729 of NotebookRestApi.java part of this contribution? If not

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-848] Add support for en...

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/886#issuecomment-219575709 @natesammons-nasdaq Thanks for useful improvement. CI fails with error ``` [INFO] There are 1 checkstyle errors. [ERROR

[GitHub] incubator-zeppelin pull request: ZEPPELIN-850 update error message

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/888#issuecomment-219573555 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-773 : Livy interperter

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-219501130 I have build livy and verified it is working with example https://github.com/cloudera/livy#spark-example. When i try this branch, with default

[GitHub] incubator-zeppelin pull request: ZEPPELIN-852 fixed the fields flo...

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/890#issuecomment-219490401 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: import org.slf4j instead of parqu...

2016-05-16 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/892 import org.slf4j instead of parquet.org.slf4j ### What is this PR for? Import org.slf4j package instead or parquet.org.slf4j in ZeppelinR.java Related to the error report

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-853] Fix Last update at...

2016-05-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/891#issuecomment-219435761 Thanks for the fix. Tested and LGTM. Merging it into master as a hotfix. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-zeppelin pull request: Fix interpreter.sh classpath

2016-05-12 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/889 Fix interpreter.sh classpath ### What is this PR for? This PR apply fix #769 again, which is reverted by #208. Also removing unnecessary code from interpreter.sh

[GitHub] incubator-zeppelin pull request: Fix notebook folder structure nam...

2016-05-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/883#issuecomment-218774255 Thanks for the fix. How about add a test case to https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/test/spec/factory/notebookList.js

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-845] Fix Image URL issu...

2016-05-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/882#issuecomment-218770433 LGTM and merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-819] Add 'Last updated ...

2016-05-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/848#issuecomment-217239427 Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...

2016-05-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-217239266 Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: [Hot Fix] add missing karma.conf....

2016-05-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/875#issuecomment-217221167 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Minor Doc update - add SparkR to ...

2016-05-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/840#issuecomment-217218712 Merge if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-217051020 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-216966240 @sagarkulkarni3592 Thanks for taking care. I tried the last commit and i can see text is displayed on the right corner in 'simple'

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216957711 Last CI test failure is unrelated to the change. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216955848 Arrow style looks fine. I think it's good to be merged! --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-819] Add 'Last updated ...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/848#issuecomment-216952713 The improvement looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216951554 @r-kamath Are there any more works left for unchecked todo item 'UI fixes', in the description of this PR? --- If your project is set up for i

[GitHub] incubator-zeppelin pull request: Improve README.md

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/839#issuecomment-216950016 Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-599]notebook search sho...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-216866674 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...

2016-05-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-216637952 LGTM and merge if there're no more discussions! --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

2016-05-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216632774 Thanks @prabhjyotsingh taking a look. I'm merging it into master as a hotfix --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

2016-05-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216627328 After couple of different trial, figured out apply shiro filter to `/*` as before, and use authcBasic (default browser user auth dialog) instead of authc

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-819] Add 'Last updated ...

2016-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/848#issuecomment-216292583 @prasadwagle I have created fix for '405 Method Not Found'. Could you review https://github.com/apache/incubator-zeppelin/pull/870? --- If yo

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

2016-05-02 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/870 [HOTFIX] Authentication doesn't work after upgrade to jetty9 ### What is this PR for? After the jetty9 upgrade https://github.com/apache/incubator-zeppelin/pul

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-819] Add 'Last updated ...

2016-04-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/848#issuecomment-215996483 @prasadwagle I'm getting the same error. Trying to fix... --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-502] Python interpreter...

2016-04-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-215979143 Thanks @hriviere for the contribution! Tried and working nicely. You may want to add python.md to [_nagivation.html](https://github.com/apache

[GitHub] incubator-zeppelin pull request: add note permission

2016-04-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/861#issuecomment-215976889 'angular.element' can be used instead of '$' --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: Fix duplicate CORS header problem

2016-04-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/867#issuecomment-215944687 I'm merging it into master as a hotfix, while it breaks development mode of zeppelin-web. @echarles 's suggestion is very valid and it can

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...

2016-04-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-215944181 This PR does not update note title in the menu and main page, when title is changed. Try change note title and see list of note in the menu and main

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-826] Run scheduled note...

2016-04-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/856#issuecomment-215943465 I think #860 is related to this issue, too. After Zeppelin restarts, scheduled notebooks are going to be executed. However credentials from #860 might

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-705]Search should aware...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-215942528 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-599]notebook search sho...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-215941636 Thanks @ravicodder for the improvement. Tried and works well. If it is not too difficult, it might be better to have a simple testcase for

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-828] Use individual use...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/860#issuecomment-215940375 Hi @prasadwagle. Thanks for sharing great work. I think this is nice solution for http://apache-zeppelin-users-incubating-mailing-list.75479.x6

[GitHub] incubator-zeppelin pull request: add note permission

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/861#issuecomment-215939179 Thanks for the contribution. Last CI test shows error ``` [INFO] src/components/navbar/navbar.controller.js [INFO] line 77 col 33

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-215933673 Thanks @sagarkulkarni3592 for very useful feature. It works nicely with 'default' looknfeel. However, 'simple' looknfeel it d

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/864#issuecomment-215932798 I'm merging it into master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-819] Add 'Last updated ...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/848#issuecomment-215932248 Although last commit pass the CI, because https://github.com/apache/incubator-zeppelin/pull/854 is merged in master, merging this PR will fail with

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215929882 %html rendering is working nicely! If pickaday.js, moment.js, ZeroClipboard.js are required to use handsontable, they also need to be in 'zep

[GitHub] incubator-zeppelin pull request: Improve README.md

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/839#issuecomment-215929407 @cyhsutw. Thanks for taking care both profiles. In the last commit, the description looks like ``` # `-Pr` (optional

[GitHub] incubator-zeppelin pull request: Minor Doc update - add SparkR to ...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/840#issuecomment-215908400 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-215901294 Great work @doanduyhai. One thing is, instead of 'Back-end Angular Interactions' and 'Front-end Angular Interactions'

[GitHub] incubator-zeppelin pull request: Prevent duplicated response heade...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/863 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-zeppelin pull request: Prevent duplicated response heade...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/863#issuecomment-215898076 Closing this PR while #867 is better solution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: Fix duplicate CORS header problem

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/867#issuecomment-215683327 It looks like better solution than #863 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215516220 Is it possible to handle '%html' inside of table cell? if i run ``` println(s"""%table key\tv

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

2016-04-28 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/864 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

2016-04-28 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/864 [ZEPPELIN-779] Dynamic form doesn't work with python3 ### What is this PR for? When pyspark interpreter configured to use python3, dynamic form doesn't work.

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

2016-04-28 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/864 [ZEPPELIN-779] Dynamic form doesn't work with python3 ### What is this PR for? When pyspark interpreter configured to use python3, dynamic form doesn't work.

[GitHub] incubator-zeppelin pull request: Prevent duplicated response heade...

2016-04-28 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/863 Prevent duplicated response header insertion ### What is this PR for? Headers are inserted twice in http response message after https://github.com/apache/incubator-zeppelin/pull

[GitHub] incubator-zeppelin pull request: ZEPPELIN-825: Set appropriate def...

2016-04-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-215447199 Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder support for...

2016-04-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-215308148 @johnnyws Tested and working great. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-183] Interpreter proces...

2016-04-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/795#issuecomment-215135830 I'm merging it if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: Improve README.md

2016-04-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/839#issuecomment-215135400 I think it would be better if both -Psparkr and -Pr are included with some description for them --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: add /r/lib/ in .gitignore

2016-04-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/857#issuecomment-215134558 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-183] Interpreter proces...

2016-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/795#issuecomment-214979591 @vijikarthi Thanks for testing. 'SPARK-10872' is expected while default configuration of sparkcontext creates 'metastore_db' in the sa

[GitHub] incubator-zeppelin pull request: ZEPPELIN-825: Set appropriate def...

2016-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-214972953 Thanks @rohannr for the improvement and test. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-183] Interpreter proces...

2016-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/795#issuecomment-214944397 Now CI is green and ready to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-183] Interpreter proces...

2016-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/795#issuecomment-214938916 @vijikarthi I have pushed more commits with fix. Could you try it again? Zeppelin already passes [AuthenticationInfo](https://github.com/apache

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-183] Interpreter proces...

2016-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/795#issuecomment-214891322 @vijikarthi To enable dropdown selection, you need to click 'edit' button. --- If your project is set up for it, you can reply to this emai

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-823] Remove usage of Sc...

2016-04-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/853#issuecomment-214146455 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-214146221 @ravicodder i was asking JIRA user ID for ZEPPELIN-818, somehow i commented here by mistake. Having JIRA issue is not mandatory but i think it's a

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-705]Search should aware...

2016-04-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-214145484 @ravicodder No worries. Thanks for the fix and tests. Looks good to me. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: Fix nginx config to use single po...

2016-04-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/814#issuecomment-214075844 Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: ZEPPELIN-818: Set appropriate def...

2016-04-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-214060532 Looks good. Thanks @rohannr for good improvement. Could you create new JIRA issue as @felixcheung suggested and rebase to resolve conflict? --- If

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder support for...

2016-04-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-213857945 Tested this branch and found some strange behavior. After creation of new notebook, existing notebooks are displayed twice in the list, until refresh

[GitHub] incubator-zeppelin pull request: Fix typos in docs

2016-04-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/852#issuecomment-213853640 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213853600 @ravicodder Also can i ask your user ID on [JIRA](https://issues.apache.org/jira/browse/ZEPPELIN)? --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213704877 @ravicodder Do you have JIRA id? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-818]Permissions cannot ...

2016-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/846#issuecomment-213161894 Merge it into master if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-817] Fix issue for quer...

2016-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/845#issuecomment-212949908 Thanks for the contribution. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-818]Permissions cannot ...

2016-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/846#issuecomment-212796316 Tested and Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-817] Fix issue for quer...

2016-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/845#issuecomment-212786883 Looks good. Could you also update json-flattener version in [bin_license/LICENSE](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin

[GitHub] incubator-zeppelin pull request: ZEPPELIN-815 don't create a sub s...

2016-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/844#issuecomment-212784586 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: ZEPPELIN-804 Refactoring registra...

2016-04-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/835#issuecomment-211283373 @jongyoul Sounds like a good plan! Thanks for the explanation. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: Fix nginx config to use single po...

2016-04-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/814#issuecomment-210926723 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-183] Interpreter proces...

2016-04-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/795#issuecomment-210794756 Changed to * shared * scoped * isolated --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-804 Refactoring registra...

2016-04-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/835#issuecomment-210780122 Maybe i didn't explained very well. :-) I think having another mechanism that register interpreter based on information in json file, in add

[GitHub] incubator-zeppelin pull request: Add tooltip for notes reload butt...

2016-04-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/813#issuecomment-210741303 LGTM merging it into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: Pluggable resource pools

2016-04-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/816#issuecomment-210729996 Somehow, the PR includes commits from other contributions. @fireboy1919 could you manage it to not includes them? --- If your project is set up for it

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-705]Search should aware...

2016-04-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-210728757 @ravicodder Thanks for the patch. Would it be difficult to make corresponding rest api test? --- If your project is set up for it, you can reply

  1   2   3   4   5   6   7   8   9   10   >