Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-212439527
I think we can merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-208119840
@johnnyws looks good. a few minor comments
+ creating en empty object and assigning props to it is unconventional in
JS; normally, you would
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-206086712
@johnnyws I understand. The key in map-based implementation should be
`notebookId` because it's unique. That said, I don't want to push you
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-20330
@zhongneu I'm still unclear about your example
```
"/this/is/a/file"
"/this/is/a/file"
```
looks like the sam
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-205096086
I don't see a problem with having same notebook names in different folders;
it might be useful actually. Or did I misunderstand you?
---
If your pr
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-205094823
Since we don't have folders yet, then with what to consider backward
compatibility?
In my opinion, it's more important to implement this fe
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-205090154
in my opinion, it is more maintainable to forbid duplicate names hence
simplify getting / setting mechanism. is duplicates a useful feature?
---
If your
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-205080017
yes, seems like lodash has a problem setting values with `.` in them since
it uses dot for denoting nested properties. what you can do, is set them as
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-202717837
Maybe you should do `bower install`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-201147629
You can map over these objects either using
[lodash](https://lodash.com/docs#map), or doing something like
`Object.keys(obj).map(key => obj[key]).s
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-201130260
@johnnyws what is your opinion on [this
comment](https://github.com/apache/incubator-zeppelin/pull/767#discussion_r55478812)?
---
If your project is set
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117897603
Looks like it's ready for merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117640636
Is it okay that Travis is complaining?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-116695972
@corneadoug go for it man!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-112082285
Looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-111355208
It's okay. I just have an aversion to `this` and try to eliminate it from
my code. Up to you.
---
If your project is set up for it, you can reply to
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-111350416
@corneadoug I skimmed through the last three commits. It looks like you did
a nice job. Using `controller as` pattern is definitely an improvement. The
17 matches
Mail list logo
