Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-206086712
@johnnyws I understand. The key in map-based implementation should be
`notebookId` because it's unique. That said, I don't want to push you with this
approach. If you think that list-based implementation does the job well and is
maintainable, then let's keep it. It would benefit from a slight refactoring,
in my opinion, just to make the code more readable.
The problem of adding backward compatibility for duplicate names is
probably out of scope of this PR.
In my opinion, duplicated names shall not be allowed. I struggle to see any
valid use case here. On the front-end, backward compatibility problem could
potentially be solved by adding a unique postfix to names (e.g. notebook id) in
the model that isn't displayed in the view.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
