GitHub user minahlee reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/894
[ZEPPELIN-577] ASCII control character errors in Zeppelin
### What is this PR for?
Take care of `interpreter not found` issue when code is copied from CRLF
line ending editor
Github user minahlee closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/894
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user minahlee closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/894
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user minahlee reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/894
[ZEPPELIN-577] ASCII control character errors in Zeppelin
### What is this PR for?
Take care of `interpreter not found` issue when code is copied from CRLF
line ending editor
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/894
[ZEPPELIN-577] ASCII control character errors in Zeppelin
### What is this PR for?
Take care of `interpreter not found` issue when code is copied from CRLF
line ending editor
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/883#issuecomment-218983138
@Leemoonsoo Just added test. Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/883
Fix notebook folder structure name match bug
### What is this PR for?
Current regex match rule for notebook folder takes not only `/` as
delimiter but also `[` and
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/817#issuecomment-208202639
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/813
Add tooltip for notes reload button
### What is this PR for?
Notebook reload icon is not intuitive so add tooltip to it.
### What type of PR is it?
Improvement
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/770
Change icon color when permission setting is open
### What is this PR for?
* Set note action icon color to be changed properly
* Switch location of _Settings_ and _Note
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/755#issuecomment-191547114
@Leemoonsoo that sounds like more appropriate approach. @karup1990 what do
you think?
---
If your project is set up for it, you can reply to this email
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/755#issuecomment-191044159
Tested, looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/735#issuecomment-186813788
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/736
Fix pyspark to work on yarn mode when spark version is lower than or equal
to 1.4.x
### What is this PR for?
pyspark.zip, py4j-\*.zip should be distributed to yarn nodes to make
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/723#issuecomment-185071188
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/718#issuecomment-185070059
@malur I recently made a PR for updating Zeppelin classpath via GUI for
different JDBC drivers. Please see #717
---
If your project is set up for it, you
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/716#issuecomment-184604587
@FRosner Sure take your time and thank you for keeping your eyes on it :)
---
If your project is set up for it, you can reply to this email and have your
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/711#issuecomment-184535856
@felixcheung FYI, I just deployed the latest documentation on website.
---
If your project is set up for it, you can reply to this email and have your
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/711#issuecomment-184530640
@felixcheung Could you also build the docs and deploy them after you merge
the PRs which includes docs changes? So the updated docs can be reflected to
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/673#issuecomment-184467011
@FRosner Yes it will ignore the last row if it's empty. I couldn't
reproduce the error with the condition you explained but pushed a fix to handle
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/717
[DOCS][JDBC]Guide user to add jdbc driver jar file via GUI interpreter menu
### What is this PR for?
Update jdbc documentation to let user load dependencies via GUI interpreter
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/716
Return empty file list instead of throwing error when dependency artifact
is empty
### What is this PR for?
This PR returns empty list of dependency files instead of throwing error
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/715
Fix broken form of keyboard shortcut modal page
### What is this PR for?
Fix broken form of keyboard shortcut help modal
### Is there a relevant Jira issue? No
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/673#issuecomment-184041841
@FRosner I found the way to reproduce this bug. This happens when you have
empty artifact in the rows other than the last row as below:
 to see
CI passed. I trigger
Github user minahlee closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user minahlee reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/685
[ZEPPELIN-595] Allow displaying decimal format in d3
### What is this PR for?
This PR enables displaying decimal format in built-in nvd3 chart
### What type of PR is it
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/685
[ZEPPELIN-595] Allow displaying decimal format in d3
### What is this PR for?
This PR enables displaying decimal format in built-in nvd3 chart
### What type of PR is it
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/673#issuecomment-175916153
Every comments has been addressed and test/docs are updated. Ready for
review
---
If your project is set up for it, you can reply to this email and have
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/673#issuecomment-175241376
@felixcheung yes load dependency using %dep still works, and I simply added
the deprecated message on the use of `z.load()`, `z.reset()`, `z.addRepo
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/673#issuecomment-175231786
@astroshim, @anthonycorbacho Thank you for the review. I pushed commits to
address your comment. Please take a look into this again.
---
If your project
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/673
[WIP][Zeppelin-630] Introduce new way of dependency loading to intepreter
### What is this PR for?
With this PR user will be able to set external libraries to be loaded to
specific
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/611#issuecomment-173000385
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/627#issuecomment-171123889
@corneadoug It is already possible to have lowercase character for the
beggining of the word in notebook title
---
If your project is set up for it, you
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-17761
Rebased master branch and CI build passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user minahlee closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user minahlee reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/627
Remove paragraph title capitalization style from css
### What is this PR for?
Remove paragraph title font capitalization style from css.
### What type of PR is it
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/626#issuecomment-171106177
+1 let's merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/627
Remove paragraph title capitalization style from css
### What is this PR for?
Remove paragraph title font capitalization style from css.
### What type of PR is it?
Bug
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/463#issuecomment-169804154
Tested on mesos, yarn, standalone and works like a charm. Looks good to me
---
If your project is set up for it, you can reply to this email and have your
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/605
[ZEPPELIN-572] pyspark interpreter doesn't work on yarn-client
### What is this PR for?
Set `spark.yarn.isPython` to be `true` to distribute pyspark libraries to
workers
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-169087533
@bzz Thanks for review. Dependencies that added to
`zeppelin-interpreter/pom.xml` is already used in `spark/pom.xml`, so I
answered 'no' for lice
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/590
ZEPPELIN-546 Enables interpreter library loading from maven repository
### What is this PR for?
This PR enables library loading from maven repository to load interpreter
binaries
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/573#issuecomment-167722761
@khalidhuseynov Keeping notebookRepo class for the flexibility makes
perfect sense. I just addressed it please review
---
If your project is set up for it
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167503210
@HeartSaVioR It's not mandatory to have review from PPMC/committer since we
follow lazy consensus rule but always good to be reviewed by more p
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/573
[Zeppelin 537] Improve behavior of reloading notebooks from storage
### What is this PR for?
Improve behavior of reloading notebooks from storage
### What type of PR is it
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/550#issuecomment-167437094
@HeartSaVioR Thanks for quick response. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167370653
@Leemoonsoo sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167180989
Ctrl + Alt + k and Ctrl + Alt + E does work on chrome, firefox but not on IE
and Ctrl + Alt + 1~0,-,+ doesn't work on all three browsers
---
If
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167180651
Ctrl + c is commonly used to copy highlighted text to the clipboard so
better to change.
---
If your project is set up for it, you can reply to this email
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/571
Remove author tag
### What is this PR for?
Remove author tag from java doc since Zeppelin doesn't encourage to use it
### What type of PR is it?
Document
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/570
Fix z-index of control button tooltip
### What is this PR for?
Fix z-index for control button tooltip
### What type of PR is it?
Bug Fix
### Is there a
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/526#issuecomment-163819332
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/524
[ZEPPELIN-495] Enable running interpreters with distribution package
In distribution package, zeppelin-interpreter module is not added to
classpath when Zeppelin starts interpreter
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/313#issuecomment-159523282
@piyush-mukati any update on this PR? I found one bug related to spark
interpreter jvm memory setting, and this feature will be useful to handle this
bug
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/464#issuecomment-159147970
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/458
Fix notebook clone bug
Handle exception when paragraph's `getReturn` method returns unparseable
object.
You can merge this pull request into a Git repository by running:
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/451
[Zeppelin-136] Zeppelin delete paragraph content after 'Move up'
Zeppelin doesn't keep the text change in editor if user tries to "Move up"
or "Move do
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/447#issuecomment-157950993
I like the idea, it will improve user experience a lot.
I found there are few things need to be handled.
There 3 different look&feel mod
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/435
[ZEPPELIN-421] Remove deprecated spark interpreter properties from inâ¦
â¦terpreter ui
Removed deprecated properties `spark.home`, `spark.yarn.jar`.
Corresponding docs
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/432
[ZEPPELIN-420] Improve notebook clone behavior
This PR handles two issues with notebook clone behavior.
* If same paragraphs from original notebook and cloned notebook run at the
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/394#issuecomment-156015874
@MikeTYChen This issue has been resolved by #309 Do you mind to close this
one?
---
If your project is set up for it, you can reply to this email and have
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/407#issuecomment-155730976
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/410#issuecomment-155661742
@felixcheung I'd like to help
[ZEPPELIN-368](https://issues.apache.org/jira/browse/ZEPPELIN-368?jql=project%20%3D%20ZEPPELIN).
Do you mind if I c
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/411#issuecomment-155295271
@felixcheung AFAIK if two spark interpreters are bind to one notebook,
Zeppelin will use only one spark interpreter which is placed upper than the
other
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/411#issuecomment-155230051
@felixcheung Thanks for review. I made it to omit interpreter name when it
is the first interpreter of the group.
```
%hive.hql -> %h
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/411
[ZEPPELIN-328] Interpreter page should clarify the % magic syntax for
interpreter group.name
* Display %interpreterGroup.interpreterName instead of
%settingName.interpreterName
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/309#issuecomment-155045488
@Leemoonsoo Rebased master branch and pushed a fix for CI test.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/410
[ZEPPELIN-407] Improve document on how to manage external libraries in
spark interpreter
Improve docs on library loading in spark interpreter.
* Add information to load libraries
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/405#issuecomment-154803651
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/394#issuecomment-154723437
@Leemoonsoo @MikeTYChen I pushed #309 earlier to address same issue as this
one and it has similar approach @Leemoonsoo suggested above. Can you guys
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/375#issuecomment-152396012
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/358
Replace button to div in scatter settings
This PR fixes same issue as
[ZEPPELIN-351](https://issues.apache.org/jira/browse/ZEPPELIN-351?jql=project%20%3D%20ZEPPELIN)
which Firefox/IE
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145621950
Beacause PR will load notebooks from storage everytime client requests
notebook list, which can be burden to Zeppelin with a bunch of notebooks. So I
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145493238
@Leemoonsoo @khalidhuseynov ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/331
[Zeppelin 329] Notebook copied in file system level should be reflected in
notebook list
This PR enables Zeppelin to reflect addition/changes/removal of
`{ZEPPELIN_NOTEBOOK_DIR
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/309
[ZEPPELIN-309] Redirect to created/cloned notebook page on notebook câ¦
â¦reation/clone
This PR enables redirecting to new/cloned notebook pages when create/clone
notebook
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/171#issuecomment-125782879
Tested and LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/34#issuecomment-124404262
I rebased master branch and made a small change.
When I created this PR, there was no angular-bootstrap version supporting
angular 1.3.x so I had to
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/149
Switch ngDelete to ngEscape
When IBM-compatible keyboards user presses `Delete` key, it updates title
of notebook/paragraph instead of forward delete.
This PR fix this bug by
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/95
Enable to type dot(.) in title
Changed 'keypress' event to 'keyup' event since keypress event is for
printable characters.
You can merge this pull request into
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/90
Start zeppelin only with java not spark-submit
Since spark agrs are supported through interpreter setting menu in UI,
launching zeppelin with spark-submit is not needed anymore.
You
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/87#issuecomment-107769341
@jongyoul Yes I am working on that too :) I will make more commits on this
PR.
---
If your project is set up for it, you can reply to this email and have
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/87
Get useHiveContext property from environment variable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/34#issuecomment-94346959
@Leemoonsoo I pushed a fix, can you review it please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/37
[ZEPPELIN-41] Missing HiveInterpreter configuration at Configuration.java
This PR enables to create hive interpreter by default without
conf/zeppelin-site.xml
You can merge this pull
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/34
[ZEPPELIN-35] Icons should have tool tips
Fix the issue that tooltip doesn't show by forcing angular version to 1.2.x.
angular-bootstrap doesn't support angular 1.3 for now
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/33
Gh pages update git url and package/groupId
- Update git url from https://github.com/nflabs/zeppelin to
https://github.com/apache/incubator-zeppelin
- Update package/groupId from
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/27#issuecomment-90809249
It's awesome!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/29#issuecomment-90506604
Thx for the fix! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/15
Update website url
- Update website url from http://zeppelin-project.org to
http://zeppelin.incubator.apache.org
- Update mailing list link from
https://groups.google.com/forum
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/14
Gh pages update new feature
Move PR from NFLabs/zeppelin#393
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator
100 matches
Mail list logo
