[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/789 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-210248478 Merge if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user vgmartinez commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-205201358 +1...LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-204737179 +1 @bzz. And this PR looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202180621 after these merged changes, does the build still make use of `-Drscala.version=1.0.6` --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202170740 @Leemoonsoo code looks good and rationale for customizing at least JVM properties now and leaving ui for env vars for further improvements makes sense.

Re: [GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Moon - is there really such an urgency with this PR that it can't wait 12-24 hours for a discussion over whether we should do it before we have an interface to support it? > On Mar 27, 2016, at 7:10 PM, Leemoonsoo wrote: > > Github user Leemoonsoo commented on the pull

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202167530 @elbamos > I've explained the objection to you several times. False. Here's your objection

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202133105 Moon I've explained the objection to you several times. You're choosing to ignore that. I am therefore telling you don't have a consensus and it needs to be

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202128120 Please note that reason must be provided for objection to the code contribution. Unless this PR doesn't have any proper objection comes with reason,

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202127132 I'm not sure why it is you don't want to send the email to the list, but fine, I will do so later on. When you decided to submit this to apache the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202126499 @elbamos If you have objection in this PR, not me, but you'll need to explain your **reason** in this pullrequest comment. And i'm repeating that

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201968581 @elbamos Note that, every comments in PullRequest already being broadcasted to developer mailing list. If you have any other subject to discuss

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201965711 I meant the developer mailing list for Zeppelin. We can continue the discussion there in the presence of others. > On Mar 26, 2016, at 8:51 PM, Lee

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201964685 @elbamos If the 'community' you mean is not a Zeppelin community, please understand that I don't discuss / review the code contribution anywhere

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201953405 No - if I have to do that, I think it will have to go to the community, so instead of wasting my time let's just discuss it there. > On Mar 26,

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201949330 @elbamos Can you provide link to your explanation in multiple forums? i didn't see any. --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201949274 I've explained this several times already in multiple forums. If you don't want to accept it, then you should raise the issue on the developers list so the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201871771 @elbamos > No -echarles is right. The current preference system is terribly confusing and often inconsistent. It is a source of user complaint.

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201166366 The reason set env in RemoteInterpreter is, environment variable need to set before the process creation. So shell script (./bin/interpreter.sh) can take

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user echarles commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-201156913 Current patch sets env in RemoteInterpreter and system properties in RemoteInterpreterServer. Why is this unbalanced (I would have expected setting env and

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-200419212 This patch is ready, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-95] Make environment va...

GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/789 [ZEPPELIN-95] Make environment variables and jvm properties customizable per Interpreter ### What is this PR for? This PR make environment variable and jvm properties