Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147712767
Basically, a unittest that fails without this patch and passes with this
patch.
I thought little bit more about this action. Current rule of
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147721881
I also prefer the current rule
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147692673
Change looks good. But can we have an unittest for it before merge?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147706453
Hi @Leemoonsoo,
I'm not sure but the test should not be used commitParagraph ? which is
exactly what I should do I'm a little confused.
---
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147855146
And sometimes one does not want a new paragraph created automatically
---
If your project is set up for it, you can reply to this email and have your
