Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-176933363
Great! Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user schnee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-176800827
Rock On!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user schnee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-176532800
let's see if that did it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-176509552
Using this one would solve it:
```
//*[@id='main']/div//h3/span/button[@tooltip='Remove the notebook']
```
---
If your project is set up for i
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-176508056
Alright, seems like a test is now broken:
```
{"method":"xpath","selector":"//*[@id='main']/div//h3/span[1]/button[@tooltip='Remove
the notebook']
GitHub user schnee reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/662
moved delete button to help protect against accidental clicks
### What is this PR for?
The delete notebook action is embedded in the button bar with several other
buttons, increasin
Github user schnee closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-176488951
@schnee could you close and reopen this PR one more time to see if travis
goes better?
---
If your project is set up for it, you can reply to this email
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-175972379
@felixcheung Looks like basic timeout somehow.
I doubt this PR would break anything
---
If your project is set up for it, you can reply to this email
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-175955043
Any idea why travis is failing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-174240107
Thanks LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user schnee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-173986989
applied the styling to the delete button suggested by @corneadoug. Corner
rounding of the standalone delete button seems fixed.
https://cloud.githubus
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-173849618
The best way to align it would be to add:
```
vertical-align: middle;
display: inline-block;
```
To the button style and remove the `btn
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-173700763
awesome. thanks
@corneadoug FYI.
I'm not sure what's going on with travis though, seems like we are having
issues. Let's see if we could get
Github user schnee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-173579853
After applying the styling, here's the zoomed in view:
https://cloud.githubusercontent.com/assets/572964/12482629/47b74b34-c016-11e5-8591-bce8811d8b90.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-173449205
@schnee it looks like the trash icon is mis-aligned and off by a few pixels
- could you check please?
I suspect it has to do with ``
---
If your pro
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-173439511
Thanks for the improvement.
CI test failing is irrelevant, i think.
LGTM!
---
If your project is set up for it, you can reply to this email and ha
Github user schnee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-173427952
https://cloud.githubusercontent.com/assets/572964/12469440/58b7e1ba-bfb1-11e5-9b7c-926a759b3b6b.png";>
---
If your project is set up for it, you can reply to
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/662#issuecomment-173416496
thanks for the contribution. could you add a screenshot please?
---
If your project is set up for it, you can reply to this email and have your
reply app
GitHub user schnee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/662
moved delete button to help protect against accidental clicks
### What is this PR for?
The delete notebook action is embedded in the button bar with several other
buttons, increasing
21 matches
Mail list logo
