Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-185429817
cool LGTM. merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-185061838
I assume this is not running the tests, but only skipping?
(spark-1.6 build)
https://s3.amazonaws.com/archive.travis-ci.org/jobs/109789223/log.txt
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-185067023
Yes skipping since the env "TEST_SELENIUM" is not set.
Otherwise things like these would have shown up
06:06:10,610 INFO org.apac
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-185040374
Thanks @felixcheung for the review. Made appropriate changes.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-184535519
Merged with #706, and
https://github.com/apache/incubator-zeppelin/pull/709. CI green.
Ready for review.
---
If your project is set up for it, yo
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-181770768
Sure @felixcheung, this sounds better, have create a new PR
https://github.com/apache/incubator-zeppelin/pull/706 for addressing this.
---
If your pr
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-181732834
Great!
If any of these fails is there a simple way to know why? I think recently
there was one minor UI change and it was somewhat ambiguous when Trav
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-181200695
Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179731323
@bzz yes thank you. Did it for `SHIFT_ENTER` as well.
Some javascript associated with ace editor is causing problem with open
parenthesis, and
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179386505
Very nice useage of `Enum` here!
Probably a knit-piking but may be also `SHIFT_ENTER` diserves a place there
too?
Looks great to me.
I'
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179370570
@bzz thank you for the quick review, did the relevant change.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179255441
@prabhjyotsingh thanks for taking care of reivew in timely manner!
It looks great, how do you think can it be further improved by `import
static HelperKe
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179049821
Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
14 matches
Mail list logo
