[
https://issues.apache.org/jira/browse/ZOOKEEPER-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140984#comment-13140984
]
Mahadev konar commented on ZOOKEEPER-1246:
--
Looks good to me. Camille you
THanks Pat. Ill include it in 3.4.
Looks good to me.
thanks
mahadev
On Fri, Oct 28, 2011 at 2:26 PM, Patrick Hunt ph...@apache.org wrote:
I've uploaded patches if people have a chance to review.
On Fri, Oct 28, 2011 at 11:03 AM, Patrick Hunt ph...@apache.org wrote:
I entered the following
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/59/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 109 lines...]
jute:
[javac] Compiling 39
[
https://issues.apache.org/jira/browse/ZOOKEEPER-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch resolved ZOOKEEPER-652.
---
Resolution: Duplicate
I've created a subissue in ZOOKEEPER-233, so closing this later
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch resolved ZOOKEEPER-1003.
Resolution: Duplicate
I've created a subissue in ZOOKEEPER-233, so closing this later
[
https://issues.apache.org/jira/browse/ZOOKEEPER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141059#comment-13141059
]
Thomas Koch commented on ZOOKEEPER-233:
---
Copying the description of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1275:
---
Attachment: ZOOKEEPER-1275.patch
ZooKeeper client is only caller of
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1275
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/752/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141071#comment-13141071
]
Hadoop QA commented on ZOOKEEPER-1275:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250_watches_out_datatree.patch
trigger jenkins dummy issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141074#comment-13141074
]
Hudson commented on ZOOKEEPER-1268:
---
Integrated in ZooKeeper-trunk #1351 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141073#comment-13141073
]
Hudson commented on ZOOKEEPER-1273:
---
Integrated in ZooKeeper-trunk #1351 (See
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/60/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 105 lines...]
jute:
[javac] Compiling 39
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141081#comment-13141081
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141191#comment-13141191
]
Camille Fournier commented on ZOOKEEPER-1246:
-
Will do.
Any changes coming in without tests should really be meaningfully untestable. I
completely agree with the suggestion to require a testing uplift if you want to
add refactorings unless you know the refactored code has 90+% test coverage.
Personally, I have no problems with refactorings, but we
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/61/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 147 lines...]
.\src\zookeeper.c(1678): warning
These are due to space issues, it looks like. Does anyone know who to contact
about disk space on the windows build box?
C
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Tuesday, November 01, 2011 10:25 AM
To: dev@zookeeper.apache.org
Subject:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141205#comment-13141205
]
Camille Fournier commented on ZOOKEEPER-1246:
-
Oh brilliant, yet another
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141211#comment-13141211
]
Camille Fournier commented on ZOOKEEPER-1269:
-
Hey guys, someone want to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141234#comment-13141234
]
Camille Fournier commented on ZOOKEEPER-1136:
-
This change causes a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141235#comment-13141235
]
Camille Fournier commented on ZOOKEEPER-1264:
-
From a comment I added to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141244#comment-13141244
]
Benjamin Reed commented on ZOOKEEPER-1264:
--
the reason we take a snapshot
On Tue, Nov 1, 2011 at 7:21 AM, Fournier, Camille F.
camille.fourn...@gs.com wrote:
Personally, I have no problems with refactorings, but we seem to be spending
much of our time dealing with them right now when we really need to get 3.4
out the door. It's been months that this release has
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141248#comment-13141248
]
Camille Fournier commented on ZOOKEEPER-1264:
-
Thanks Ben. The patch I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141258#comment-13141258
]
Patrick Hunt commented on ZOOKEEPER-1264:
-
Awesome job Camille, thanks!
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1264
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/754/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141261#comment-13141261
]
Hadoop QA commented on ZOOKEEPER-1264:
--
+1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141262#comment-13141262
]
Patrick Hunt commented on ZOOKEEPER-233:
I've done some of this in the
bui...@apache.org
On Tue, Nov 1, 2011 at 7:26 AM, Fournier, Camille F.
camille.fourn...@gs.com wrote:
These are due to space issues, it looks like. Does anyone know who to contact
about disk space on the windows build box?
C
-Original Message-
From: Apache Jenkins Server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141263#comment-13141263
]
Benjamin Reed commented on ZOOKEEPER-1264:
--
ah cool. ok i'll check it out
Hi,
The ZooKeeper windows VS build is failing with messages like:
.\src\zookeeper.c(3070): fatal error C1088: Cannot flush compiler
intermediate file: 'C:\Users\hudson\AppData\Local\Temp\1\_CL_5ea413easy': No
space left on device
Can someone take a look at the disk on this build box?
I also like mockito. It has some limitations but generally can be very useful.
However, I'm also very much a fan of fixing our code base to be more testable
against real servers. I actually like the fact that we use a lot of
integration testing in our automated build. You do catch things that
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Camille Fournier resolved ZOOKEEPER-1186.
-
Resolution: Duplicate
ZooKeeper client seems to hang quietly on
I'm not suggesting it's an all or nothing proposition. We have a lot
of system/functional level testing, which is great. What we lack is
unit testing. Take this recent ZOOKEEPER-1271 issue as an example - in
many cases it's very hard, at the system level, to exercise all the
code paths esp the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141275#comment-13141275
]
Benjamin Reed commented on ZOOKEEPER-1264:
--
i applied your patch to trunk and
Fournier, Camille F.:
Any changes coming in without tests should really be meaningfully
untestable. I completely agree with the suggestion to require a testing
uplift if you want to add refactorings unless you know the refactored code
has 90+% test coverage.
Personally, I have no problems
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141285#comment-13141285
]
Camille Fournier commented on ZOOKEEPER-1264:
-
Yeah, sorry, these
Hi,
I'm like two days away from having a version of ZooKeeper with an immutable
DataTree on the server. This means that for any modification of the DataTree,
all Nodes from the modified one up to the root are replaced by new nodes.
Advantages:
- No synchronisation needed when accessing the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1232:
---
Attachment: ZOOKEEPER-1232.patch
remove unused o.a.z.server.util.Profiler
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1232:
---
Priority: Minor (was: Major)
Issue Type: Improvement (was: Bug)
remove
Thomas, we all agree that you have done useful work. But right now it seems
that you are more concerned with the aesthetics of the code base than the
correctness of it. You are capable of identifying potential bugs. Are you
capable of doing the work to provably identify them (by writing tests)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141332#comment-13141332
]
Matthias Spycher commented on ZOOKEEPER-1174:
-
I've run into a problem
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1232
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/755/
###
## LAST 60 LINES OF THE CONSOLE
###
On Tue, Nov 1, 2011 at 9:51 AM, Fournier, Camille F.
camille.fourn...@gs.com wrote:
Committers, this checking in of code without tests has got to stop. It's
actively detrimental to the code base and undermines any value we might be
getting from refactoring efforts. With very limited
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141341#comment-13141341
]
Hadoop QA commented on ZOOKEEPER-1232:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141347#comment-13141347
]
Patrick Hunt commented on ZOOKEEPER-1174:
-
Matthias - see ZOOKEEPER-1271, it's
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141355#comment-13141355
]
Benjamin Reed commented on ZOOKEEPER-1264:
--
got it. i think i see how to make
On Tue, Nov 1, 2011 at 9:51 AM, Fournier, Camille F.
camille.fourn...@gs.com wrote:
Thomas, we all agree that you have done useful work. But right now it seems
that you are more concerned with the aesthetics of the code base than the
correctness of it. You are capable of identifying potential
We have talked about this in the past. There are several clear advantages.
Do you have an appropriate immutable DataTree? What did you use to
implement this?
On Tue, Nov 1, 2011 at 9:40 AM, Thomas Koch tho...@koch.ro wrote:
Hi,
I'm like two days away from having a version of ZooKeeper with
Give me a budget. I will see what I can do.
On Tue, Nov 1, 2011 at 9:40 AM, Thomas Koch tho...@koch.ro wrote:
Once I've got there, I'd like to do performance comparissions between old
and
new. However I don't have accesses to hardware for such a test. So this
would
only be possible, if
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141369#comment-13141369
]
Mahadev konar commented on ZOOKEEPER-1264:
--
@Ben,
sorry to be pestering, I'd
Ted Dunning:
We have talked about this in the past. There are several clear advantages.
Do you have an appropriate immutable DataTree? What did you use to
implement this?
Java? :-)
I have not yet included any additional library, if that's your question.
What do you mean by appropriate?
The testing pain that I have had most is actually the pain of testing a
client library against failure modes. The scaffolding that would most help
there would be a mocked Zookeeper client that I could use to trigger
disconnections and expirations and such. Launching a local server is
distinctly
On Tue, Nov 1, 2011 at 10:46 AM, Thomas Koch tho...@koch.ro wrote:
Ted Dunning:
We have talked about this in the past. There are several clear
advantages.
Do you have an appropriate immutable DataTree? What did you use to
implement this?
Java? :-)
I have not yet included any
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141436#comment-13141436
]
Matthias Spycher commented on ZOOKEEPER-1174:
-
Patrick, thanks for the
Sorry, you're right, let me rephrase: We shouldn't be checking in code that is
claiming to fix bugs without tests. I also personally think that we should
strongly encourage refactorings to come in with additional tests, as per Ted's
suggestion. Leave the code base better than when you left it
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141440#comment-13141440
]
Matthias Spycher commented on ZOOKEEPER-1271:
-
+1 for rethrow.
Given that
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141456#comment-13141456
]
Patrick Hunt commented on ZOOKEEPER-1174:
-
np, this reminds me though, we are
i second the need for such a mocked ZooKeeper client! there are a
couple of failure cases to test in an application that uses ZooKeeper,
but we don't provide a good library to generate them.
ben
On Tue, Nov 1, 2011 at 11:10 AM, Ted Dunning ted.dunn...@gmail.com wrote:
The testing pain that I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141487#comment-13141487
]
Camille Fournier commented on ZOOKEEPER-1100:
-
I'm reviewing this issue.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141526#comment-13141526
]
Camille Fournier commented on ZOOKEEPER-1100:
-
More to the point, are you
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-1271:
-
Attachment: ZOOKEEPER-1271.patch
Minor patch to rethrow.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141572#comment-13141572
]
Mahadev konar commented on ZOOKEEPER-1257:
--
Looked through the code, the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Camille Fournier updated ZOOKEEPER-1100:
Attachment: ZOOKEEPER-1100.patch
example test using mockito. Minus of course
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1271
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/756/
###
## LAST 60 LINES OF THE CONSOLE
###
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1100
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/757/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141585#comment-13141585
]
Hadoop QA commented on ZOOKEEPER-1100:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141586#comment-13141586
]
Hadoop QA commented on ZOOKEEPER-1271:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141608#comment-13141608
]
Gunnar Wagenknecht commented on ZOOKEEPER-1100:
---
The issue we faced was
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-1270:
Fix Version/s: (was: 3.4.0)
3.4.1
It looks like this issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-1270:
Affects Version/s: (was: 3.4.0)
testEarlyLeaderAbandonment failing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141654#comment-13141654
]
Mahadev konar commented on ZOOKEEPER-1269:
--
Camille, Should this go into 3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141719#comment-13141719
]
Mahadev konar commented on ZOOKEEPER-1100:
--
Camille,
I dont think we have a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-1271:
-
Attachment: ZOOKEEPER-1271.patch
Added a test case. Added mockito as a dependency.
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1271
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/758/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141891#comment-13141891
]
Hadoop QA commented on ZOOKEEPER-1271:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-1271:
-
Attachment: ZOOKEEPER-1271-trunk.patch
Trunk patch.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-1271:
-
Attachment: ZOOKEEPER-1271-3.4.patch
3.4 patch.
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1271
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/759/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141913#comment-13141913
]
Hadoop QA commented on ZOOKEEPER-1271:
--
+1 overall. Here are the results of
81 matches
Mail list logo
