Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6707/ --- (Updated Jan. 25, 2013, 7:59 a.m.) Review request for zookeeper. Description -

[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: ZOOKEEPER-107-24-Jan.patch Edward's comments addressed.

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

> On Jan. 23, 2013, 7:30 a.m., Edward Ribeiro wrote: > > /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 492 > > > > > > I didn't get why you do this test here. If you try to remove a >

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

> On Jan. 23, 2013, 7:20 a.m., Edward Ribeiro wrote: > > /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 467 > > > > > > Lines 467-479 contains duplicate code. I suggest to create a metho

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

> On Jan. 23, 2013, 7:08 a.m., Edward Ribeiro wrote: > > /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 450 > > > > > > What if the newMembers is "host1, host2, host3" (i.e., with spaces

[jira] [Commented] (ZOOKEEPER-1601) document changes for multi-threaded CommitProcessor and NIOServerCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562501#comment-13562501 ] Patrick Hunt commented on ZOOKEEPER-1601: - Hi Thawan bq. There is known issue

[jira] [Commented] (ZOOKEEPER-1597) Windows build failing

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562478#comment-13562478 ] Michi Mutsuzaki commented on ZOOKEEPER-1597: It looks like a compatibility

[jira] [Updated] (ZOOKEEPER-1615) minor typos in ZooKeeper Programmer's Guide web page

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1615: Assignee: Evan Zacks > minor typos in ZooKeeper Programmer's Guide web page > -

[jira] [Updated] (ZOOKEEPER-1628) Documented list of allowable characters in ZK doc not in line with code

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1628: Assignee: Gabriel Reid > Documented list of allowable characters in ZK doc not in l

ZooKeeper_branch33_solaris - Build # 422 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch33_solaris/422/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 100554 lines...] [junit] 2013-01-25 06:58:45,

[jira] [Reopened] (ZOOKEEPER-1597) Windows build failing

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reopened ZOOKEEPER-1597: - Looks like there's a small issue, from apache jenkins: {noformat} Build started 1/25/201

ZooKeeper-trunk-WinVS2008 - Build # 685 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/685/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 101 lines...] generate_jute_parser: [mkdir] C

[jira] [Commented] (ZOOKEEPER-1346) Handle 4lws and monitoring on separate port

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562373#comment-13562373 ] Edward Ribeiro commented on ZOOKEEPER-1346: --- On a related issue, I have writ

[jira] [Commented] (ZOOKEEPER-1346) Handle 4lws and monitoring on separate port

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562338#comment-13562338 ] Edward Ribeiro commented on ZOOKEEPER-1346: --- Hi, It just occurred me that

Failed: ZOOKEEPER-1626 PreCommit Build #1363

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1626 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1363/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1626) Zookeeper C client should be tolerant of clock adjustments

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562335#comment-13562335 ] Hadoop QA commented on ZOOKEEPER-1626: -- -1 overall. Here are the results of test

[jira] [Updated] (ZOOKEEPER-1626) Zookeeper C client should be tolerant of clock adjustments

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Patrick McCabe updated ZOOKEEPER-1626: Attachment: ZOOKEEPER-1366.004.patch I agree... let's use {{CLOCK_MONOT

[jira] [Commented] (ZOOKEEPER-1626) Zookeeper C client should be tolerant of clock adjustments

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562260#comment-13562260 ] liang xie commented on ZOOKEEPER-1626: -- Hi [~cmccabe], could you consider using "

[jira] [Updated] (ZOOKEEPER-1495) ZK client hangs when using a function not available on the server.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Skye Wanderman-Milne updated ZOOKEEPER-1495: Attachment: ZOOKEEPER-1495_branch34.patch Patch that can be applied to

[jira] [Created] (ZOOKEEPER-1629) testTrancationLogCorruption occasionally fails

Alexander Shraer created ZOOKEEPER-1629: --- Summary: testTrancationLogCorruption occasionally fails Key: ZOOKEEPER-1629 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1629 Project: ZooKeeper

Success: ZOOKEEPER-1423 PreCommit Build #1362

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562185#comment-13562185 ] Hadoop QA commented on ZOOKEEPER-1423: -- +1 overall. Here are the results of test

[jira] [Updated] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated ZOOKEEPER-1423: -- Attachment: ZOOKEEPER-1423.3.patch Excuse me, forgot two unused fields in ServerSta

Failed: ZOOKEEPER-1423 PreCommit Build #1361

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562133#comment-13562133 ] Hadoop QA commented on ZOOKEEPER-1423: -- -1 overall. Here are the results of test

[jira] [Updated] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated ZOOKEEPER-1423: -- Attachment: ZOOKEEPER-1423.2.patch Adding a new version of the patch.

[jira] [Updated] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated ZOOKEEPER-1423: -- Assignee: Edward Ribeiro > 4lw and jmx should expose the size of the datadir/da

Re: Review Request: ZOOKEEPER-1147: Add support for local sessions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8935/#review15654 --- /src/java/main/org/apache/zookeeper/cli/CreateCommand.java

[jira] [Commented] (BOOKKEEPER-556) BookieServerMXBean#getServerState makes no sense

[ https://issues.apache.org/jira/browse/BOOKKEEPER-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561901#comment-13561901 ] Hadoop QA commented on BOOKKEEPER-556: -- Testing JIRA BOOKKEEPER-556 Patch [000

Failed: ZOOKEEPER-1626 PreCommit Build #1360

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1626 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1360/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1626) Zookeeper C client should be tolerant of clock adjustments

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561895#comment-13561895 ] Hadoop QA commented on ZOOKEEPER-1626: -- -1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1608) Add support for key-value store as optional storage engine

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561885#comment-13561885 ] Thawan Kooburat commented on ZOOKEEPER-1608: Thank you for your interest.

[jira] [Commented] (BOOKKEEPER-544) Modify hedwig server tests to allow client testcases to start/stop them as part of their tests

[ https://issues.apache.org/jira/browse/BOOKKEEPER-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561880#comment-13561880 ] Hudson commented on BOOKKEEPER-544: --- Integrated in bookkeeper-trunk #73 (See [https

[jira] [Updated] (ZOOKEEPER-1626) Zookeeper C client should be tolerant of clock adjustments

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Patrick McCabe updated ZOOKEEPER-1626: Attachment: ZOOKEEPER-1366.003.patch thanks, Benjamin. Fixed.

Success: ZOOKEEPER-1628 PreCommit Build #1359

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1628 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1359/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1628) Documented list of allowable characters in ZK doc not in line with code

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561662#comment-13561662 ] Hadoop QA commented on ZOOKEEPER-1628: -- +1 overall. Here are the results of test

[jira] [Updated] (ZOOKEEPER-1627) Add org.apache.zookeeper.common to exported packages in OSGi MANIFEST headers

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arnoud Glimmerveen updated ZOOKEEPER-1627: -- Issue Type: Improvement (was: Bug) > Add org.apache.zookeeper.common t

[jira] [Updated] (ZOOKEEPER-1628) Documented list of allowable characters in ZK doc not in line with code

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Reid updated ZOOKEEPER-1628: Attachment: ZOOKEEPER-1628.patch Patch to resolve code and documentation issues. Also i

[jira] [Created] (ZOOKEEPER-1628) Documented list of allowable characters in ZK doc not in line with code

Gabriel Reid created ZOOKEEPER-1628: --- Summary: Documented list of allowable characters in ZK doc not in line with code Key: ZOOKEEPER-1628 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1628 P

[jira] [Commented] (ZOOKEEPER-1608) Add support for key-value store as optional storage engine

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561585#comment-13561585 ] Jacky007 commented on ZOOKEEPER-1608: - @Thawan Kooburat It's a great idea. In one

ZooKeeper-trunk-WinVS2008 - Build # 684 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/684/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 184 lines...] (zookeeper target) -> cl : Comman

ZooKeeper-trunk-solaris - Build # 449 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/449/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 163812 lines...] [junit] 2013-01-24 09:06:22,597

ZooKeeper-trunk-WinVS2008 - Build # 683 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/683/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 182 lines...] (zookeeper target) -> cl : Comman