Re: Review Request 12983: ZOOKEEPER-1691

No further suggestions, not even naming variables. Great job, congrats! I concur with Alex: ship it! Edward Em 21/08/2013 19:11, "Helen Hastings" escreveu: > > > > On Aug. 20, 2013, 2:31 a.m., Edward Ribeiro wrote: > > > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache

Re: Review Request 12983: ZOOKEEPER-1691

> On Aug. 20, 2013, 2:31 a.m., Edward Ribeiro wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java, > > line 402 > > > > > > Why did you ren

Re: Review Request 12983: ZOOKEEPER-1691

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12983/ --- (Updated Aug. 21, 2013, 10:11 p.m.) Review request for zookeeper and Alexander

Re: Review Request 12983: ZOOKEEPER-1691

> On Aug. 20, 2013, 12:39 a.m., Edward Ribeiro wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java, > > line 137 > > > > > > Please, remove those spac

[jira] [Updated] (ZOOKEEPER-1691) Add a flag to disable standalone mode

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Helen Hastings updated ZOOKEEPER-1691: -- Attachment: ZOOKEEPER-1691.patch Added more suggestions from ZK review board.

RE: Release schedule?

There are 21 issues currently marked for 3.4.6, 4 issues are blockers. I have poked some people on some of the jiras, but I'm not seeing a lot of responses. As usual, reviewing and working with contributors is a good way of making progress. I think most of the issues have some ongoing work already,

Re: Release schedule?

+1 - 3.4.6 is very much needed On Aug 21, 2013, at 9:47 AM, Camille Fournier wrote: > I feel like we've been dragging our feet on 3.4.6 and 3.5. Anything I can > do to help move things along? Should we try to set a date and push out what > we have at that time? > > Thanks, > C

[jira] [Commented] (ZOOKEEPER-580) Document reasonable limits on the size and shape of data for a zookeeper ensemble.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746558#comment-13746558 ] Jessica Cheng commented on ZOOKEEPER-580: - +1 > Document reaso

Release schedule?

I feel like we've been dragging our feet on 3.4.6 and 3.5. Anything I can do to help move things along? Should we try to set a date and push out what we have at that time? Thanks, C

[jira] [Created] (ZOOKEEPER-1743) Chocolatey package for automating Zookeeper installation in Windows

Andrew Pennebaker created ZOOKEEPER-1743: Summary: Chocolatey package for automating Zookeeper installation in Windows Key: ZOOKEEPER-1743 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1743

[jira] [Created] (ZOOKEEPER-1743) Chocolatey package for automating Zookeeper installation in Windows

Andrew Pennebaker created ZOOKEEPER-1743: Summary: Chocolatey package for automating Zookeeper installation in Windows Key: ZOOKEEPER-1743 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1743

[jira] [Created] (ZOOKEEPER-1742) "make check" doesn't work on macos

Flavio Junqueira created ZOOKEEPER-1742: --- Summary: "make check" doesn't work on macos Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Is

[jira] [Commented] (ZOOKEEPER-1734) Zookeeper fails to connect if one zookeeper host is down on EC2 when using elastic IP (UnknownHostException)

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746063#comment-13746063 ] Edward Ribeiro commented on ZOOKEEPER-1734: --- I suggest to put at least a "re

[jira] [Commented] (ZOOKEEPER-1400) Allow logging via callback instead of raw FILE pointer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745943#comment-13745943 ] Hudson commented on ZOOKEEPER-1400: --- SUCCESS: Integrated in ZooKeeper-trunk #2030 (S

[jira] [Commented] (ZOOKEEPER-1679) c client: use -Wdeclaration-after-statement

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745944#comment-13745944 ] Hudson commented on ZOOKEEPER-1679: --- SUCCESS: Integrated in ZooKeeper-trunk #2030 (S

ZooKeeper-trunk-solaris - Build # 648 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/648/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 195311 lines...] [junit] 2013-08-21 09:14:51,716

ZooKeeper-trunk-WinVS2008 - Build # 1003 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/1003/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 514 lines...] .\src\cli.c(402): error C2065: 'p