RE: Where are we in ZOOKEEPER-1416

2014-01-17 Thread 陈迪豪
Thanks all of you and Ted Yu really explain what I want. We should discuss more with Honghua to specify our requirement. ZK is the nice system for many recipes. if HBase uses it, we should use properly and reasonably. Moreover, this would help to develop zk in the best case ;-)

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Dutch T. Meyer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875539#comment-13875539 ] Dutch T. Meyer commented on ZOOKEEPER-1863: --- I think the server is wedged in

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875514#comment-13875514 ] Raul Gutierrez Segales commented on ZOOKEEPER-1863: --- Also, to clarif

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875503#comment-13875503 ] Raul Gutierrez Segales commented on ZOOKEEPER-1863: --- Oh, sorry about

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875496#comment-13875496 ] Raul Gutierrez Segales commented on ZOOKEEPER-1863: --- You should stil

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Dutch T. Meyer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875486#comment-13875486 ] Dutch T. Meyer commented on ZOOKEEPER-1863: --- Sorry about that. It's because

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875449#comment-13875449 ] Raul Gutierrez Segales commented on ZOOKEEPER-1863: --- [~dutch]: I can

[jira] [Updated] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Dutch T. Meyer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dutch T. Meyer updated ZOOKEEPER-1863: -- Attachment: stack.17512 Here is a trace of a server following a force of this bug u

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread Ted Yu
Thanks for the feedback, Kishore and Ted. Appreciate it. On Fri, Jan 17, 2014 at 2:41 PM, Ted Dunning wrote: > My reference here is to the comments a ways up thread. Kishore and I > clearly agree completely that idempotency and dealing with the state as it > is right now are the keys to corre

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread Ted Dunning
My reference here is to the comments a ways up thread. Kishore and I clearly agree completely that idempotency and dealing with the state as it is right now are the keys to correct design. On Fri, Jan 17, 2014 at 2:14 PM, Ted Dunning wrote: > > That comment indicates a lack of understanding of

Re: Wiki?

2014-01-17 Thread Patrick Hunt
I just checked the permission setup on our wiki space and currently only Ben and I are in the two groups "zookeeper-admin" and "zookeeper-committers". These two groups have edit permissions on the wiki. Everyone else who's logged in is considered a confluence-user - and they can only view pages. I

Re: Gui for zk

2014-01-17 Thread Patrick Hunt
+1 to what Anthony said. Please consider improving ZooInspector if it's lacking any functionality you require. Patrick On Mon, Jan 13, 2014 at 12:25 AM, Anthony Barré wrote: > There is a GUI for zk called zooinspector. This GUI is a bit slow. > I would suggest you to improve this project rather

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread Ted Dunning
That comment indicates a lack of understanding of ZK, not a bug in ZK. You don't lose state transitions if you read new state at the same time you set the new watch. Likewise, it is simply a product of bad design to have a problem with asynchronous notification. Changes on other machines *are* a

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread kishore g
I think its not a good idea to depend precise deltas, it is very difficult to program correctly and handle all corner cases. For example, what happens if the hbase master fails and by the time stand by becomes master there were other changes on ZK. The new Master will miss the changes that happened

[jira] [Commented] (ZOOKEEPER-442) need a way to remove watches that are no longer of interest

2014-01-17 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875309#comment-13875309 ] Patrick Hunt commented on ZOOKEEPER-442: My code review looks good. Great job -

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread Ted Yu
HBASE-5487 is also related. The discussion there is very long. Below is an excerpt from Honghua: too many tricky scenarios/bugs due to ZK watch is one-time(which can result in missed state transition) and the notification/process is asyncronous(which can lead to delayed/non-update-to-date state i

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread Ted Yu
Hi, Flavio: HBASE-8365 is one such case. Let me search around for other related discussion. On Fri, Jan 17, 2014 at 11:17 AM, Flavio Junqueira wrote: > Hi Ted, > > Can you provide more detail on how the precise deltas could make it more > robust? > > -Flavio > > -Original Message- > Fro

RE: Where are we in ZOOKEEPER-1416

2014-01-17 Thread Flavio Junqueira
Hi Ted, Can you provide more detail on how the precise deltas could make it more robust? -Flavio -Original Message- From: "Ted Yu" Sent: ‎17/‎01/‎2014 17:25 To: "dev@zookeeper.apache.org" Subject: Re: Where are we in ZOOKEEPER-1416 Having the ability to know exact deltas would help

Re: Review Request 12983: ZOOKEEPER-1691

2014-01-17 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12983/#review32168 --- http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/a

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Camille Fournier (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875063#comment-13875063 ] Camille Fournier commented on ZOOKEEPER-1863: - I will take a look at this

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Dutch T. Meyer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875054#comment-13875054 ] Dutch T. Meyer commented on ZOOKEEPER-1863: --- I will try, I'm not sure how di

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

2014-01-17 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875041#comment-13875041 ] Raul Gutierrez Segales commented on ZOOKEEPER-1863: --- I couldn't repr

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread Ted Yu
Having the ability to know exact deltas would help make HBase region assignment more robust. Cheers On Fri, Jan 17, 2014 at 9:13 AM, kishore g wrote: > I agree with you, I like the side effect and in fact I would prefer to have > one notification for all changes under a parent node. > > Howeve

[jira] [Commented] (BOOKKEEPER-710) OpenLedgerNoRecovery should watch ensemble change.

2014-01-17 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874964#comment-13874964 ] Ivan Kelly commented on BOOKKEEPER-710: --- Committed r1559192. I'd like to get rid

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread kishore g
I agree with you, I like the side effect and in fact I would prefer to have one notification for all changes under a parent node. However, Hao is probably asking for ability to know exact deltas. On Fri, Jan 17, 2014 at 8:15 AM, FPJ wrote: > We don't need to have a mapping between every change

RE: Where are we in ZOOKEEPER-1416

2014-01-17 Thread FPJ
We don't need to have a mapping between every change and a notification. If there are 2+ changes between notifications, you'll be able to observe it by reading the ZK state. In fact, one nice side-effect is that we reduce the number of notifications when there are many concurrent changes. The onl

Re: Where are we in ZOOKEEPER-1416

2014-01-17 Thread kishore g
I think Hao is pointing out that there is no way to see every change (delta) that happened to a znode. Consider 2 changes A,B in quick succession. When client gets notified of A and before setting the watch the change B has occurred on the server side. This means the client cannot know the delta A.

RE: Where are we in ZOOKEEPER-1416

2014-01-17 Thread FPJ
But you don't really miss events, you'll see them when you read the ZK state. If you follow the pattern I described, you're supposed to observe all changes. Perhaps I'm missing some concrete use case you have mind. -Flavio > -Original Message- > From: 陈迪豪 [mailto:chendi...@xiaomi.com] >

RE: Where are we in ZOOKEEPER-1416

2014-01-17 Thread 陈迪豪
No, it's not complicated. But for the people who don't understand zk deeply, they would easily ignore the fact that they would miss events in some way. Moreover, I think providing persistent watch is good for developers to build the "state-machine" application. Actually, HBase suffer from missin

RE: Where are we in ZOOKEEPER-1416

2014-01-17 Thread Flavio Junqueira
My take is that persistent subscriptions add complexity and are not strictly necessary. You can follow this pattern of setting a watch, reading the state upon a notification and setting a new watch. Why do you feel that's complicated? -Flavio -Original Message- From: 陈迪豪 [mailto:chendi...

[jira] [Commented] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

2014-01-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874663#comment-13874663 ] Hudson commented on ZOOKEEPER-1837: --- SUCCESS: Integrated in ZooKeeper-trunk #2188 (S

ZooKeeper-trunk-WinVS2008_java - Build # 657 - Still Failing

2014-01-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/657/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 257892 lines...] [junit] 2014-01-17 09:48

ZooKeeper-3.4-WinVS2008_java - Build # 411 - Still Failing

2014-01-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/411/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 169974 lines...] [junit] 2014-01-17 09:23:5

ZooKeeper-trunk-solaris - Build # 794 - Still Failing

2014-01-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/794/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 214205 lines...] [junit] 2014-01-17 09:08:09,720

ZooKeeper-trunk-ibm6 - Build # 398 - Failure

2014-01-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-ibm6/398/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 309357 lines...] [junit] 2014-01-17 09:08:05,740 [m