Re: [VOTE] Apache ZooKeeper release 3.5.1-alpha candidate 2

On 20 June 2015 at 17:07, Michi Mutsuzaki mutsuz...@gmail.com wrote: I updated https://issues.apache.org/jira/browse/ZOOKEEPER-2210 to address feedback from Chris. Could somebody take a look? Thanks! Merged - thanks! -rgs

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review88715 --- src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review88716 --- src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java

[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595276#comment-14595276 ] Raul Gutierrez Segales commented on ZOOKEEPER-2193: --- One last nit,

[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595272#comment-14595272 ] Raul Gutierrez Segales commented on ZOOKEEPER-2193: --- Patch lgtm, +1.

[jira] [Commented] (ZOOKEEPER-2210) clock_gettime is not available in os x

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595160#comment-14595160 ] Chris Nauroth commented on ZOOKEEPER-2210: -- +1 (non-binding). I retested