[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547752#comment-15547752 ] Rakesh R commented on ZOOKEEPER-1045: - Attached another patch in the [review ticke

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547736#comment-15547736 ] Rakesh R commented on ZOOKEEPER-1045: - Reg this point there was a discussion in th

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

> On Sept. 19, 2016, 7:21 p.m., Michael Han wrote: > > src/java/main/org/apache/zookeeper/server/quorum/Learner.java, line 248 > > > > > > This check seems redundant to me - when we are here we either already > > ha

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

> On Sept. 19, 2016, 11:52 p.m., Michael Han wrote: > > src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java, > > line 219 > > > > > > Should we put the check of in progress sid here, or up on the

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

> On Sept. 20, 2016, 10:24 p.m., Michael Han wrote: > > src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java, > > line 174 > > > > > > The implementation of this is an almost identical co

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

> On Sept. 27, 2016, 9:27 p.m., Michael Han wrote: > > src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java, > > line 131 > > > > > > Right, I think the key is sc.isComplete == true does

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

> On Sept. 20, 2016, 10:24 p.m., Michael Han wrote: > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 106 > > > > > > Should we move both ThreadPoolExecutor and inprogressConnections into >

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47354/ --- (Updated Oct. 5, 2016, 4:14 a.m.) Review request for zookeeper, fpj, Ivan Kelly

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47354/ --- (Updated Oct. 5, 2016, 4:10 a.m.) Review request for zookeeper, fpj, Ivan Kelly

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47354/ --- (Updated Oct. 5, 2016, 4:08 a.m.) Review request for zookeeper, fpj, Ivan Kelly

Re: [VOTE] move Apache Zookeeper to git

Hi, The patch attached on ZOOKEEPER-2597 is a ​straightforward adaptation of Kafka's one. It takes care of merging Github PR into Apache git repo and ​ a​ subsequent closing of the PR on the GH side ​ among other things (rewriting of commit messages, etc)​ . The current status is: the script need

Re: [VOTE] move Apache Zookeeper to git

>> as long as the opening/closing/commenting all get sent to the mailing list or recorded in jira Yeah, this is my impression as well, that we need to keep certain paper trail regarding activities and comments on ASF side (JIRA or mail list). Infra page said: - Any Pull Request that gets opened

Failed: ZOOKEEPER-2606 PreCommit Build #3464

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2606 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3464/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-2606) SaslServerCallbackHandler#handleAuthorizeCallback() should log the exception

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546671#comment-15546671 ] Hadoop QA commented on ZOOKEEPER-2606: -- -1 overall. Here are the results of test

Re: [VOTE] move Apache Zookeeper to git

Until ZOOKEEPER-2597 is fixed, we can't merge via github. For code reviews, we can use GH as long as the opening/closing/commenting all get sent to the mailing list or recorded in jira. I don't think we have that yet, but it is possible acc

Re: ZooKeeper clients does not handle new error codes properly

Yeah, unfortunately, I don't think we make use of the protocol version in ConnectRequest and Response. When we instantiate ConnectRequest in ClientCnxn, we simply set it to zero. -Flavio > On 04 Oct 2016, at 16:21, Mohammad arshad wrote: > > Thanks Benjamin Reed, > Client protocol version is

Re: [VOTE] move Apache Zookeeper to git

Hi, Now we've moved to git, what is the policy for uploading patches and doing code reviews? I am asking because I've seen recently there are git pull requests coming in without associated patch file uploaded to JIRA. I've checked https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribu

Re: ZooKeeper clients does not handle new error codes properly

Hi Arshad, I am curious where the IllegalArgumentException was thrown in code in your use case - I am asking because I spotted that in KeeperException.create, we have a default fall through [1] that throws IllegalArgumentException, and if this is not the place where you observed the IllegalArgumen

ZooKeeper_branch35_solaris - Build # 271 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/271/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 445009 lines...] [junit] at com.sun.secu

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545855#comment-15545855 ] Jordan Zimmerman commented on ZOOKEEPER-1525: - My PR is essentially the sa

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545650#comment-15545650 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- GitHub user Randgalt opened a p

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/84 [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth plugins Based on patch work from https://issues.apache.org/jira/browse/ZOOKEEPER-1525 Created ServerAuthenticationProvider which h

RE: ZooKeeper clients does not handle new error codes properly

Thanks Benjamin Reed, Client protocol version is 0, it is not changed. Also there is no logic executed at the server side based on the client protocol version. Increasing the client protocol version and converting the errors at server may be the ideal and more precise solution but to handle it i

Failed: ZOOKEEPER-1525 PreCommit Build #3463

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1525 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3463/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545543#comment-15545543 ] Hadoop QA commented on ZOOKEEPER-1525: -- -1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545521#comment-15545521 ] Jordan Zimmerman commented on ZOOKEEPER-1525: - This patch no longer applie

Re: Feature Proposal: Embedded (non network stack) connection option for embedded Zookeeper

Hi Enrico, I set up a github repo with just the 'embedded' connection classes. They unfortunately are from an older (3.4.6) release and would some clean up to fit into the current dev branch of Zookeeper. However feel free to have a look. Unfortunately there is a lot of code in there (just like i

[jira] [Updated] (ZOOKEEPER-2606) SaslServerCallbackHandler#handleAuthorizeCallback() should log the exception

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated ZOOKEEPER-2606: -- Attachment: ZOOKEEPER-2606.v1.patch > SaslServerCallbackHandler#handleAuthorizeCallback() should log

RE: ZooKeeper ping requests Unnecessarily go though request processor chain

Thanks Vitalii, Benjamin Reed for the response Makes sense to me. Got it, ping request is used not only for keeping the session alive but also for testing the request processing flow. Therefore the current processing flow for the ping is required. Just for Information: >> I am not sure why do yo

[jira] [Updated] (ZOOKEEPER-2606) SaslServerCallbackHandler#handleAuthorizeCallback() should log the exception

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated ZOOKEEPER-2606: -- Priority: Minor (was: Major) > SaslServerCallbackHandler#handleAuthorizeCallback() should log the e

ZooKeeper_branch34_solaris - Build # 1314 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1314/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment variab

[jira] [Created] (ZOOKEEPER-2606) SaslServerCallbackHandler#handleAuthorizeCallback() should log the exception

Ted Yu created ZOOKEEPER-2606: - Summary: SaslServerCallbackHandler#handleAuthorizeCallback() should log the exception Key: ZOOKEEPER-2606 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2606 Project:

ZooKeeper_branch35_jdk8 - Build # 253 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/253/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 484597 lines...] [junit] 2016-10-04 12:39:03,218

ZooKeeper_branch35_openjdk7 - Build # 251 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/251/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 474458 lines...] [junit] 2016-10-04 10:13:29

ZooKeeper-trunk-solaris - Build # 1334 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1334/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 173 lines...] [ivy:retrieve] found antlr#antlr;2.7