[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2017-05-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999307#comment-15999307 ] Hadoop QA commented on ZOOKEEPER-2778: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #667

2017-05-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/667/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.78 MB...] [exec]

[jira] [Updated] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

2017-05-05 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-1932: --- Description: org.apache.zookeeper.test.LETest.testLE is failing on trunk once in a while.

Success: ZOOKEEPER- PreCommit Build #666

2017-05-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/666/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.91 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999303#comment-15999303 ] ASF GitHub Bot commented on ZOOKEEPER-2778: --- Github user hanm closed the pull request at:

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999304#comment-15999304 ] ASF GitHub Bot commented on ZOOKEEPER-2778: --- GitHub user hanm reopened a pull request:

[GitHub] zookeeper pull request #247: ZOOKEEPER-2778: Potential server deadlock betwe...

2017-05-05 Thread hanm
GitHub user hanm reopened a pull request: https://github.com/apache/zookeeper/pull/247 ZOOKEEPER-2778: Potential server deadlock between follower sync with leader and follower receiving external connection requests. Remove synchronization requirements on certain methods to prevent

[GitHub] zookeeper pull request #247: ZOOKEEPER-2778: Potential server deadlock betwe...

2017-05-05 Thread hanm
Github user hanm closed the pull request at: https://github.com/apache/zookeeper/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2017-05-05 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-2778: --- Description: It's possible to have a deadlock during recovery phase. Found this issue by

[GitHub] zookeeper issue #247: Potential server deadlock between follower sync with l...

2017-05-05 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/247 @shralex please review :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zookeeper pull request #247: Potential server deadlock between follower sync...

2017-05-05 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/247#discussion_r115113555 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -682,27 +682,19 @@ public void setQuorumAddress(InetSocketAddress addr){

[GitHub] zookeeper pull request #247: Potential server deadlock between follower sync...

2017-05-05 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/247#discussion_r115113525 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -682,27 +682,19 @@ public void setQuorumAddress(InetSocketAddress addr){

ZooKeeper-trunk-WinVS2008 - Build # 2453 - Still Failing

2017-05-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2453/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer No JDK named ‘JDK 1.8 (unlimited security)

ZooKeeper-trunk-WinVS2008 - Build # 2454 - Still Failing

2017-05-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2454/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by an SCM change No JDK named ‘JDK 1.8 (unlimited

[GitHub] zookeeper pull request #247: Potential server deadlock between follower sync...

2017-05-05 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/247#discussion_r115113425 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -682,27 +682,19 @@ public void setQuorumAddress(InetSocketAddress addr){

[jira] [Commented] (ZOOKEEPER-2080) Fix deadlock in dynamic reconfiguration

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999296#comment-15999296 ] ASF GitHub Bot commented on ZOOKEEPER-2080: --- Github user hanm commented on a diff in the

[GitHub] zookeeper pull request #247: Potential server deadlock between follower sync...

2017-05-05 Thread hanm
GitHub user hanm opened a pull request: https://github.com/apache/zookeeper/pull/247 Potential server deadlock between follower sync with leader and follower receiving external connection requests. Remove synchronization requirements on certain methods to prevent dead lock.

[jira] [Created] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2017-05-05 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-2778: -- Summary: Potential server deadlock between follower sync with leader and follower receiving external connection requests. Key: ZOOKEEPER-2778 URL:

[jira] [Commented] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999247#comment-15999247 ] ASF GitHub Bot commented on ZOOKEEPER-1932: --- Github user arshadmohammad commented on a diff

[jira] [Commented] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999244#comment-15999244 ] ASF GitHub Bot commented on ZOOKEEPER-1932: --- Github user arshadmohammad commented on a diff

[jira] [Commented] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999248#comment-15999248 ] ASF GitHub Bot commented on ZOOKEEPER-1932: --- Github user arshadmohammad commented on a diff

[GitHub] zookeeper pull request #106: ZOOKEEPER-1932: Remove deprecated LeaderElectio...

2017-05-05 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/106#discussion_r115111872 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -948,15 +948,14 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #106: ZOOKEEPER-1932: Remove deprecated LeaderElectio...

2017-05-05 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/106#discussion_r115111914 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -930,39 +918,36 @@ protected Election

[GitHub] zookeeper pull request #106: ZOOKEEPER-1932: Remove deprecated LeaderElectio...

2017-05-05 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/106#discussion_r115111921 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -809,28 +809,16 @@ synchronized public void stopLeaderElection()

[GitHub] zookeeper pull request #106: ZOOKEEPER-1932: Remove deprecated LeaderElectio...

2017-05-05 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/106#discussion_r115112178 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -930,39 +918,36 @@ protected Election

[GitHub] zookeeper pull request #106: ZOOKEEPER-1932: Remove deprecated LeaderElectio...

2017-05-05 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/106#discussion_r115112169 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -930,39 +918,36 @@ protected Election

[jira] [Commented] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999245#comment-15999245 ] ASF GitHub Bot commented on ZOOKEEPER-1932: --- Github user arshadmohammad commented on a diff

[jira] [Commented] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999246#comment-15999246 ] ASF GitHub Bot commented on ZOOKEEPER-1932: --- Github user arshadmohammad commented on a diff

[jira] [Commented] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999236#comment-15999236 ] ASF GitHub Bot commented on ZOOKEEPER-1932: --- Github user arshadmohammad commented on the

[GitHub] zookeeper issue #106: ZOOKEEPER-1932: Remove deprecated LeaderElection class...

2017-05-05 Thread arshadmohammad
Github user arshadmohammad commented on the issue: https://github.com/apache/zookeeper/pull/106 Jira ZOOKEEPER-1932 title is completely different from what is being done in its MR. It think we should change the title as well as the description --- If your project is set up for it,

Re: Ever considered using buck to build?

2017-05-05 Thread Michael Han
>> I thought we were moving to Maven at some point. Did that get sidelined? I think moving to maven is still the plan and there are definitely lots of interests on this - see ZOOKEEPER-1078 On Fri, May 5, 2017 at 3:39 PM, Jordan Zimmerman

Re: Ever considered using buck to build?

2017-05-05 Thread Michael Han
Sounds reasonable. I think we need decide how BUCK participate in various workflows - for example does apache pre-build commit and daily build need to build with BUCK (in addition to building with ant), or not. I assume that's also why Camille mentioned Jenkins. On Fri, May 5, 2017 at 3:22 PM,

Re: Ever considered using buck to build?

2017-05-05 Thread Jordan Zimmerman
I thought we were moving to Maven at some point. Did that get sidelined? -Jordan > On May 5, 2017, at 6:02 PM, Michael Han wrote: > > Is this proposal intended to use BUCK to replace ant someday, or just add > BUCK as an alternative build system? I thought it's not replacing

Re: Ever considered using buck to build?

2017-05-05 Thread Patrick White
My intent at this point is not to replace anything, just to add the ability to build with buck. Maintaining multiple build systems is a pain for sure, but I'd wager the majority of the burden of buck maintenance would fall on Facebook since we're the primary users of it to build zookeeper at

Re: Ever considered using buck to build?

2017-05-05 Thread Michael Han
Is this proposal intended to use BUCK to replace ant someday, or just add BUCK as an alternative build system? I thought it's not replacing ant, but I want double check, because choosing a build system vs support multiple build system are different topics. On Fri, May 5, 2017 at 2:52 PM, Patrick

Re: Ever considered using buck to build?

2017-05-05 Thread Patrick White
My bad, I'll clarify. Internally, we build and test with buck, but we don't worry about the bin,conf,share,etc folders. So it's a thing that is possible (and I'll certainly do it if there's interest) we just haven't put effort behind it because... well we don't use it that way. re: jenkins.

Re: Ever considered using buck to build?

2017-05-05 Thread Camille Fournier
Did you... Just list as a con that actually it currently won't work? Does it work on Jenkins? On May 5, 2017 4:51 PM, "Patrick White" wrote: > Howdy! I'm Patrick from the core systems team at Facebook, and I work on > ZooKeeper and ZooKeeper accessories all day long. > >

Ever considered using buck to build?

2017-05-05 Thread Patrick White
Howdy! I'm Patrick from the core systems team at Facebook, and I work on ZooKeeper and ZooKeeper accessories all day long. Proposal: I want to add BUCK files to the zookeeper source tree. Hear me out: TL; DR - I want to hear everyone's thoughts and opinions on the matter. At Facebook, we

[jira] [Created] (ZOOKEEPER-2777) There is a typo in zk.py which prevents from using/compiling it.

2017-05-05 Thread Frederic Leger (JIRA)
Frederic Leger created ZOOKEEPER-2777: - Summary: There is a typo in zk.py which prevents from using/compiling it. Key: ZOOKEEPER-2777 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2777

ZooKeeper_branch35_openjdk7 - Build # 514 - Failure

2017-05-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/514/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 63.71 MB...] [junit] 2017-05-05

[jira] [Created] (ZOOKEEPER-2776) Election Failed when (medium id) node down

2017-05-05 Thread chenbo (JIRA)
chenbo created ZOOKEEPER-2776: - Summary: Election Failed when (medium id) node down Key: ZOOKEEPER-2776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2776 Project: ZooKeeper Issue Type:

[jira] [Commented] (ZOOKEEPER-2775) ZK Client not able to connect with Xid out of order error

2017-05-05 Thread Mohammad Arshad (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997846#comment-15997846 ] Mohammad Arshad commented on ZOOKEEPER-2775: This issue has been discussed many times,

[jira] [Created] (ZOOKEEPER-2775) ZK Client not able to connect with Xid out of order error

2017-05-05 Thread Bhupendra Kumar Jain (JIRA)
Bhupendra Kumar Jain created ZOOKEEPER-2775: --- Summary: ZK Client not able to connect with Xid out of order error Key: ZOOKEEPER-2775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2775