[VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-03-26 Thread Abraham Fine
This is a bugfix release candidate for 3.4.12. It fixes 22 issues, including issues that affect incorrect handling of the dataDir and the dataLogDir. This candidate fixes an issue in the release notes of candidate 0. The full release notes are available at:

ZooKeeper_branch34_openjdk7 - Build # 1861 - Still Failing

2018-03-26 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1861/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.70 KB...] [junit] Tests run: 1,

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414961#comment-16414961 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user LJ1043041006 commented on a diff in

[GitHub] zookeeper pull request #495: ZOOKEEPER-3007:Potential NPE in ReferenceCounte...

2018-03-26 Thread LJ1043041006
Github user LJ1043041006 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/495#discussion_r177296763 --- Diff: src/java/main/org/apache/zookeeper/server/ReferenceCountedACLCache.java --- @@ -109,16 +109,18 @@ public synchronized void

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Affects Version/s: 3.6.0 > Potential NPE: class NIOServerCnxn has two method can return null >

[jira] [Comment Edited] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414949#comment-16414949 ] lujie edited comment on ZOOKEEPER-3009 at 3/27/18 3:13 AM: --- Hi [~andorm]

[jira] [Comment Edited] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414949#comment-16414949 ] lujie edited comment on ZOOKEEPER-3009 at 3/27/18 3:12 AM: --- Hi [~andorm]

[jira] [Commented] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414949#comment-16414949 ] lujie commented on ZOOKEEPER-3009: -- Hi [~andorm] Thinks for your pertinent suggestions. I develop

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414935#comment-16414935 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user maoling commented on a diff in the

[GitHub] zookeeper pull request #495: ZOOKEEPER-3007:Potential NPE in ReferenceCounte...

2018-03-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/495#discussion_r177294282 --- Diff: src/java/main/org/apache/zookeeper/server/ReferenceCountedACLCache.java --- @@ -109,16 +109,18 @@ public synchronized void

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 0

2018-03-26 Thread Abraham Fine
Thank you everyone for your votes to far. Due to the issues that Michael Han pointed out I will cancel this RC and release a new one with the correct release notes. Expect the new RC very soon. Thanks, Abe On Mon, Mar 26, 2018, at 12:29, Patrick Hunt wrote: > +1 - sig/xsum verify, RAT looks

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 0

2018-03-26 Thread Patrick Hunt
+1 - sig/xsum verify, RAT looks ok, was able to build/test successfully under jdk7/mac. Tested out a few deployment combinations and it seemed ok. Manually verified swapping data and datalogdir resulted in the server not coming up and human readable error in the logs. Patrick On Thu, Mar 22,

[jira] [Updated] (ZOOKEEPER-2922) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest

2018-03-26 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated ZOOKEEPER-2922: Fix Version/s: (was: 3.4.12) > Flaky Test:

[jira] [Resolved] (ZOOKEEPER-2922) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest

2018-03-26 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine resolved ZOOKEEPER-2922. - Resolution: Won't Fix > Flaky Test: org.apache.zookeeper.test.LoadFromLogTest >

[jira] [Reopened] (ZOOKEEPER-2922) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest

2018-03-26 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine reopened ZOOKEEPER-2922: - Assignee: Abraham Fine (was: Andor Molnar) Sould be "Won't Fix" > Flaky Test:

[jira] [Updated] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

2018-03-26 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated ZOOKEEPER-2980: Fix Version/s: (was: 3.4.12) > Backport ZOOKEEPER-2939 Deal with maxbuffer as it

[jira] [Resolved] (ZOOKEEPER-2806) Flaky test: org.apache.zookeeper.server.quorum.FLEBackwardElectionRoundTest.testBackwardElectionRound

2018-03-26 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine resolved ZOOKEEPER-2806. - Resolution: Fixed Fix Version/s: 3.4.12 3.6.0

[jira] [Updated] (ZOOKEEPER-2948) Failing c unit tests on apache jenkins

2018-03-26 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated ZOOKEEPER-2948: Fix Version/s: 3.4.12 > Failing c unit tests on apache jenkins >

Success: ZOOKEEPER- PreCommit Build #1554

2018-03-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1554/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.18 MB...] [exec]

ZooKeeper_branch34_openjdk7 - Build # 1860 - Failure

2018-03-26 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1860/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.51 KB...] [junit] Tests run: 1,

Failed: ZOOKEEPER- PreCommit Build #1553

2018-03-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1553/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.47 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #1552

2018-03-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1552/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.49 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413879#comment-16413879 ] Andor Molnar commented on ZOOKEEPER-3009: - Hi [~xiaoheipangzi] Thanks for the nice

Success: ZOOKEEPER- PreCommit Build #1551

2018-03-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1551/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.78 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413851#comment-16413851 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user LJ1043041006 commented on a diff in

[jira] [Commented] (ZOOKEEPER-2101) Transaction larger than max buffer of jute makes zookeeper unavailable

2018-03-26 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413850#comment-16413850 ] Andor Molnar commented on ZOOKEEPER-2101: - Closing due to lack of response/interest. >

[jira] [Resolved] (ZOOKEEPER-2101) Transaction larger than max buffer of jute makes zookeeper unavailable

2018-03-26 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2101. - Resolution: Cannot Reproduce > Transaction larger than max buffer of jute makes

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413834#comment-16413834 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- GitHub user brettKK opened a pull request:

[GitHub] zookeeper pull request #494: xx

2018-03-26 Thread brettKK
Github user brettKK closed the pull request at: https://github.com/apache/zookeeper/pull/494 ---

[GitHub] zookeeper pull request #495: ZOOKEEPER-3007:Potential NPE in ReferenceCounte...

2018-03-26 Thread LJ1043041006
Github user LJ1043041006 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/495#discussion_r177089527 --- Diff: src/java/main/org/apache/zookeeper/server/ReferenceCountedACLCache.java --- @@ -109,16 +109,18 @@ public synchronized void

[GitHub] zookeeper pull request #495: ZOOKEEPER-3007:Potential NPE in ReferenceCounte...

2018-03-26 Thread brettKK
GitHub user brettKK opened a pull request: https://github.com/apache/zookeeper/pull/495 ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCache#deserialize @LJ1043041006 found a potential NPE in ZK callee BinaryInputArchive#startVector will return null: ``` //

[jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413661#comment-16413661 ] ASF GitHub Bot commented on ZOOKEEPER-3000: --- Github user leventov commented on the issue:

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: Inspire by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: After ZK-3006 , I develop a simple static analysis tool to find other Potential NPE

Failed: ZOOKEEPER- PreCommit Build #1550

2018-03-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1550/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 26.19 KB...] Auto-merging

[jira] [Commented] (ZOOKEEPER-2999) CMake build should use target-level commands

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413728#comment-16413728 ] ASF GitHub Bot commented on ZOOKEEPER-2999: --- Github user anmolnar commented on the issue:

[jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413658#comment-16413658 ] ASF GitHub Bot commented on ZOOKEEPER-3000: --- Github user leventov commented on a diff in the

[jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413622#comment-16413622 ] ASF GitHub Bot commented on ZOOKEEPER-3000: --- Github user anmolnar commented on the issue:

[jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413666#comment-16413666 ] ASF GitHub Bot commented on ZOOKEEPER-3000: --- Github user anmolnar commented on the issue:

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 0

2018-03-26 Thread Andor Molnar
Hi Abe, Thanks for putting this important release together. +1 I've run the following tests: - verified signatures, - all unit tests passed on Mac (java only) and Ubuntu 16.04 (java & c++ successful), - tested standalone and 3-node cluster, - verified the fix & validation of datadir/logdir

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3010) Potential NPE in Observer#observeLeader and Follower#followLeader

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3010: - Description: Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: Inspired by ZK-3006, I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3010) Potential NPE in Observer#observeLeader and Follower#followLeader

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3010: - Description: Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3011: - Description: After ZK-3006 , I develop a simple static analysis tool to find other Potential NPE

[jira] [Updated] (ZOOKEEPER-3010) Potential NPE in Observer#observeLeader and Follower#followLeader

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3010: - Description: After ZK-3006 , I develop a simple static analysis tool to find other Potential NPE

[jira] [Updated] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3011: - Description: Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: After ZK-3006 , I develop a simple static analysis tool to find other Potential NPE

ZooKeeper_branch35_jdk8 - Build # 897 - Failure

2018-03-26 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/897/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.54 KB...] [junit] Running

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After ZK-3006 , I develop a simple static analysis tool to find other Potential NPE

[GitHub] zookeeper pull request #494: Branch 3.5

2018-03-26 Thread brettKK
GitHub user brettKK opened a pull request: https://github.com/apache/zookeeper/pull/494 Branch 3.5 callee BinaryInputArchive#startVector will return null: ``` // code placeholder public Index startVector(String tag) throws IOException { int len = readInt(tag);

[GitHub] zookeeper issue #486: ZOOKEEPER-2999: CMake build should use target-level co...

2018-03-26 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/486 @andschwa try to trigger another build with amend commit Those are probably just flaky tests. ---

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

2018-03-26 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/490 @leventov Got that, however my issue still stands: why `ant test` command doesn't compile with java7? Is it just me who experience it? Have you tested the patch with java7? ---

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

2018-03-26 Thread leventov
Github user leventov commented on the issue: https://github.com/apache/zookeeper/pull/490 @anmolnar see http://errorprone.info/docs/installation, the first paragraph: "Please note that Error Prone must be run on JDK 8 or newer. It can be used to build Java 6 or 7 code by setting the

[GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler

2018-03-26 Thread leventov
Github user leventov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/490#discussion_r177043995 --- Diff: src/java/test/org/apache/zookeeper/test/AsyncHammerTest.java --- @@ -61,6 +61,7 @@ protected void restart() throws Exception {

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

2018-03-26 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/490 @leventov I've just verified your patch on my local machine. Is Java8 a requirement for error-prone to work? Because running `ant clean test` with java7 I got the following error

[jira] [Updated] (ZOOKEEPER-3010) Potential NPE in Observer#observeLeader and Follower#followLeader

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3010: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3011: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

Re: Let's cut a ZK 3.5.4-beta release

2018-03-26 Thread Andor Molnar
I'm currently working on ZOOKEEPER-2184. PR has been open for ages on 3.4 branch, please review if you have some capacity. I'll port the fix to the 3.5 branch too, if we have an agreement and 3.4-version is merged. ZK-2982 is somewhat related, I believe my changes will fix that one too. ZK-1818

[jira] [Updated] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3011: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3011: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413558#comment-16413558 ] ASF GitHub Bot commented on ZOOKEEPER-3006: --- Github user LJ1043041006 commented on the

[jira] [Updated] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3011: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3011: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

2018-03-26 Thread LJ1043041006
Github user LJ1043041006 commented on the issue: https://github.com/apache/zookeeper/pull/493 Hi guys, **one more thing** I have developed a very simple tool to find Potential NPE in Zookeeper(based on [WALA](https://github.com/wala/WALA)), I list the result in ZK-3007~3010

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3010) Potential NPE in Observer#observeLeader and Follower#followLeader

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3010: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Created] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
lujie created ZOOKEEPER-3011: Summary: Some NPEs, maybe Key: ZOOKEEPER-3011 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3011 Project: ZooKeeper Issue Type: Bug Affects Versions:

[jira] [Updated] (ZOOKEEPER-3011) Some NPEs, maybe

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3011: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3010) Potential NPE in Observer#observeLeader and Follower#followLeader

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3010: - Environment:     was:   {code:java} static code analysis{code}     > Potential NPE in

[jira] [Created] (ZOOKEEPER-3010) Potential NPE in Observer#observeLeader and Follower#followLeader

2018-03-26 Thread lujie (JIRA)
lujie created ZOOKEEPER-3010: Summary: Potential NPE in Observer#observeLeader and Follower#followLeader Key: ZOOKEEPER-3010 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3010 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has three method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Summary: Potential NPE: class NIOServerCnxn has two method can return null (was: Potential NPE:

[jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has three method can return null

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3009: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Created] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has three method can return null

2018-03-26 Thread lujie (JIRA)
lujie created ZOOKEEPER-3009: Summary: Potential NPE: class NIOServerCnxn has three method can return null Key: ZOOKEEPER-3009 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3009 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Created] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
lujie created ZOOKEEPER-3008: Summary: Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate Key: ZOOKEEPER-3008 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3008

[jira] [Updated] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3008: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: AfterZK-3006, I develop a very simple static analysis tool to find other other

[jira] [Created] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
lujie created ZOOKEEPER-3007: Summary: Potential NPE in ReferenceCountedACLCache#deserialize Key: ZOOKEEPER-3007 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3007 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After [ZK-3006|https://issues.apache.org/jira/browse/ZOOKEEPER-3006] , I develop a very

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other Potential

[jira] [Updated] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-03-26 Thread lujie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3007: - Description: After ZK-3006 , I develop a very simple static analysis tool to find other other

  1   2   >