Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-04 Thread Matteo Merli
That is correct, there are only a few transaction so the snapshot has not been triggered yet. The question is more on how to plan for seamless upgrade, from 3.4.10 to 3.5.x, from an end users perspective. On Mon, Jun 4, 2018 at 11:15 PM Michael Han wrote: > Hi Matteo, > > Maybe your ZK instance

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-04 Thread Michael Han
Hi Matteo, Maybe your ZK instance did not take a snapshot at all - it's possible if your total number of transactions less than the configured snapCount (default value is 1) at the time you are doing upgrade. You could check your transaction log file and the snapCount configuration see if this

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-04 Thread Matteo Merli
> >> Also can you advice the steps for people who using 3.4.x to upgrade to > 3.5.4-beta > > The only catch I remember is that if you are using a version older than > 3.4.6, you'd need to upgrade through 3.4.6 first before upgrading to 3.5.x, > if you are doing a rolling upgrade and want to keep th

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-04 Thread Michael Han
Hi Sijie, >> I am just curious why the change was made in such way. It's a safety guarantee. Consider this case: * An ensemble of server A, B, and C. A and B have most up to date transactions (let's say zxid + 1) while C is lagging one transaction behind (C has zxid). A is the current leader. *

ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-04 Thread Sijie Guo
Hi zookeeper team, We hit an issue when upgrading from 3.4.x to 3.5.4-beta. Need some helps/advices from the community. ``` *10:14:55.607 [main] INFO org.apache.zookeeper.server.NIOServerCnxnFactory - binding to port 0.0.0.0/0.0.0.0:2181 * *10:14:55.623 [main] ERROR

Success: ZOOKEEPER- PreCommit Build #1789

2018-06-04 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1789/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.39 MB...] [exec] +1 @aut

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

2018-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500128#comment-16500128 ] Hadoop QA commented on ZOOKEEPER-2184: -- +1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #1788

2018-06-04 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1788/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84.92 MB...] [exec] [exec

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

2018-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500057#comment-16500057 ] Hadoop QA commented on ZOOKEEPER-2184: -- -1 overall. GitHub Pull Request Build

Success: ZOOKEEPER- PreCommit Build #1787

2018-06-04 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1787/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 83.05 MB...] [exec] +1 @aut

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

2018-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500027#comment-16500027 ] Hadoop QA commented on ZOOKEEPER-2184: -- +1 overall. GitHub Pull Request Build

[GitHub] zookeeper pull request #534: ZOOKEEPER-2184 Zookeeper Client should re-resol...

2018-06-04 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/534#discussion_r192696652 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -96,36 +115,46 @@ public StaticHostProvider(Collection serverAddresse

[GitHub] zookeeper pull request #534: ZOOKEEPER-2184 Zookeeper Client should re-resol...

2018-06-04 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/534#discussion_r192694788 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -314,7 +340,7 @@ public InetSocketAddress next(long spinDelay) {

[GitHub] zookeeper pull request #534: ZOOKEEPER-2184 Zookeeper Client should re-resol...

2018-06-04 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/534#discussion_r192694235 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -73,15 +80,27 @@ * if serverAddresses is empty o

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

2018-06-04 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @hanm Thanks, I updated the comments to be consistent with the original PR. Unfortunately the comment of `HostProvider` wasn't updated, so I also made changes in there. ---

Success: ZOOKEEPER- PreCommit Build #1785

2018-06-04 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1785/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 35.75 MB...] [exec] +1 @aut

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500012#comment-16500012 ] Hadoop QA commented on ZOOKEEPER-3019: -- +1 overall. GitHub Pull Request Build

[GitHub] zookeeper issue #533: ZOOKEEPER-2989:IPv6 literal address causes problems fo...

2018-06-04 Thread nkalmar
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/533 I agree with @anmolnar in that the methods are a little robust and test multiple things. Whether it should be refactored whenever we touch a unit test, that's a tough question. But I als

Success: ZOOKEEPER- PreCommit Build #1786

2018-06-04 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1786/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.34 MB...] [exec] +1 @aut

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499989#comment-16499989 ] Hadoop QA commented on ZOOKEEPER-3019: -- +1 overall. GitHub Pull Request Build

[jira] [Commented] (ZOOKEEPER-3040) flaky test EphemeralNodeDeletionTest

2018-06-04 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499959#comment-16499959 ] Norbert Kalmar commented on ZOOKEEPER-3040: --- Yes, I was afraid you were gon

Failed: ZOOKEEPER- PreCommit Build #1784

2018-06-04 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1784/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.13 MB...] [exec] [exec

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-06-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499949#comment-16499949 ] Hadoop QA commented on ZOOKEEPER-3019: -- -1 overall. GitHub Pull Request Build

[GitHub] zookeeper pull request #510: ZOOKEEPER-3019 add metric for slow fsyncs count

2018-06-04 Thread nkalmar
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/510#discussion_r192668700 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -320,6 +332,11 @@ public synchronized void commit() throws IOExcept