[
https://issues.apache.org/jira/browse/ZOOKEEPER-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623158#comment-16623158
]
Enrico Olivelli commented on ZOOKEEPER-3152:
Great !
Last year I was dis
Ilya Maykov created ZOOKEEPER-3152:
--
Summary: Port ZK netty stack to netty 4
Key: ZOOKEEPER-3152
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3152
Project: ZooKeeper
Issue Type: Impr
Thanks Enrico for volunteering, it'll be cool if we can fix this.
On Wed, Sep 19, 2018 at 10:42 PM, Enrico Olivelli
wrote:
> Il gio 20 set 2018, 01:17 Michael Han ha scritto:
>
> > We've seen lots of confusions recently around Jenkins pre-commit check
> > status on github pull request as well a
See https://builds.apache.org/job/ZooKeeper-trunk/198/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 146.52 KB...]
[junit] Tests run: 1, Failures: 0, Errors:
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/629#discussion_r219308398
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -53,10 +53,11 @@ public ServerStats(Provider provider) {
synchronize
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622650#comment-16622650
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/590
@anmolnar Thanks for reviewing, take your time.
Here are the main differences between this version and the old one on the
Jira:
1. use path to watchers map instead of watcher t
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2217/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.47 MB...]
[exec]
[exec
Github user dineshappavoo commented on the issue:
https://github.com/apache/zookeeper/pull/630
LGTM. ð
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2216/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 75.57 MB...]
[exec]
[exec
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622553#comment-16622553
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2944/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 9.74 KB...]
[ivy:retrieve] confs: [javacc]
[
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622522#comment-16622522
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2215/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.79 MB...]
[exec]
[exec
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622374#comment-16622374
]
Andrew Schwartzmeyer commented on ZOOKEEPER-2844:
-
Sorry [~maoling] I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622321#comment-16622321
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2214/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 81.89 MB...]
[exec]
[exec
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622244#comment-16622244
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2213/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 76.15 MB...]
[exec]
[exec
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1667#comment-1667
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2212/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 74.74 MB...]
[exec]
[exec
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2211/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 75.59 MB...]
[exec]
[exec
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622190#comment-16622190
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622148#comment-16622148
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2210/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 66.52 MB...]
[exec] +1 test
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/633
It is preserved, I double checked that. I also read multiple articles on
the topic, there was a good one, which I can't find anymore...
The points was the ones I wrote - mainly, github web
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/630#discussion_r219151901
--- Diff: src/java/test/org/apache/zookeeper/ZKUtilTest.java ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/630#discussion_r219150200
--- Diff: src/java/test/org/apache/zookeeper/ZKUtilTest.java ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1125/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 63.07 KB...]
[junit] Running org.apache.zookeep
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/590
@lvfangmin Just to wrap up the difference between this and original
6-year-old patch on Jira: you've added `deadWatchers` collection and lazy
`WatcherCleaner` to avoid the performance penalty on
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/61/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 17.90 KB...]
at hudson.scm.SCM.checkout(S
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/590
@lvfangmin Thanks. Sorry for the delay. I'd like to check one more thing
before accepting. Bear with me please.
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/622#discussion_r219104953
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -1861,6 +1862,76 @@ public void testFaultyMetricsProviderOnConf
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/622#discussion_r219104769
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -1861,6 +1862,76 @@ public void testFaultyMetricsProviderOnConf
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/605
@lvfangmin Errm. I would be happy to do that, but not sure how to. The
merge script is able to cherrry-pick in the middle of the process, but I cannot
start it over without a pull request. Again,
35 matches
Mail list logo
