[GitHub] eolivelli commented on a change in pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat

2019-01-25 Thread GitBox
eolivelli commented on a change in pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat URL: https://github.com/apache/zookeeper/pull/789#discussion_r251191572 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ## @@

Re: MetricsProvider..time to start?

2019-01-25 Thread Enrico Olivelli
Il giorno sab 26 gen 2019, 01:09 Brian Nixon ha scritto: > Hi Enrico, > > Most of the major remaining contributions from the Facebook engineers > around metrics are captured in > https://issues.apache.org/jira/browse/ZOOKEEPER-3245 and our attention is > still focused on upstreaming that and

Re: MetricsProvider..time to start?

2019-01-25 Thread Brian Nixon
Hi Enrico, Most of the major remaining contributions from the Facebook engineers around metrics are captured in https://issues.apache.org/jira/browse/ZOOKEEPER-3245 and our attention is still focused on upstreaming that and other work. We'd like to see the metrics provider work move forward

[jira] [Updated] (ZOOKEEPER-3257) Merge count and byte update of Stat

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3257: -- Labels: pull-request-available (was: ) > Merge count and byte update of Stat >

[GitHub] enixon opened a new pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat

2019-01-25 Thread GitBox
enixon opened a new pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat URL: https://github.com/apache/zookeeper/pull/789 This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (ZOOKEEPER-3257) Merge count and byte update of Stat

2019-01-25 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3257: -- Summary: Merge count and byte update of Stat Key: ZOOKEEPER-3257 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3257 Project: ZooKeeper Issue

[jira] [Commented] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752744#comment-16752744 ] Enrico Olivelli commented on ZOOKEEPER-3256: interesting that this CVE is against

[jira] [Commented] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752730#comment-16752730 ] Enrico Olivelli commented on ZOOKEEPER-3256: while executing ant task I am seeing

[jira] [Commented] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752742#comment-16752742 ] Enrico Olivelli commented on ZOOKEEPER-3256: [~andorm] [~phunt] [~nkalmar]   I will

[jira] [Commented] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752736#comment-16752736 ] Enrico Olivelli commented on ZOOKEEPER-3256: This is the result of the Maven version:

[GitHub] athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251152973 ## File path:

[jira] [Comment Edited] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752730#comment-16752730 ] Enrico Olivelli edited comment on ZOOKEEPER-3256 at 1/25/19 10:11 PM:

[GitHub] eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251150647 ## File path:

[GitHub] eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251150405 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java

[jira] [Updated] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3256: --- Description: Port OWASP check task to the Maven build, the suppressionsFile is

[GitHub] eolivelli commented on issue #788: ZOOKEEPER-3256: Enable OWASP checks to Maven build

2019-01-25 Thread GitBox
eolivelli commented on issue #788: ZOOKEEPER-3256: Enable OWASP checks to Maven build URL: https://github.com/apache/zookeeper/pull/788#issuecomment-457744846 @anmolnar @nkalmar this patch is currenaly a WIP because on my laptop the check is failing with: [ERROR] Failed to execute

[GitHub] eolivelli opened a new pull request #788: ZOOKEEPER-3256: Enable OWASP checks to Maven build

2019-01-25 Thread GitBox
eolivelli opened a new pull request #788: ZOOKEEPER-3256: Enable OWASP checks to Maven build URL: https://github.com/apache/zookeeper/pull/788 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3256: -- Labels: pull-request-available (was: ) > Enable OWASP checks to Maven build >

[jira] [Updated] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3256: --- Description: Port OWASP check task to the Maven build, the suppressionsFile is

[jira] [Updated] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3256: --- Description: Port OWASP check task to the Maven build, the suppressionsFile is

[jira] [Updated] (ZOOKEEPER-3256) Enable OWASP checks to Maven build

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3256: --- Summary: Enable OWASP checks to Maven build (was: Enable OWASP checks to

[jira] [Created] (ZOOKEEPER-3256) Enable OWASP checks to Maven

2019-01-25 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3256: -- Summary: Enable OWASP checks to Maven Key: ZOOKEEPER-3256 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3256 Project: ZooKeeper Issue

[GitHub] athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251145160 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java

[GitHub] eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251143313 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java

[GitHub] athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251141069 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java

[jira] [Updated] (ZOOKEEPER-3253) client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3253: --- Affects Version/s: (was: 4.0.0) 3.6.0

[GitHub] athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251140151 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java

[jira] [Updated] (ZOOKEEPER-3253) client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3253: --- Fix Version/s: (was: 4.0.0) 3.6.0 > client should not

[GitHub] eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251139004 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java

[GitHub] athanatos commented on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
athanatos commented on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#issuecomment-457724146 Yeah, I've got the 3.4 one ready, 3.5 presumably also easy.

[GitHub] eolivelli commented on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
eolivelli commented on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#issuecomment-457723646 Interesting. Are you interested in a back port to 3.4, 3.5?

[GitHub] athanatos opened a new pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread GitBox
athanatos opened a new pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787 - Add test for cxid rollover to 1 - Modify ClientCnxn.SendThread.getXid() to increment from -5 to 1.

[jira] [Updated] (ZOOKEEPER-3253) client should not send requests with cxid=-4, -2, or -1

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3253: -- Labels: pull-request-available (was: ) > client should not send requests with

ZooKeeper_branch34_openjdk7 - Build # 2191 - Still Failing

2019-01-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2191/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.72 KB...] hudson.plugins.git.GitException:

[jira] [Assigned] (ZOOKEEPER-3160) Custom User SSLContext

2019-01-25 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3160: --- Assignee: Andor Molnar > Custom User SSLContext > -- > >

[jira] [Assigned] (ZOOKEEPER-3160) Custom User SSLContext

2019-01-25 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3160: --- Assignee: Alex Rankin (was: Andor Molnar) > Custom User SSLContext >

[jira] [Commented] (ZOOKEEPER-3160) Custom User SSLContext

2019-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752488#comment-16752488 ] Hudson commented on ZOOKEEPER-3160: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #367 (See

[jira] [Commented] (ZOOKEEPER-3229) [TLS] add AES-256 ciphers to default cipher list

2019-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752489#comment-16752489 ] Hudson commented on ZOOKEEPER-3229: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #367 (See

[jira] [Commented] (ZOOKEEPER-3160) Custom User SSLContext

2019-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752449#comment-16752449 ] Hudson commented on ZOOKEEPER-3160: --- SUCCESS: Integrated in Jenkins build

[jira] [Commented] (ZOOKEEPER-3229) [TLS] add AES-256 ciphers to default cipher list

2019-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752450#comment-16752450 ] Hudson commented on ZOOKEEPER-3229: --- SUCCESS: Integrated in Jenkins build

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-25 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-457576254 > @arankin-irl You should be assigned to the Jira. > Would you please share your Jira username and I can add it to the contributors list

[jira] [Resolved] (ZOOKEEPER-3229) [TLS] add AES-256 ciphers to default cipher list

2019-01-25 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3229. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue

[GitHub] anmolnar commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list

2019-01-25 Thread GitBox
anmolnar commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list URL: https://github.com/apache/zookeeper/pull/744#issuecomment-457575218 Committed to master and 3.5 branches. Thanks @ivmaykov !

[GitHub] asfgit closed pull request #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list

2019-01-25 Thread GitBox
asfgit closed pull request #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list URL: https://github.com/apache/zookeeper/pull/744 This is an automated message from the Apache Git Service. To respond to the

[GitHub] anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-25 Thread GitBox
anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-457574126 @arankin-irl You should be assigned to the Jira. Would you please share your Jira username and I can add it to the contributors list and

[jira] [Resolved] (ZOOKEEPER-3160) Custom User SSLContext

2019-01-25 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3160. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 728

[GitHub] anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-25 Thread GitBox
anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-457573787 Committed to master branch. Thanks @arankin-irl ! This is an automated

[GitHub] asfgit closed pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-25 Thread GitBox
asfgit closed pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-25 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-457545935 @ivmaykov @anmolnar - PR has been updated to resolve merge conflicts. I've removed the Null SSLContext test, as the SSLContextOptions now

[jira] [Commented] (ZOOKEEPER-3211) zookeeper standalone mode,found a high level bug in kernel of centos7.0 ,zookeeper Server's tcp/ip socket connections(default 60 ) are CLOSE_WAIT ,this lead to zk

2019-01-25 Thread yeshuangshuang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752066#comment-16752066 ] yeshuangshuang commented on ZOOKEEPER-3211: --- maoling Using the jstack tool to check, no

Build failed in Jenkins: ZooKeeper-trunk-owasp #247

2019-01-25 Thread Apache Jenkins Server
See Changes: [andor] ZOOKEEPER-3176: Quorum TLS - add SSL config options -- [...truncated 14.66 KB...] [ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper