[GitHub] asdf2014 commented on issue #298: ZOOKEEPER-2826: Code refactoring for `CLI` module

asdf2014 commented on issue #298: ZOOKEEPER-2826: Code refactoring for `CLI` module URL: https://github.com/apache/zookeeper/pull/298#issuecomment-459250048 @anmolnar Done. This is an automated message from the Apache Git Ser

[GitHub] asdf2014 commented on issue #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLIE

asdf2014 commented on issue #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLIENT module URL: https://github.com/apache/zookeeper/pull/297#issuecomment-459250031 @anmolnar Done.

[GitHub] tamaashu commented on issue #395: ZOOKEEPER-2630: Use interface type instead of implementation type whe…

tamaashu commented on issue #395: ZOOKEEPER-2630: Use interface type instead of implementation type whe… URL: https://github.com/apache/zookeeper/pull/395#issuecomment-459241478 @anmolnar I'm fine with it. This is an automate

[GitHub] arshadmohammad commented on a change in pull request #324: ZOOKEEPER-2843: auth_to_local now supports reading rules from a file

arshadmohammad commented on a change in pull request #324: ZOOKEEPER-2843: auth_to_local now supports reading rules from a file URL: https://github.com/apache/zookeeper/pull/324#discussion_r252541655 ## File path: src/java/main/org/apache/zookeeper/server/auth/KerberosName.java ###

[jira] [Commented] (ZOOKEEPER-2843) auth_to_local should support reading rules from a file

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756891#comment-16756891 ] Mohammad Arshad commented on ZOOKEEPER-2843: security.auth_to_local can a

[jira] [Created] (ZOOKEEPER-3264) Add a benchmark tool for zookeeper

maoling created ZOOKEEPER-3264: -- Summary: Add a benchmark tool for zookeeper Key: ZOOKEEPER-3264 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3264 Project: ZooKeeper Issue Type: New Feat

[GitHub] asdf2014 commented on issue #298: ZOOKEEPER-2826: Code refactoring for `CLI` module

asdf2014 commented on issue #298: ZOOKEEPER-2826: Code refactoring for `CLI` module URL: https://github.com/apache/zookeeper/pull/298#issuecomment-459190871 @anmolnar Yep, I will work on it later. This is an automated message

[GitHub] maoling closed pull request #790: ZOOKEEPER-3167:add an API and the corresponding CLI to get total count of recursive sub nodes under a specific path

maoling closed pull request #790: ZOOKEEPER-3167:add an API and the corresponding CLI to get total count of recursive sub nodes under a specific path URL: https://github.com/apache/zookeeper/pull/790 This is an automated me

[GitHub] maoling opened a new pull request #790: ZOOKEEPER-3167:add an API and the corresponding CLI to get total count of recursive sub nodes under a specific path

maoling opened a new pull request #790: ZOOKEEPER-3167:add an API and the corresponding CLI to get total count of recursive sub nodes under a specific path URL: https://github.com/apache/zookeeper/pull/790 - Thanks the original patch from [TyqITstudent ](https://github.com/TyqITstudent).

[GitHub] asdf2014 commented on issue #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLIE

asdf2014 commented on issue #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLIENT module URL: https://github.com/apache/zookeeper/pull/297#issuecomment-459187562 @anmolnar Sure,

[GitHub] maoling commented on issue #790: ZOOKEEPER-3167:add an API and the corresponding CLI to get total count of recursive sub nodes under a specific path

maoling commented on issue #790: ZOOKEEPER-3167:add an API and the corresponding CLI to get total count of recursive sub nodes under a specific path URL: https://github.com/apache/zookeeper/pull/790#issuecomment-459184771 retest this please

[GitHub] maoling commented on issue #530: [ZOOKEEPER-2474] Support session reconnection when using ZKClientConfig

maoling commented on issue #530: [ZOOKEEPER-2474] Support session reconnection when using ZKClientConfig URL: https://github.com/apache/zookeeper/pull/530#issuecomment-459182901 I'am familiar with this patch.if no objections, I can pick up :D ---

[jira] [Created] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil

Pradeep Bansal created ZOOKEEPER-3263: - Summary: Illegal reflective access in zookeer's kerberosUtil Key: ZOOKEEPER-3263 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263 Project: ZooKeeper

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-459159366 Thanks guys, fixing them now. Also adding @lvfangmin to developers, using his public git profile to fill out the informations n

Re: OWASP task failing again ! but is CI lying ?

On Wed, Jan 30, 2019 at 3:13 PM Enrico Olivelli wrote: > Il giorno mer 30 gen 2019, 21:41 Patrick Hunt ha > scritto: > > > Note the owasp job has been failing since the upgrade to dependency > checker > > 4 due to > > "Target "dependency-check-update" does not exist in the project > > "ZooKeeper

[GitHub] joshelser commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba…

joshelser commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba… URL: https://github.com/apache/zookeeper/pull/784#issuecomment-459151051 Another force-push to fix the merge conflict (rebased) and fix a rendering issue with the changes to zookeeperA

Failed: ZOOKEEPER-2474 PreCommit Build #3732

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2474 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3732/ ### ## LAST 60 LINES OF THE CONSOLE ### [

Re: OWASP task failing again ! but is CI lying ?

Il giorno mer 30 gen 2019, 21:41 Patrick Hunt ha scritto: > Note the owasp job has been failing since the upgrade to dependency checker > 4 due to > "Target "dependency-check-update" does not exist in the project > "ZooKeeper"" > the jenkins job was explicitly running the update (which seems to n

[GitHub] eolivelli commented on issue #530: [ZOOKEEPER-2474] Support session reconnection when using ZKClientConfig

eolivelli commented on issue #530: [ZOOKEEPER-2474] Support session reconnection when using ZKClientConfig URL: https://github.com/apache/zookeeper/pull/530#issuecomment-459145228 This sounds interesting. Any progress? This i

[GitHub] eolivelli commented on issue #751: ZOOKEEPER-3234: Add Travis-CI configuration file

eolivelli commented on issue #751: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/751#issuecomment-459144337 I have to add travis_wait. I will fix the patch soon This is an a

[GitHub] eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-459144179 News? This is an automated me

Re: GitHub "god" mode

You will also be able to push commits to contributors' repositories :) Enrico Il giorno mer 30 gen 2019, 23:38 Brian Nixon ha scritto: > Thanks, Andor :) > > On Wed, Jan 30, 2019 at 8:18 AM Andor Molnar > wrote: > > > We're down to 4 pages of open PRs (from 7). > > Sorry for the huge number of

Re: Broken build

ZOOKEEPER-3240 is my patch - I'll see if I can figure out what the problem is. On Wed, Jan 30, 2019 at 7:54 AM Andor Molnar wrote: > This doesn't look good yet. > Let's give it some time (til tomorrow) to recover. > > Andor > > > > On Wed, Jan 30, 2019 at 12:08 PM Andor Molnar wrote: > > > Don

Re: GitHub "god" mode

Thanks, Andor :) On Wed, Jan 30, 2019 at 8:18 AM Andor Molnar wrote: > We're down to 4 pages of open PRs (from 7). > Sorry for the huge number of "closed pull request" emails. > > Andor > > > > On Wed, Jan 30, 2019 at 4:08 PM Camille Fournier > wrote: > > > Wow thanks Andor! > > > > On Wed, Jan

[jira] [Commented] (ZOOKEEPER-3249) Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756594#comment-16756594 ] Hudson commented on ZOOKEEPER-3249: --- SUCCESS: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3257) Merge count and byte update of Stat

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756596#comment-16756596 ] Hudson commented on ZOOKEEPER-3257: --- SUCCESS: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3251) Add new server metric types: percentile counter and counter set

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756595#comment-16756595 ] Hudson commented on ZOOKEEPER-3251: --- SUCCESS: Integrated in Jenkins build Zookeeper

[GitHub] enixon commented on issue #792: ZOOKEEPER-3262 Update dependencies flagged by OWASP report

enixon commented on issue #792: ZOOKEEPER-3262 Update dependencies flagged by OWASP report URL: https://github.com/apache/zookeeper/pull/792#issuecomment-459124192 makes sense to me This is an automated message from the Apach

[GitHub] anmolnar commented on issue #234: [ZOOKEEPER-2765] add C++ client library under contrib

anmolnar commented on issue #234: [ZOOKEEPER-2765] add C++ client library under contrib URL: https://github.com/apache/zookeeper/pull/234#issuecomment-459123044 @enixon I suggest moving the conversation to the dev list first. I think it'd be better for a C++ client to live in separate repo

[GitHub] enixon commented on issue #234: [ZOOKEEPER-2765] add C++ client library under contrib

enixon commented on issue #234: [ZOOKEEPER-2765] add C++ client library under contrib URL: https://github.com/apache/zookeeper/pull/234#issuecomment-459121933 @anmolnar yeah, this is associated with us. We're okay with closing the PR and we'll resubmit later, if appropriate. -

[GitHub] enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#issuecomment-459120322 The naive unit test didn't work - I'll circle back to this when I have time. -

[GitHub] joshelser commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba…

joshelser commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba… URL: https://github.com/apache/zookeeper/pull/784#issuecomment-459117465 f2738a7 should address your comments, @anmolnar. 9f091c4 updates the documentation. Thanks for the rev

[GitHub] eolivelli opened a new pull request #792: ZOOKEEPER-3262 Upgrade dependencies and suppress false positive on Netty

eolivelli opened a new pull request #792: ZOOKEEPER-3262 Upgrade dependencies and suppress false positive on Netty URL: https://github.com/apache/zookeeper/pull/792 This is an automated message from the Apache Git Service. T

[jira] [Updated] (ZOOKEEPER-3262) Update dependencies flagged by OWASP report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3262: -- Labels: pull-request-available (was: ) > Update dependencies flagged by OWASP repo

[jira] [Updated] (ZOOKEEPER-3262) Update dependencies flagged by OWASP report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3262: --- Description: Currently OWASP plugin is reporting these vulnerabilities: |[CVE-201

[GitHub] joshelser commented on issue #186: ZOOKEEPER-2711 Avoid synchronization on NettyServerCnxn in Factory

joshelser commented on issue #186: ZOOKEEPER-2711 Avoid synchronization on NettyServerCnxn in Factory URL: https://github.com/apache/zookeeper/pull/186#issuecomment-459108980 Looks like you're right, Andor. Netty4 support (ZOOKEEPER-3152) changed the NettyServerCnxnFactory implementation s

Re: OWASP task failing again ! but is CI lying ?

Working on the fix https://issues.apache.org/jira/browse/ZOOKEEPER-3262 Enrico Il giorno mer 30 gen 2019 alle ore 21:41 Patrick Hunt ha scritto: > > Note the owasp job has been failing since the upgrade to dependency checker > 4 due to > "Target "dependency-check-update" does not exist in the pr

[jira] [Created] (ZOOKEEPER-3262) Update dependencies flagged by OWASP report

Enrico Olivelli created ZOOKEEPER-3262: -- Summary: Update dependencies flagged by OWASP report Key: ZOOKEEPER-3262 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3262 Project: ZooKeeper

[GitHub] eolivelli commented on issue #791: ZOOKEEPER-3256: Enable OWASP checks to Maven build

eolivelli commented on issue #791: ZOOKEEPER-3256: Enable OWASP checks to Maven build URL: https://github.com/apache/zookeeper/pull/791#issuecomment-459102009 @anmolnar here it is the patch against branch-3.4 This is an autom

[GitHub] eolivelli opened a new pull request #791: ZOOKEEPER-3256: Enable OWASP checks to Maven build

eolivelli opened a new pull request #791: ZOOKEEPER-3256: Enable OWASP checks to Maven build URL: https://github.com/apache/zookeeper/pull/791 This is an automated message from the Apache Git Service. To respond to the messa

Re: OWASP task failing again ! but is CI lying ?

Note the owasp job has been failing since the upgrade to dependency checker 4 due to "Target "dependency-check-update" does not exist in the project "ZooKeeper"" the jenkins job was explicitly running the update (which seems to not exist after the upgrade). I updated the job targets however it's n

Build failed in Jenkins: ZooKeeper-trunk-owasp #255

See Changes: [andor] Revert "ZOOKEEPER-3240: Close socket on Learner shutdown to avoid [andor] ZOOKEEPER-3249: Avoid reverting the cversion and pzxid during replaying [andor] ZOOKEEPER-3251: Add new server

[jira] [Commented] (ZOOKEEPER-3249) Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756527#comment-16756527 ] Hudson commented on ZOOKEEPER-3249: --- FAILURE: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3257) Merge count and byte update of Stat

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756529#comment-16756529 ] Hudson commented on ZOOKEEPER-3257: --- FAILURE: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3251) Add new server metric types: percentile counter and counter set

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756528#comment-16756528 ] Hudson commented on ZOOKEEPER-3251: --- FAILURE: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3257) Merge count and byte update of Stat

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756519#comment-16756519 ] Hudson commented on ZOOKEEPER-3257: --- FAILURE: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3249) Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756517#comment-16756517 ] Hudson commented on ZOOKEEPER-3249: --- FAILURE: Integrated in Jenkins build ZooKeeper

ZooKeeper-trunk - Build # 376 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk/376/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 182.65 KB...] [junit] Tests run: 2, Failures: 0, Errors:

[jira] [Commented] (ZOOKEEPER-3251) Add new server metric types: percentile counter and counter set

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756518#comment-16756518 ] Hudson commented on ZOOKEEPER-3251: --- FAILURE: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3257) Merge count and byte update of Stat

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756476#comment-16756476 ] Hudson commented on ZOOKEEPER-3257: --- FAILURE: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3249) Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756474#comment-16756474 ] Hudson commented on ZOOKEEPER-3249: --- FAILURE: Integrated in Jenkins build ZooKeeper

[GitHub] joshelser commented on issue #186: ZOOKEEPER-2711 Avoid synchronization on NettyServerCnxn in Factory

joshelser commented on issue #186: ZOOKEEPER-2711 Avoid synchronization on NettyServerCnxn in Factory URL: https://github.com/apache/zookeeper/pull/186#issuecomment-459077693 @anmolnar I don't think this was related to the version of Netty, but the Netty serverCnxn implementation. I can tr

[jira] [Commented] (ZOOKEEPER-3251) Add new server metric types: percentile counter and counter set

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756475#comment-16756475 ] Hudson commented on ZOOKEEPER-3251: --- FAILURE: Integrated in Jenkins build ZooKeeper

ZooKeeper-trunk - Build # 375 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk/375/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 182.68 KB...] [junit] Tests run: 2, Failures: 0, Errors:

ZooKeeper_branch34_openjdk7 - Build # 2196 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2196/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.71 KB...] hudson.plugins.git.GitException: Fa

[jira] [Updated] (ZOOKEEPER-2817) Using `Collections.singletonList` instead of `Arrays.asList(oneElement)`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2817: -- Labels: pull-request-available (was: ) > Using `Collections.singletonList` instead

[GitHub] anmolnar commented on issue #314: [ZOOKEEPER-2846][Test] Leader follower sync with on disk txns can possibly leads to data inconsistency

anmolnar commented on issue #314: [ZOOKEEPER-2846][Test] Leader follower sync with on disk txns can possibly leads to data inconsistency URL: https://github.com/apache/zookeeper/pull/314#issuecomment-459061936 @lvfangmin Do you still need this PR? --

[jira] [Updated] (ZOOKEEPER-2846) Leader follower sync with on disk txns can possibly leads to data inconsistency

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2846: -- Labels: pull-request-available (was: ) > Leader follower sync with on disk txns ca

[jira] [Updated] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2684: -- Labels: pull-request-available (was: ) > Fix a crashing bug in the mixed workloads

[GitHub] anmolnar closed pull request #290: ZOOKEEPER-2817: Using `Collections.singletonList` instead of `Arrays.asList(oneElement)`

anmolnar closed pull request #290: ZOOKEEPER-2817: Using `Collections.singletonList` instead of `Arrays.asList(oneElement)` URL: https://github.com/apache/zookeeper/pull/290 This is an automated message from the Apache Git S

[GitHub] anmolnar commented on issue #167: ZOOKEEPER-2684 commitProcessor does not crash when an unseen commit somes

anmolnar commented on issue #167: ZOOKEEPER-2684 commitProcessor does not crash when an unseen commit somes URL: https://github.com/apache/zookeeper/pull/167#issuecomment-459061311 Fixed by 1392a8b3d8ac3d042a51dac18e33e144674b1b5b ---

[GitHub] anmolnar closed pull request #167: ZOOKEEPER-2684 commitProcessor does not crash when an unseen commit somes

anmolnar closed pull request #167: ZOOKEEPER-2684 commitProcessor does not crash when an unseen commit somes URL: https://github.com/apache/zookeeper/pull/167 This is an automated message from the Apache Git Service. To resp

[jira] [Updated] (ZOOKEEPER-2835) Run server with `-XX:+AlwaysPreTouch` jvm flag

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2835: -- Labels: pull-request-available (was: ) > Run server with `-XX:+AlwaysPreTouch` jvm

[GitHub] anmolnar commented on issue #301: ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` jvm flag

anmolnar commented on issue #301: ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` jvm flag URL: https://github.com/apache/zookeeper/pull/301#issuecomment-459060179 @asdf2014 I agree with @afine that we should add this to the documentation as a potential performance improvement rather

[GitHub] anmolnar closed pull request #301: ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` jvm flag

anmolnar closed pull request #301: ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` jvm flag URL: https://github.com/apache/zookeeper/pull/301 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (ZOOKEEPER-2879) Adding observers dynamically without server id

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2879: -- Labels: pull-request-available (was: ) > Adding observers dynamically without serv

[GitHub] anmolnar commented on issue #337: [ZOOKEEPER-2879] Adding observers dynamically without server id

anmolnar commented on issue #337: [ZOOKEEPER-2879] Adding observers dynamically without server id URL: https://github.com/apache/zookeeper/pull/337#issuecomment-459015410 @lvfangmin Can we move on? :) This is an automated mes

[jira] [Updated] (ZOOKEEPER-2825) 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLIENT module

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2825: -- Labels: pull-request-available refactoring (was: refactoring) > 1. Remove unnecess

[GitHub] anmolnar commented on issue #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLIE

anmolnar commented on issue #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLIENT module URL: https://github.com/apache/zookeeper/pull/297#issuecomment-459014220 @asdf2014 Change

[jira] [Updated] (ZOOKEEPER-2821) 1. Fix spell issues; 2. Remove unnecessary boxing / unboxing; 3. Simplify `return` clause; 4. Remove `final` qualifier from `private` method

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2821: -- Labels: pull-request-available refactoring (was: refactoring) > 1. Fix spell issue

[jira] [Updated] (ZOOKEEPER-2823) 1. Fix spell issues; 2. Standardize `StringBuilder#append` usage; 3. Using `try` clause for releasing I/O stream for `COMMON` module

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2823: -- Labels: pull-request-available refactoring (was: refactoring) > 1. Fix spell issue

[GitHub] anmolnar closed pull request #295: ZOOKEEPER-2823: 1. Fix spell issues; 2. Standardize `StringBuilder#append` usage; 3. Using `try` clause for releasing I/O stream for `COMMON` module

anmolnar closed pull request #295: ZOOKEEPER-2823: 1. Fix spell issues; 2. Standardize `StringBuilder#append` usage; 3. Using `try` clause for releasing I/O stream for `COMMON` module URL: https://github.com/apache/zookeeper/pull/295 --

[GitHub] anmolnar closed pull request #293: ZOOKEEPER-2821: 1. Fix spell issues; 2. Remove unnecessary boxing / unboxing; 3. Simplify `return` clause; 4. Remove `final` qualifier from `private` method

anmolnar closed pull request #293: ZOOKEEPER-2821: 1. Fix spell issues; 2. Remove unnecessary boxing / unboxing; 3. Simplify `return` clause; 4. Remove `final` qualifier from `private` method URL: https://github.com/apache/zookeeper/pull/293 --

[jira] [Updated] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2784: -- Labels: pull-request-available (was: ) > Add some limitations on code level for `S

[GitHub] anmolnar closed pull request #257: ZOOKEEPER-2784: Add same `sid` config problem check

anmolnar closed pull request #257: ZOOKEEPER-2784: Add same `sid` config problem check URL: https://github.com/apache/zookeeper/pull/257 This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Updated] (ZOOKEEPER-2781) Flaky test: testClientAuthAgainstNoAuthServerWithLowerSid

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2781: -- Labels: pull-request-available (was: ) > Flaky test: testClientAuthAgainstNoAuthSe

[jira] [Updated] (ZOOKEEPER-2826) Code refactoring for `CLI` module

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2826: -- Labels: pull-request-available (was: ) > Code refactoring for `CLI` module > -

[GitHub] anmolnar commented on issue #298: ZOOKEEPER-2826: Code refactoring for `CLI` module

anmolnar commented on issue #298: ZOOKEEPER-2826: Code refactoring for `CLI` module URL: https://github.com/apache/zookeeper/pull/298#issuecomment-459012057 @asdf2014 Are u still willing to work on this patch? This is an auto

[jira] [Updated] (ZOOKEEPER-2836) QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2836: -- Labels: pull-request-available (was: ) > QuorumCnxManager.Listener Thread Better h

[GitHub] anmolnar commented on issue #344: ZOOKEEPER-2836: Fix SocketTimeoutException

anmolnar commented on issue #344: ZOOKEEPER-2836: Fix SocketTimeoutException URL: https://github.com/apache/zookeeper/pull/344#issuecomment-459011290 @bitgaoshu This patch should be committed. Would you please rebase? This is

[jira] [Updated] (ZOOKEEPER-2630) Use interface type instead of implementation type when appropriate.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2630: -- Labels: newbie pull-request-available refactoring (was: newbie refactoring) > Use

[jira] [Updated] (ZOOKEEPER-2814) Ignore space after comma in connection string

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2814: -- Labels: pull-request-available (was: ) > Ignore space after comma in connection st

[jira] [Updated] (ZOOKEEPER-2894) Memory and completions leak on zookeeper_close.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2894: -- Labels: easyfix pull-request-available (was: easyfix) > Memory and completions lea

[GitHub] anmolnar commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894

anmolnar commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894 URL: https://github.com/apache/zookeeper/pull/363#issuecomment-459009863 @xoiss Looks like a very nice catch. Would you mind creating a separate pull request for the master branch that we can commit first and backport

[GitHub] anmolnar closed pull request #371: ZOOKEEPER-2814: Ignore space after comma in connection string

anmolnar closed pull request #371: ZOOKEEPER-2814: Ignore space after comma in connection string URL: https://github.com/apache/zookeeper/pull/371 This is an automated message from the Apache Git Service. To respond to the m

[jira] [Resolved] (ZOOKEEPER-2765) modern C++ client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2765. - Resolution: Won't Fix > modern C++ client > - > > Key

[GitHub] anmolnar commented on issue #395: ZOOKEEPER-2630: Use interface type instead of implementation type whe…

anmolnar commented on issue #395: ZOOKEEPER-2630: Use interface type instead of implementation type whe… URL: https://github.com/apache/zookeeper/pull/395#issuecomment-459007707 @tamaashu @phunt Looks like this patch has been abandoned for a while and the Jira has already been closed.

Failed: ZOOKEEPER-1416 PreCommit Build #3731

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3731/ ### ## LAST 60 LINES OF THE CONSOLE ### [

Re: GitHub "god" mode

We're down to 4 pages of open PRs (from 7). Sorry for the huge number of "closed pull request" emails. Andor On Wed, Jan 30, 2019 at 4:08 PM Camille Fournier wrote: > Wow thanks Andor! > > On Wed, Jan 30, 2019, 6:45 AM Enrico Olivelli > > Awesome > > > > Enrico > > > > Il giorno mer 30 gen 2

[GitHub] anmolnar closed pull request #151: Applying ZOOKEEPER-2642 patch to a 3.5 base

anmolnar closed pull request #151: Applying ZOOKEEPER-2642 patch to a 3.5 base URL: https://github.com/apache/zookeeper/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] anmolnar closed pull request #234: [ZOOKEEPER-2765] add C++ client library under contrib

anmolnar closed pull request #234: [ZOOKEEPER-2765] add C++ client library under contrib URL: https://github.com/apache/zookeeper/pull/234 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (ZOOKEEPER-2765) modern C++ client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756267#comment-16756267 ] Andor Molnar commented on ZOOKEEPER-2765: - I totally support the idea of havi

[GitHub] anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch URL: https://github.com/apache/zookeeper/pull/136#issuecomment-459004064 @Randgalt Sounds like a great new feature for 3.6 Would you mind rebasing it on master? -

[GitHub] anmolnar closed pull request #251: ZOOKEEPER-2781 Flaky test: testClientAuthAgainstNoAuthServerWithLowerSid

anmolnar closed pull request #251: ZOOKEEPER-2781 Flaky test: testClientAuthAgainstNoAuthServerWithLowerSid URL: https://github.com/apache/zookeeper/pull/251 This is an automated message from the Apache Git Service. To respo

[GitHub] anmolnar closed pull request #47: Update zookeeperOver.html

anmolnar closed pull request #47: Update zookeeperOver.html URL: https://github.com/apache/zookeeper/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use th

[jira] [Assigned] (ZOOKEEPER-3257) Merge count and byte update of Stat

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3257: --- Assignee: Brian Nixon > Merge count and byte update of Stat > --

[GitHub] anmolnar commented on issue #789: ZOOKEEPER-3257: Merge count and byte update of Stat

anmolnar commented on issue #789: ZOOKEEPER-3257: Merge count and byte update of Stat URL: https://github.com/apache/zookeeper/pull/789#issuecomment-459000210 Committed to master branch. Thanks @enixon ! This is an automated

[jira] [Resolved] (ZOOKEEPER-3257) Merge count and byte update of Stat

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3257. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 789 [htt

[GitHub] asfgit closed pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat

asfgit closed pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat URL: https://github.com/apache/zookeeper/pull/789 This is an automated message from the Apache Git Service. To respond to the message, plea

Re: Broken build

This doesn't look good yet. Let's give it some time (til tomorrow) to recover. Andor On Wed, Jan 30, 2019 at 12:08 PM Andor Molnar wrote: > Done. I reverted the patch on 3.5 and master branches. > Hopefully builds will soon become green again. > > Andor > > > > On Wed, Jan 30, 2019 at 11:45 A

  1   2   3   >