It’s green now.
> On 2019. Feb 12., at 22:03, Enrico Olivelli wrote:
>
> good
>
> thank you
> Enrico
>
> Il giorno mar 12 feb 2019 alle ore 22:02 Andor Molnar
> ha scritto:
>>
>> btw. I’ve fixed the config and added to the ZK view:
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/
>>
nkalmar commented on a change in pull request #818: ZOOKEEPER-3275: Fix release
targets: package, tar, mvn-deploy (3.4)
URL: https://github.com/apache/zookeeper/pull/818#discussion_r256295117
##
File path: zookeeper-contrib/zookeeper-contrib-zooinspector/build.xml
##
@@ -1
anmolnar commented on a change in pull request #796: ZOOKEEPER-3267: Add
watcher metrics
URL: https://github.com/apache/zookeeper/pull/796#discussion_r256363368
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
##
@@ -106,6
eolivelli commented on a change in pull request #796: ZOOKEEPER-3267: Add
watcher metrics
URL: https://github.com/apache/zookeeper/pull/796#discussion_r256363666
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
##
@@ -106,
eolivelli commented on a change in pull request #796: ZOOKEEPER-3267: Add
watcher metrics
URL: https://github.com/apache/zookeeper/pull/796#discussion_r255818297
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
##
@@ -106,
anmolnar commented on issue #715: Rollup of blocker/critical fixes for 3.5 (to
trigger CI)
URL: https://github.com/apache/zookeeper/pull/715#issuecomment-463173102
@mkedwards Do you still need this pull request?
If there's still something in it which should be committed, please raise a
asfgit closed pull request #784: ZOOKEEPER-974: Allow a configurable ZooKeeper
server socket listen ba…
URL: https://github.com/apache/zookeeper/pull/784
This is an automated message from the Apache Git Service.
To respond t
anmolnar commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper
server socket listen ba…
URL: https://github.com/apache/zookeeper/pull/784#issuecomment-463177301
Committed to master branch. Thanks @joshelser !
eolivelli commented on a change in pull request #796: ZOOKEEPER-3267: Add
watcher metrics
URL: https://github.com/apache/zookeeper/pull/796#discussion_r256368844
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
##
@@ -106,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3239.
-
Resolution: Fixed
Issue resolved by pull request 768
[https://github.com/apache/zooke
asfgit closed pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to
verify the ensemble name
URL: https://github.com/apache/zookeeper/pull/768
This is an automated message from the Apache Git Service.
To respond
anmolnar commented on issue #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider
to verify the ensemble name
URL: https://github.com/apache/zookeeper/pull/768#issuecomment-463179142
Committed to master. Thanks @jhuan31 !
This is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar reassigned ZOOKEEPER-3239:
---
Assignee: Jie Huang
> Adding EnsembleAuthProvider to verify the ensemble name
>
ping @anmolnar and others, any insights or suggestions ?
- 原始邮件 -发件人："Justin Ling Mao"
收件人："dev"
主题：A big refactor for the documetations
日期：2019年02月12日 11点50分
Hi gugs:I'am working on doing a big refactor for the documetations.it aims to
- 1.make a better reading experiences and help us
anmolnar commented on issue #818: ZOOKEEPER-3275: Fix release targets: package,
tar, mvn-deploy (3.4)
URL: https://github.com/apache/zookeeper/pull/818#issuecomment-463206918
retest maven build
This is an automated message fr
nkalmar commented on issue #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/813#issuecomment-463208122
retest this please
This is an automated message from the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar resolved ZOOKEEPER-3271.
---
Resolution: Invalid
> Add new maven profile for PR tests
> --
Hi,
I think the formatting is broken, it was a bit hard to read through.
I think it's a good idea, especially adding new stuff like 3rd party tools
Curator and examples.
I'm not sure we want to change the formatting of the docs though. It's been
similar for a long time, and I guess people got used
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3275.
-
Resolution: Fixed
Fix Version/s: 3.5.5
3.4.14
anmolnar commented on issue #818: ZOOKEEPER-3275: Fix release targets: package,
tar, mvn-deploy (3.4)
URL: https://github.com/apache/zookeeper/pull/818#issuecomment-463226752
Committed, because Ant build is green. Thanks @nkalmar !
--
anmolnar closed pull request #818: ZOOKEEPER-3275: Fix release targets:
package, tar, mvn-deploy (3.4)
URL: https://github.com/apache/zookeeper/pull/818
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767301#comment-16767301
]
Hudson commented on ZOOKEEPER-974:
--
FAILURE: Integrated in Jenkins build Zookeeper-tr
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767302#comment-16767302
]
Hudson commented on ZOOKEEPER-3239:
---
FAILURE: Integrated in Jenkins build Zookeeper
This is a bugfix release candidate for 3.4.14. It fixes 8 issues, mostly build
/ unit tests issues,
dependency updates flagged by OWASP, NPE and a name resolution problem. Among
these it also supports
experimental Maven build and Markdown based documentation generation.
The full release notes is
nkalmar commented on issue #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/813#issuecomment-463279698
retest this please
This is an automated message from the
eolivelli commented on issue #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 -
Create maven assembly
URL: https://github.com/apache/zookeeper/pull/813#issuecomment-463280424
retest ant build
This is an automated message from the
ivmaykov opened a new pull request #819: ZOOKEEPER-3272: Clean up netty4 code
per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819
Netty4 code clean-up per the discussion in PR #753.
This is a
ivmaykov commented on issue #819: ZOOKEEPER-3272: Clean up netty4 code per
Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#issuecomment-463294663
@anmolnar here is the 3.5 version of #809
Thi
[
https://issues.apache.org/jira/browse/ZOOKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767404#comment-16767404
]
Hudson commented on ZOOKEEPER-974:
--
SUCCESS: Integrated in Jenkins build ZooKeeper-tr
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767405#comment-16767405
]
Hudson commented on ZOOKEEPER-3239:
---
SUCCESS: Integrated in Jenkins build ZooKeeper
nkalmar commented on issue #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/813#issuecomment-463386009
retest ant build
This is an automated message from the Ap
[
https://issues.apache.org/jira/browse/ZOOKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767626#comment-16767626
]
Josh Elser commented on ZOOKEEPER-974:
--
Thanks for the commit, Andor!
> Configur
eolivelli commented on a change in pull request #819: ZOOKEEPER-3272: Clean up
netty4 code per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#discussion_r256607222
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServe
eolivelli commented on a change in pull request #819: ZOOKEEPER-3272: Clean up
netty4 code per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#discussion_r256607723
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServe
ivmaykov commented on a change in pull request #819: ZOOKEEPER-3272: Clean up
netty4 code per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#discussion_r256609116
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServer
eolivelli commented on a change in pull request #819: ZOOKEEPER-3272: Clean up
netty4 code per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#discussion_r256609612
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServe
ivmaykov commented on issue #819: ZOOKEEPER-3272: Clean up netty4 code per
Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#issuecomment-463394730
@eolivelli actually, how about we land this PR as-is so it's a straight
backport, and then I will make another
eolivelli commented on a change in pull request #819: ZOOKEEPER-3272: Clean up
netty4 code per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#discussion_r256609612
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServe
Ilya Maykov created ZOOKEEPER-3277:
--
Summary: Add trace listener in NettyServerCnxnFactory only if
trace logging is enabled
Key: ZOOKEEPER-3277
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3277
ivmaykov commented on a change in pull request #819: ZOOKEEPER-3272: Clean up
netty4 code per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#discussion_r256612609
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServer
ivmaykov opened a new pull request #820: ZOOKEEPER-3277: Add trace listener in
NettyServerCnxnFactory only if trace logging is enabled
URL: https://github.com/apache/zookeeper/pull/820
Based on the code review discussion in #819
-
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3277:
--
Labels: pull-request-available (was: )
> Add trace listener in NettyServerCnxnFact
eolivelli edited a comment on issue #819: ZOOKEEPER-3272: Clean up netty4 code
per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#issuecomment-463397885
@ivmaykov works for me.
if you prefer I can send the patch for the isTraceEnabled()
---
eolivelli commented on issue #819: ZOOKEEPER-3272: Clean up netty4 code per
Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#issuecomment-463397885
@ivmaykov works for me.
if you prefer I can sent the patch for the isTraceEnabled()
--
ivmaykov commented on issue #819: ZOOKEEPER-3272: Clean up netty4 code per
Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/819#issuecomment-463398344
@eolivelli I just think it's easier to keep track of what code exists on
master vs. what code exists on branch
ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue
data in NettyServerCnxn
URL: https://github.com/apache/zookeeper/pull/810#issuecomment-463401808
Looking into the async hammer test failures now ...
-
ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue
data in NettyServerCnxn
URL: https://github.com/apache/zookeeper/pull/810#issuecomment-463410028
Trying to reuse the same CompositeByteBuf seems to be causing connection
timeouts in AsyncHammerTest, so revert t
ivmaykov commented on issue #820: ZOOKEEPER-3277: Add trace listener in
NettyServerCnxnFactory only if trace logging is enabled
URL: https://github.com/apache/zookeeper/pull/820#issuecomment-463412205
@anmolnar: this should apply to master cleanly, but needs #819 to be merged
before it can
Thanks for your ACK @Norbert!
--->"I think the formatting is broken, it was a bit hard to read through."
Wuuu,it's ok in my side.You can also read this Google Doc:
https://docs.google.com/document/d/1N_WS37E83LtoYFm9AnuAnnE3axpe-ypogJ65LCqqZMQ/edit?usp=sharing
--->"I'm not sure we wan
49 matches
Mail list logo
