Maven dependencies for client in ZK 3.5.5 rc5 - clean up needed ?

2019-04-27 Thread Enrico Olivelli
Hi folks, I am comparing the transitive dependencies that we will import to Java clients with 3.5.5rc5 This is a dependency:tree of a simple application which imports zookeeper-server:3.5.5 com.mycompany:ciaoZk:jar:1.0-SNAPSHOT \- org.apache.zookeeper:zookeeper:jar:3.5.5:compile +-

[jira] [Updated] (ZOOKEEPER-3366) Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-04-24 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3366: --- Summary: Pluggable metrics system for ZooKeeper - move remaining metrics

Re: Prometheus.io endpoint vs admin server

2019-04-24 Thread Enrico Olivelli
isabled by default on every zk cluster in my products > 2. Is the following a good option? > e.g: > http://:8080/commands/metrics > or: > http://:8080/metrics > The best will be only '/metrics' that is the default binding for P. Enrico > > - Original Messag

Re: Raise the Quality of ZooKeeper Docs with Google Season of Docs Project

2019-04-24 Thread Enrico Olivelli
Fangmin, Awesome idea. +1 Personally I don't know how much I will have, but I think it is worth to try Enrico Il mar 23 apr 2019, 18:42 Fangmin Lv ha scritto: > Hi guy, > > Raise here to see if we have interest to participant in the Google Season > of Docs or not. > > (The deadline is today,

Prometheus.io endpoint vs admin server

2019-04-23 Thread Enrico Olivelli
Hi, I am working on Prometheus endpoint. Prometheus client needs to expose an HTTP service, usually it is mapped at /metrics, the Prometheus serve polls that endpoint periodically in order to store metrics inside its local database. We have two ways: 1) bind '/metrics' to the current "Admin

Re: Jenkins build doesn't work

2019-04-22 Thread Enrico Olivelli
https://jira.apache.org/jira/plugins/servlet/mobile#issue/ZOOKEEPER-3351 Enrico > Regards, > > Patrick > > > On Fri, Apr 19, 2019 at 11:43 PM Enrico Olivelli > wrote: > > > I have fixed configuration of the ANT based precommit job > > https://builds.apache.or

Re: Jenkins build doesn't work

2019-04-20 Thread Enrico Olivelli
like https://builds.apache.org/job/ZooKeeper-trunk/ Cheers Enrico Il giorno sab 20 apr 2019 alle ore 07:57 Enrico Olivelli ha scritto: > > > > Il sab 20 apr 2019, 01:17 Jie Huang ha scritto: >> >> It doesn't seem to build at all. The most suspicious error message is: >

Re: Jenkins build doesn't work

2019-04-19 Thread Enrico Olivelli
Il sab 20 apr 2019, 01:17 Jie Huang ha scritto: > It doesn't seem to build at all. The most suspicious error message is: > > /tmp/jenkins1102606335931600364.sh: line 26: > /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant: No such file or > directory > > > Is this happening only to me? > No it

[jira] [Created] (ZOOKEEPER-3366) Pluggable metrics system for ZooKeeper - move remaining metrics to ServerMetrics

2019-04-16 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3366: -- Summary: Pluggable metrics system for ZooKeeper - move remaining metrics to ServerMetrics Key: ZOOKEEPER-3366 URL: https://issues.apache.org/jira/browse/ZOOKEEPER

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 4

2019-04-15 Thread Enrico Olivelli
+1 (non binding) built and run tests (spotbugs, rat), on jdk11 + linux 64bit Fedora 28 checksums/signatures ok smoke tests on binary package with jdk8/11 on Fedora 28 checked "lib" on binary packages/license stuff Great work ! Enrico Il giorno lun 15 apr 2019 alle ore 15:06 Norbert Kalmar ha

[jira] [Created] (ZOOKEEPER-3364) Compile with strict options in order to check code quality

2019-04-13 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3364: -- Summary: Compile with strict options in order to check code quality Key: ZOOKEEPER-3364 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3364 Project

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-13 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816873#comment-16816873 ] Enrico Olivelli commented on ZOOKEEPER-3351: This is the issue about checkstyle:ZOOKEEPER

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-13 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816871#comment-16816871 ] Enrico Olivelli commented on ZOOKEEPER-3351: [~Tison] I have created the umbrella issue

[jira] [Created] (ZOOKEEPER-3363) Drop ant basedbuild umbrella issue

2019-04-13 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3363: -- Summary: Drop ant basedbuild umbrella issue Key: ZOOKEEPER-3363 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3363 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3362) Create a simple checkstyle file

2019-04-12 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3362: --- Description: Create a basic checkstyle file, in order to cover the minimal check

[jira] [Updated] (ZOOKEEPER-3362) Create a simple checkstyle file

2019-04-12 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3362: --- Description: Create a basic checkstyle file, in order to cover the minimal check

[jira] [Created] (ZOOKEEPER-3362) Create a simple checkstyle file

2019-04-12 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3362: -- Summary: Create a simple checkstyle file Key: ZOOKEEPER-3362 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3362 Project: ZooKeeper Issue

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

2019-04-12 Thread Enrico Olivelli
onsider it as blocker, I was able to verify checksums. Enrico > > Thanks, > Andor > > > > > > On 2019. Apr 12., at 13:11, Enrico Olivelli > <mailto:eolive...@gmail.com>> wrote: > > > > (just to be clear) > > > > +1 (non binding) >

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

2019-04-12 Thread Enrico Olivelli
or releases. > > > > - Rat check has found 27 files with missing license headers for me > > (attached). Let's add them to the exclusion list. > > > > > > > > Regards, > > > > Andor > > > > > > > > > > > > On 4

[jira] [Commented] (ZOOKEEPER-3356) Request throttling in Netty is not working as expected and could cause direct buffer OOM issue

2019-04-09 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814043#comment-16814043 ] Enrico Olivelli commented on ZOOKEEPER-3356: Can this be a blocker for 3.5.5?l as 'stable

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

2019-04-09 Thread Enrico Olivelli
I am testing this RC, before casting my vote I would like to share these problems, I am not sure they are blockers: 1) spotbugs is not passing (tested both with jdk11 and jdk8) mvn clean install -DskipTests spotbugs:check [INFO] --- spotbugs-maven-plugin:3.1.9:check (default-cli) @ zookeeper

Maven migration - last steps - CI precommit advanced checks

2019-04-09 Thread Enrico Olivelli
Hi, we are going to release the first version of ZooKeeper with Maven in order to drop ant we have to drop the QA precommit job based on BASH + ANT. I have created a plan here https://issues.apache.org/jira/browse/ZOOKEEPER-3351 Please take a look. I will e happy to start sending patches as

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812782#comment-16812782 ] Enrico Olivelli commented on ZOOKEEPER-3351: My plan is to migrate all of the checks

[jira] [Comment Edited] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812775#comment-16812775 ] Enrico Olivelli edited comment on ZOOKEEPER-3351 at 4/8/19 8:45 PM

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812775#comment-16812775 ] Enrico Olivelli commented on ZOOKEEPER-3351: most of the work of that script can

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812766#comment-16812766 ] Enrico Olivelli commented on ZOOKEEPER-3351: that task is calling zookeeper-server/src

[jira] [Created] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3351: -- Summary: Migrate qa-test-pullrequest ant task to maven Key: ZOOKEEPER-3351 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351 Project: ZooKeeper

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2

2019-04-06 Thread Enrico Olivelli
ater. > I agree, not all my points are blockers. The most critical point is that the source tarball does not reflect the tag and, important files are missing. Cheers Enrico > Regards, Tamaas > > On Fri, Apr 5, 2019, 17:37 Enrico Olivelli wrote: > > > -1 (non binding) &

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2

2019-04-05 Thread Enrico Olivelli
-1 (non binding) Good news: I have build the sources with jdk-8 and all tests passed checksums and signatures are ok I run a few smoke tests running on JDK11, all is ok Bad news: I see the following problems in the "binary package", not all blockers: - we have a lib/cobertura directory, not

[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big

2019-04-04 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809825#comment-16809825 ] Enrico Olivelli commented on ZOOKEEPER-3337: This is my comment https://github.com/apache

[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big

2019-04-04 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809824#comment-16809824 ] Enrico Olivelli commented on ZOOKEEPER-3337: I have an huge userid on my work laptop

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 1

2019-04-03 Thread Enrico Olivelli
-1 (non binding) I am sorry, but staged tarballs do not include a "root" directory like it was for previous tarballs I am continuing with my validation Enrico Il giorno mer 3 apr 2019 alle ore 15:25 Norbert Kalmar ha scritto: > > Hi all, > > Great news Andor, thanks! > > Just a few notes: >

Re: [ANNOUNCE] Apache ZooKeeper 3.4.14

2019-04-02 Thread Enrico Olivelli
Great work Andor !! Enrico Il giorno mar 2 apr 2019 alle ore 12:51 Justin Ling Mao ha scritto: > > Awesome!!! > - Original Message - > From: Andor Molnar > To: DevZooKeeper , u...@zookeeper.apache.org > Subject: [ANNOUNCE] Apache ZooKeeper 3.4.14 > Date: 2019-04-02 18:32 > > > The

Re: Opening 'retest maven/ant build' to the public

2019-03-22 Thread Enrico Olivelli
; > > > On Thu, Mar 21, 2019 at 6:36 PM Brian Nixon > > wrote: > > > > > Dropping the constraint would be much appreciated :) > > > > > > On Thu, Mar 21, 2019 at 10:32 AM Patrick Hunt wrote: > > > > > > > Seems reasonable. I

Opening 'retest maven/ant build' to the public

2019-03-21 Thread Enrico Olivelli
Hi Zookeepers, Currently only apache committers are allowed to restart pre commit builds withon the 'magic phrase'. But anyone can close/reopen his PR in order to achieve the same result. I would like to drop the 'committers only' constraint which seems useless Opinions? Enrico

[jira] [Commented] (ZOOKEEPER-3317) dynamic file for reconfig should support the relative path

2019-03-18 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794778#comment-16794778 ] Enrico Olivelli commented on ZOOKEEPER-3317: Yes. I will assign this issue to myself

Mavenized Zookeeper Roadmap

2019-03-17 Thread Enrico Olivelli
Hi, It seems to me that we don't have a clear roadmap for the switch to Maven. Points: - will we ever drop Ant for branch-3.4 and branch-3.5? I assume that for master it is not a problem - the release with Maven will have different results than the Ant based one, at least I expect a more

[jira] [Commented] (ZOOKEEPER-2621) ZooKeeper doesn't start on MINGW32 (Windows)

2019-03-17 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794531#comment-16794531 ] Enrico Olivelli commented on ZOOKEEPER-2621: Can you send a PR on github? I know

[jira] [Commented] (ZOOKEEPER-3317) dynamic file for reconfig should support the relative path

2019-03-16 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794238#comment-16794238 ] Enrico Olivelli commented on ZOOKEEPER-3317: Yes I would like this feature. Are you

[jira] [Created] (ZOOKEEPER-3312) Upgrade Jetty to 9.4.15.v20190215

2019-03-14 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3312: -- Summary: Upgrade Jetty to 9.4.15.v20190215 Key: ZOOKEEPER-3312 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3312 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora

2019-03-12 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790978#comment-16790978 ] Enrico Olivelli commented on ZOOKEEPER-3303: Okay. Now it is clear to me. I wonder why

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 5

2019-03-12 Thread Enrico Olivelli
shipping > > that jar in previous releases too, so it should be fine in licensing wise. > > > > I'm happy to create another RC if other people think we should take that > > one out too, but it seems to me we're still fine. > > > > Regards, > > Andor > >

Re: testManyChildWatchersAutoReset

2019-03-11 Thread Enrico Olivelli
:( Enrico Il mar 12 mar 2019, 01:02 Andor Molnar ha scritto: > Hi Enrico / Michael, > > Unfortunately it looks like the flaky test that you wanted to fix has just > failed again: > > https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_java9/640/ > > This has been failing

Re: Re: ZooKeeper 3.5 blocker issues

2019-03-11 Thread Enrico Olivelli
Maven build or Ant? Maybe this question deserves a separate thread... Thank you Andor for moving the project forward. Enrico > > > > > Stay tuned. > > Regards, > Andor > > > > > > On Thu, Jan 3, 2019 at 1:28 PM Enrico Olivelli > wrote: > > >

[jira] [Commented] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora

2019-03-11 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789535#comment-16789535 ] Enrico Olivelli commented on ZOOKEEPER-3303: Is it something we have to fix in ZooKeeper

[jira] [Created] (ZOOKEEPER-3304) Maven build of "loggraph" is broken on branch-3.4

2019-03-10 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3304: -- Summary: Maven build of "loggraph" is broken on branch-3.4 Key: ZOOKEEPER-3304 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3304

[jira] [Commented] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora

2019-03-09 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788715#comment-16788715 ] Enrico Olivelli commented on ZOOKEEPER-3303: Can you please reproduce your failure

[jira] [Commented] (ZOOKEEPER-3293) ZooKeeper fails to compile on newer RHEL systems ie. Fedora

2019-03-09 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788709#comment-16788709 ] Enrico Olivelli commented on ZOOKEEPER-3293: I see. Btw if we fix the release from

[jira] [Commented] (ZOOKEEPER-3293) ZooKeeper fails to compile on newer RHEL systems ie. Fedora

2019-03-09 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788703#comment-16788703 ] Enrico Olivelli commented on ZOOKEEPER-3293: On current master I have only this problem

[jira] [Updated] (ZOOKEEPER-3302) ZooKeeper C client does not compile on Fedora 29

2019-03-09 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3302: --- Description: I cannot build current master (git sha

[jira] [Created] (ZOOKEEPER-3302) ZooKeeper C client does not compile on Fedora 29

2019-03-09 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3302: -- Summary: ZooKeeper C client does not compile on Fedora 29 Key: ZOOKEEPER-3302 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3302 Project

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 5

2019-03-09 Thread Enrico Olivelli
Before sending my vote I found a audience-annotations-0.5.0.jar Is it needed at runtime? I did not yet have time to check Enrico Il gio 7 mar 2019, 15:23 Norbert Kalmar ha scritto: > +1 (non-binding) > > checked signatures and checksums > built from source (oracle jdk8 and openjdk 11.0.2) >

[jira] [Commented] (ZOOKEEPER-3293) ZooKeeper fails to compile on newer RHEL systems ie. Fedora

2019-03-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788038#comment-16788038 ] Enrico Olivelli commented on ZOOKEEPER-3293: I get the same error > ZooKeeper fa

Re: License files

2019-03-06 Thread Enrico Olivelli
Il mer 6 mar 2019, 16:33 Norbert Kalmar ha scritto: > Hi all, > > We had some issues with the license files in the last few RC on 3.4. > > To make things easier in the future, I was looking at the maven license > plugin. But I'm not sure about are legal obligations. I think that having a file

Re: MetricsProvider..time to start?

2019-03-05 Thread Enrico Olivelli
ore 08:40 Enrico Olivelli ha scritto: > > > > Il giorno sab 26 gen 2019, 01:09 Brian Nixon ha > scritto: >> >> Hi Enrico, >> >> Most of the major remaining contributions from the Facebook engineers >> around metrics are captured in >> https://i

[jira] [Updated] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-04 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3143: --- Summary: Pluggable metrics system for ZooKeeper - Data Collection on Server

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 4

2019-02-28 Thread Enrico Olivelli
+1 (non binding) run java tests run smoke tests checked signatures and checksums all with Java8 on Fedora I am getting this error during the compilation of the c-client error: '%d' directive writing between 1 and 5 bytes into a region of size between 0 and 127 [-Werror=format-overflow=] [exec]

[jira] [Resolved] (ZOOKEEPER-2966) Flaky NullPointerException while closing client connection

2019-02-28 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved ZOOKEEPER-2966. Resolution: Cannot Reproduce As reported of the issue I am closing

Re: Question on ZK commit/patch policy.

2019-02-27 Thread Enrico Olivelli
I think that having a JIRA makes it simpler to create release notes and track bugfixes/new features. Trivial changes, like typos are not worth a JIRA. My 2 cents Enrico Il mer 27 feb 2019, 17:57 Patrick Hunt ha scritto: > Yea, the commit I just did was a single missing space so no big deal. >

Re: Build failed in Jenkins: zookeeper-master-maven #97

2019-02-27 Thread Enrico Olivelli
I will take a look Enrico Il mer 27 feb 2019, 13:12 Apache Jenkins Server ha scritto: > See < > https://builds.apache.org/job/zookeeper-master-maven/97/display/redirect> > > -- > Started by an SCM change > [EnvInject] - Loading node environment

[jira] [Resolved] (ZOOKEEPER-3224) CI integration with maven

2019-02-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved ZOOKEEPER-3224. Resolution: Fixed Release Note: Let's close it. We have Travis + Pull

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 3

2019-02-24 Thread Enrico Olivelli
Il dom 24 feb 2019, 01:19 Patrick Hunt ha scritto: > -1. I notice at least a couple issues with license files. I used "meld" on > 3.4.14 to compare it to 3.4.13. > > in "lib" directory > * the file "jline-0.9.94.LICENSE.txt" has gone missing (and there is no > license file within the jar itself)

Travis is Up an running

2019-02-22 Thread Enrico Olivelli
Hi folks, Andor merged the patch about Travis configuration, let me recap the status quo about Pull Requests. 1) We are using Travis to test the build on JDK8 and JDK11 + spotbugs (which has differents results on different JDK versions), using Maven - in order to make Travis restart you have to

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 3

2019-02-22 Thread Enrico Olivelli
+1 (non binding) Built with Ant on Fedora 28 and Oracle JDK 8 Java test OK (Oracke JDK 8) verified checksums and signatures (even the one inside the tarball) run smoke tests with a cluster of 3 servers and two clients, bouncing the leader a couple of times all seems running as expected from logs

Re: Test failure on branch-3.4 Java 11 build

2019-02-19 Thread Enrico Olivelli
ico > > On Tue, Feb 19, 2019 at 10:30 PM Enrico Olivelli > wrote: > > > Can we read JMX beans without using the network ? > > > > Btw That patch seems unrelated. > > > > Enrico > > > > Il giorno mar 19 feb 2019, 22:26 Andor Molnár ha >

Re: Test failure on branch-3.4 Java 11 build

2019-02-19 Thread Enrico Olivelli
Can we read JMX beans without using the network ? Btw That patch seems unrelated. Enrico Il giorno mar 19 feb 2019, 22:26 Andor Molnár ha scritto: > The build was successful (red, but different error) on H31 again without > any modification. > > Now what? :) > > > Andor > > > > > On 2/18/19

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 2

2019-02-18 Thread Enrico Olivelli
great work Andor ! +1 (non binding) - checked signatures and checsums (of the tarball and of the binaries included) - run java tests on jdk8 on Linux (Fedora 28), all is okay - run "ant tar" and checked that the repackaged and compiled source are working Enrico Il giorno lun 18 feb 2019 alle

[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769786#comment-16769786 ] Enrico Olivelli commented on ZOOKEEPER-3280: Seems like https://github.com/apache

ZookKeeper and 'released' artifacts

2019-02-14 Thread Enrico Olivelli
Hi ZooKeepers, It's the first time I am looking deeply into the release procedure and what ZooKeeper is 'releasing'. I would like to share some thoughts, in order to understand better the process. I see that in the official repository [1] we are releasing only one single "artifact" which is a

Re: Four letter word command to get memory usage (patch included)

2019-02-14 Thread Enrico Olivelli
s on > that. You can add new Jetty command or JMX whichever suits you best. IMHO > the best would be add to them both. > > Thanks, > Andor > > > > On Thu, Feb 14, 2019 at 5:18 PM Enrico Olivelli wrote: > > > Hi, > > Can you please create a patch agai

Re: Four letter word command to get memory usage (patch included)

2019-02-14 Thread Enrico Olivelli
Hi, Can you please create a patch against master branch and create a PR in github? Thank you Enrico Il giorno gio 14 feb 2019, 17:05 Bram Van Dam ha scritto: > Hey folks, > > I needed a way to keep track of individual ZK instances' memory usage > without using JMX, so I went and added a new

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 1

2019-02-14 Thread Enrico Olivelli
-1 from me as well. I see the same errors, and I have a test which is failing on my laptop junit.run: [junit] Running org.apache.zookeeper.test.BufferSizeTest [junit] Tests run: 6, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 6,11 sec [junit] Test org.apache.zookeeper.test.BufferSizeTest

[jira] [Created] (ZOOKEEPER-3279) Maven tests fail on branch-3.4

2019-02-14 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3279: -- Summary: Maven tests fail on branch-3.4 Key: ZOOKEEPER-3279 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3279 Project: ZooKeeper Issue

[jira] [Created] (ZOOKEEPER-3278) Maven sources are not buildable if not linked to a git respotiory

2019-02-14 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3278: -- Summary: Maven sources are not buildable if not linked to a git respotiory Key: ZOOKEEPER-3278 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3278

Re: ZooKeeper_branch34_openjdk7 - Build # 2208 - Still Failing

2019-02-12 Thread Enrico Olivelli
gt; > > > > On 2019. Feb 12., at 21:54, Andor Molnar wrote: > > > > Thanks for pointing out. > > > > I think this build can be disabled: jdk7 is no longer supported, > > git.apache.org <http://git.apache.org/> is no longer up-to-date. > &

Re: ZooKeeper and checkstyle

2019-02-12 Thread Enrico Olivelli
on master, once we have released 3.5. IMHO Having warnings is not useful. Enrico > > Regards, > Norbert > > On Mon, Feb 11, 2019 at 10:50 PM Enrico Olivelli > wrote: > > > Hi, > > I did not notice that we already have checkstyle configuration in the ANT

ZooKeeper and checkstyle

2019-02-11 Thread Enrico Olivelli
Hi, I did not notice that we already have checkstyle configuration in the ANT build. This is the command ant checkstyle Unfortunately we have hundreds of violations I think it will be a great step to re-enable checkstyle on master after we get a "stable" release of the 3.5 branch. I expect

Re: ZooKeeper_branch34_openjdk7 - Build # 2208 - Still Failing

2019-02-11 Thread Enrico Olivelli
Since we are going to release 3.4... Better to take a look to this error. Does any ring bell? It seems a Jenkins issue Enrico Il giorno lun 11 feb 2019, 19:09 Apache Jenkins Server < jenk...@builds.apache.org> ha scritto: > See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2208/ >

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 0

2019-02-08 Thread Enrico Olivelli
Thank you Andor for making this happen I am sorry, this is my -1 (non binding) I have this problem on the staged source artifacts: tar zxvf zookeeper-3.4.14.tar.gz cd zookeeper-3.4.14 ant this is the result Buildfile: /home/diennea.lan/enrico.olivelli/Scaricati/zookeeper-3.4.14/build.xml

Re: What about using Travis-CI ?

2019-02-07 Thread Enrico Olivelli
advantage of Travis is the the contributor is free to restart the build and security risks are over Travis infra. Also I would like to try to run the suite without requiring fsync to disk, maybe the build may complete faster. Enrico > Thanks, > Norbert > > On Thu, Feb 7, 2019 at 10:32 PM Enr

Re: What about using Travis-CI ?

2019-02-07 Thread Enrico Olivelli
rks for me :) > > Regards, > Norbert > > On Mon, Jan 14, 2019 at 11:06 PM Enrico Olivelli > wrote: > > > Last update:with fork count = 4 we have the build finishing wihin 20 > > minutes but we have a lot of test failures ! > > > > https://travis-ci.org/apac

[jira] [Created] (ZOOKEEPER-3273) Sync BounceCastle version in Maven build and Ant build

2019-02-06 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3273: -- Summary: Sync BounceCastle version in Maven build and Ant build Key: ZOOKEEPER-3273 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3273 Project

[jira] [Updated] (ZOOKEEPER-3273) Sync BouncyCastle version in Maven build and Ant build

2019-02-06 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3273: --- Summary: Sync BouncyCastle version in Maven build and Ant build (was: Sync

[jira] [Assigned] (ZOOKEEPER-3273) Sync BounceCastle version in Maven build and Ant build

2019-02-06 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned ZOOKEEPER-3273: -- Assignee: Enrico Olivelli > Sync BounceCastle version in Maven bu

BouncyCastle version different from Maven and Ant builds

2019-02-06 Thread Enrico Olivelli
Hi, while working on OWASP stuff I have found that Maven dependency of BouncyCastle is newer than the one in the Ant configuration. The same is on branch-3.5. On branch-3.4 we have bouncycastle only on Maven (I am sending a patch for this one) see:

Re: [DISCUSS] Remove ant build from master branch

2019-02-06 Thread Enrico Olivelli
Il giorno mer 6 feb 2019, 20:30 Tamas Penzes ha scritto: > Hi All, > > Maven migration is almost done on all the three active branches (master, > 3.5, 3.4). > For backward compatibility I would suggest to keep ant build on branch 3.4 > and 3.5 but remove it from master branch (versions 3.6+). >

Re: Pull requests validation - Maven is active - heads up!

2019-02-06 Thread Enrico Olivelli
In the mid term option 2) is better. In the short term option 1) works as well. I will be happy to work on this stuff Best regards Enrico Il giorno mar 5 feb 2019 alle ore 16:07 Enrico Olivelli ha scritto: > > > > Il giorno mar 5 feb 2019, 15:47 Norbert Kalmar > ha scritto:

Re: Pull requests validation - Maven is active - heads up!

2019-02-05 Thread Enrico Olivelli
t; Looks good. Thanks Enrico! > > > > Patrick > > > > On Sat, Feb 2, 2019 at 1:32 AM Enrico Olivelli > > wrote: > > > > > Hi ZooKeepers, > > > I have enabled validation of Pull Requests with Maven. > > > > > > In order to trigg

Re: Error in windows build

2019-02-04 Thread Enrico Olivelli
No, sorry I will check. If we are supporting Windows build we should add some CI job Are you using cygwin? Enrico Il giorno gio 31 gen 2019, 19:33 Andor Molnar ha scritto: > Hi, > > Does it ring a bell for anybody? > > CMake Error at CMakeLists.txt:19 (project): > No CMAKE_C_COMPILER

Re: Pull requests validation - Maven is active - heads up!

2019-02-04 Thread Enrico Olivelli
Full build is now active on Maven Pull Request Builder Cheers Enrico Il giorno lun 4 feb 2019 alle ore 13:16 Enrico Olivelli ha scritto: > > @Andor > trying now with nightly build > https://builds.apache.org/job/zookeeper-master-maven/59/ > > If tests are running well, I wil

Re: Maven migration and CI

2019-02-04 Thread Enrico Olivelli
> Andor > > > > > > On 2019. Jan 26., at 9:36, Enrico Olivelli wrote: > > > > I am working on owasp plugin, this is needed for CI migration > > > > > > Enrico > > > > Il giorno dom 6 gen 2019, 15:23 Norbert Kalmar > > > &

Re: Pull requests validation - Maven is active - heads up!

2019-02-04 Thread Enrico Olivelli
: > > Great work, thanks Enrico! > > Are u planning to enable C++ tests too? > > > Andor > > > On 2/2/19 10:32, Enrico Olivelli wrote: > > Hi ZooKeepers, > > I have enabled validation of Pull Requests with Maven. > > > > In order to trigger the t

Pull requests validation - Maven is active - heads up!

2019-02-02 Thread Enrico Olivelli
Hi ZooKeepers, I have enabled validation of Pull Requests with Maven. In order to trigger the tests with ANT add a comment with: retest ant build In order to trigger the tests with MAVEN add a comment with: retest maven build see this configuration for reference

Re: Maven release

2019-02-01 Thread Enrico Olivelli
Norbert, Thank you for making this happen Il giorno ven 1 feb 2019, 20:16 Norbert Kalmar ha scritto: > Hi ZooKeeper devs, > > As you might have noticed, maven is gaining grip on the ZooKeeper > processes. Enrico, for example, just did a proof of concept on checking PRs > with a maven build as

Re: Maven Build keeps breaking

2019-02-01 Thread Enrico Olivelli
hat it's enough to merge it to master branch, the rest is fine. > > Enrico is now ready to add the maven build to the pull request checks which > > will be a huge improvement. > > > > Andor > > > > > > > > On Thu, Jan 31, 2019 at 11:07 AM E

Maven Build keeps breaking

2019-01-31 Thread Enrico Olivelli
Hi ZooKeepers ! Maven build keeps breaking. This is the fix https://github.com/apache/zookeeper/pull/793 Once this fix lands to every branch I would like to setup a CI job to run Maven build against Pull Request (additionally to the ant based CI job) Note: Current ant based CI job is very

Re: OWASP task failing again ! but is CI lying ?

2019-01-31 Thread Enrico Olivelli
Il giorno gio 31 gen 2019, 00:42 Patrick Hunt ha scritto: > On Wed, Jan 30, 2019 at 3:13 PM Enrico Olivelli > wrote: > > > Il giorno mer 30 gen 2019, 21:41 Patrick Hunt ha > > scritto: > > > > > Note the owasp job has been failing since the upgrade t

Re: OWASP task failing again ! but is CI lying ?

2019-01-30 Thread Enrico Olivelli
d the job targets however it's now failing due to CVEs in netty and > some deps: > > https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-owasp/255/ > agree we should clear these out... > > Patrick > > > On Sat, Jan 26, 2019 at 3:54 AM Enrico O

Re: GitHub "god" mode

2019-01-30 Thread Enrico Olivelli
; Sorry for the huge number of "closed pull request" emails. > > > > Andor > > > > > > > > On Wed, Jan 30, 2019 at 4:08 PM Camille Fournier > > wrote: > > > > > Wow thanks Andor! > > > > > > On Wed, Jan 30, 2019, 6:4

[jira] [Updated] (ZOOKEEPER-3262) Update dependencies flagged by OWASP report

2019-01-30 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3262: --- Description: Currently OWASP plugin is reporting these vulnerabilities: |[CVE

<    3   4   5   6   7   8   9   10   11   >