[GitHub] [zookeeper] szepet edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-30 Thread GitBox
szepet edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497321392 retest ant build Edit: Well, it seems I do not own this power... This i

[GitHub] [zookeeper] szepet edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-30 Thread GitBox
szepet edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497321392 retest ant build Well, it seems I do not own this power... This is an a

[GitHub] [zookeeper] szepet commented on issue #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-30 Thread GitBox
szepet commented on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497321392 retest ant build This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] nkalmar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-30 Thread GitBox
nkalmar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-497321302 If were talking about "if [ ! `ls build/zookeeper*.jar` ]; then" thats just for checking if ZK has been built before running

[GitHub] [zookeeper] anmolnar commented on issue #938: ZOOKEEPER-2559:[WIP]Failed to delete the set quota for ephemeral node when … the node is deleted because of client session closed

2019-05-30 Thread GitBox
anmolnar commented on issue #938: ZOOKEEPER-2559:[WIP]Failed to delete the set quota for ephemeral node when … the node is deleted because of client session closed URL: https://github.com/apache/zookeeper/pull/938#issuecomment-497318680 retest maven build -

[GitHub] [zookeeper] anmolnar commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator)

2019-05-30 Thread GitBox
anmolnar commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) URL: https://github.com/apache/zookeeper/pull/946#issuecomment-497318173 retest maven build This is an a

[GitHub] [zookeeper] anmolnar commented on issue #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-30 Thread GitBox
anmolnar commented on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497257586 retest maven build This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] phunt commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

2019-05-29 Thread GitBox
phunt commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-497200481 retest maven build This is an automated mess

[GitHub] [zookeeper] hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-29 Thread GitBox
hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#issuecomment-497156627 >> if this config could be generalized to be used exclusively for socket connection timeout I am not sure if

[GitHub] [zookeeper] hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-29 Thread GitBox
hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#issuecomment-497155402 When a leader is partitioned after LE, a smaller socket timeout value will make it faster to detect the partition.

[GitHub] [zookeeper] hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-29 Thread GitBox
hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r288816030 ## File path: conf/zoo_sample.cfg ## @@ -6,6 +6,9 @@ initLimit=10 # The number

[GitHub] [zookeeper] hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-29 Thread GitBox
hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r288816455 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPee

[GitHub] [zookeeper] hanm commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document

2019-05-29 Thread GitBox
hanm commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931#issuecomment-497152729 I agree the original statement is not very clear, but instead of changing it, how about actually cla

[GitHub] [zookeeper] enixon commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-29 Thread GitBox
enixon commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963#issuecomment-497144847 lgtm This is an automated message from the Apache Git Service. To r

[GitHub] [zookeeper] lfrancke opened a new pull request #964: ZOOKEEPER-3407: Update POM file

2019-05-29 Thread GitBox
lfrancke opened a new pull request #964: ZOOKEEPER-3407: Update POM file URL: https://github.com/apache/zookeeper/pull/964 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zookeeper] lfrancke opened a new pull request #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-29 Thread GitBox
lfrancke opened a new pull request #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963 This updates the website with the new mailing lists. Probably makes sense to wait with merging until INFRA has completed the changes. Wh

[GitHub] [zookeeper] anmolnar commented on issue #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device

2019-05-29 Thread GitBox
anmolnar commented on issue #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device URL: https://github.com/apache/zookeeper/pull/935#issuecomment-496980833 Merged to master. Thanks @BELUGABEHR ! This

[GitHub] [zookeeper] asfgit closed pull request #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device

2019-05-29 Thread GitBox
asfgit closed pull request #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device URL: https://github.com/apache/zookeeper/pull/935 This is an automated message from the Apache Git Service. To respon

[GitHub] [zookeeper] anmolnar commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document

2019-05-29 Thread GitBox
anmolnar commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931#issuecomment-496963385 @hanm @phunt Do you agree with this change?

[GitHub] [zookeeper] anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements

2019-05-29 Thread GitBox
anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-496959862 We have so many committers nowadays. @lvfangmin @eolivelli @nkalmar Would you please let me have one of your approvals? :)

[GitHub] [zookeeper] anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements

2019-05-29 Thread GitBox
anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-496959084 retest maven build This is an automated message from the Apache

[GitHub] [zookeeper] anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter

2019-05-29 Thread GitBox
anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter URL: https://github.com/apache/zookeeper/pull/941#issuecomment-496958325 @bd2019us This patch doesn't compile: ``` [ERROR] /home/travis/build/apache/zookeeper/zookeeper-jute/target/classes/org

[GitHub] [zookeeper] anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter

2019-05-29 Thread GitBox
anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter URL: https://github.com/apache/zookeeper/pull/941#issuecomment-496956993 retest this please This is an automated message from the Apa

[GitHub] [zookeeper] anmolnar commented on issue #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide

2019-05-29 Thread GitBox
anmolnar commented on issue #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide URL: https://github.com/apache/zookeeper/pull/903#issuecomment-496956167 @BELUGABEHR Could be right, but I feel I can argue with. Not sure though. I would really just fix the URL instead of

[GitHub] [zookeeper] eolivelli commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor

2019-05-29 Thread GitBox
eolivelli commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#issuecomment-496949661 This is cool @anmolnar @nkalmar please take a look as well. I will review as soon as I can. The change is not trivial

[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

2019-05-29 Thread GitBox
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948713 @nkalmar I have restarted the tests because this patch was approved but it is quite old. I hope tests

[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

2019-05-29 Thread GitBox
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948507 retest maven build This is an automated

[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

2019-05-29 Thread GitBox
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948413 retest ant build This is an automated m

[GitHub] [zookeeper] eolivelli commented on issue #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK

2019-05-29 Thread GitBox
eolivelli commented on issue #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK URL: https://github.com/apache/zookeeper/pull/919#issuecomment-496948152 @lvfangmin we need to rebase. I hope @normanmaurer have cycles to take a look -

[GitHub] [zookeeper] eolivelli commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

2019-05-29 Thread GitBox
eolivelli commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-496947055 Please rebase @enixon This is an automated message from the Apac

[GitHub] [zookeeper] eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

2019-05-29 Thread GitBox
eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-496946298 retest maven build This is an automated

[GitHub] [zookeeper] eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

2019-05-28 Thread GitBox
eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-496789395 retest maven buiild This is an automated

[GitHub] [zookeeper] hanm commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication.

2019-05-28 Thread GitBox
hanm commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication. URL: https://github.com/apache/zookeeper/pull/118#issuecomment-496771839 @enixon Thank you for feedback, I'll keep this in mind. ---

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-28 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496750615 retest maven build This is an automated message from the Apache Git Service.

[GitHub] [zookeeper] phunt opened a new pull request #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

2019-05-28 Thread GitBox
phunt opened a new pull request #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962 Upgraded the library to the latest version. Change-Id: I94743e7f7817202fff25c757730ba05fe0a9cc17 -

[GitHub] [zookeeper] enixon commented on issue #960: Fix typos and grammar in zookeeper docs

2019-05-28 Thread GitBox
enixon commented on issue #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960#issuecomment-496686220 retest ant build This is an automated message from the Apache Git Service. To res

[GitHub] [zookeeper] enixon commented on issue #960: Fix typos and grammar in zookeeper docs

2019-05-28 Thread GitBox
enixon commented on issue #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960#issuecomment-496685882 looks good to me This is an automated message from the Apache Git Service. To res

[GitHub] [zookeeper] szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-28 Thread GitBox
szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496678387 Yes, it the condition at the beginning was unnecessary since @nkalmar has done ZOOKEEPER-3029. In 05b774a the maven ge

[GitHub] [zookeeper] szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-28 Thread GitBox
szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496678387 Yes, it the condition at the beginning was unnecessary since @nkalmar has done ZOOKEEPER-3029. In #05b774 the maven generated

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-28 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496648615 retest maven build This is an automated message from the Apache Git Service.

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-28 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496648163 reset maven build This is an automated message from the Apache Git Service. T

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-28 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496606096 > Did you see my last comments? Sorry! Was on vacation. Just made the changes. Thank you @eolivelli --

[GitHub] [zookeeper] jhuan31 commented on issue #858: ZOOKEEPER-3321: Add metrics for Leader

2019-05-28 Thread GitBox
jhuan31 commented on issue #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#issuecomment-496601707 Thank you @eolivelli This is an automated message from the Apache Git Service. T

[GitHub] [zookeeper] eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-28 Thread GitBox
eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#issuecomment-496587533 I wasn't aware of OptionalSSLHandler. This is very interesting. What do you think @enixon? I wa

[GitHub] [zookeeper] nkalmar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60

2019-05-28 Thread GitBox
nkalmar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961#issuecomment-496532806 Thanks @anmolnar , merged to master and 3.5 This is an automated message

[GitHub] [zookeeper] asfgit closed pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60

2019-05-28 Thread GitBox
asfgit closed pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-28 Thread GitBox
nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-496527666 Thanks @jhuan31 , merged to master. This is an automated messa

[GitHub] [zookeeper] asfgit closed pull request #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-28 Thread GitBox
asfgit closed pull request #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] nkalmar commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-28 Thread GitBox
nkalmar commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496521330 retest ant build Thi

[GitHub] [zookeeper] anmolnar commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-28 Thread GitBox
anmolnar commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#issuecomment-496507605 @enixon Quite an impressive new feature gets little attention. Let's clarify one thing. We already have th

[GitHub] [zookeeper] anmolnar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60

2019-05-27 Thread GitBox
anmolnar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961#issuecomment-496370179 > btw if we have these problems now someday we will see them again when we will need to upgrade. Aren't we using BC only for generatin

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-27 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496307959 @lvfangmin please help me move forward this patch :-) cc @anmolnar @nkalmar

[GitHub] [zookeeper] eolivelli commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60

2019-05-27 Thread GitBox
eolivelli commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961#issuecomment-496307315 As we are using BC only for tests it is okay to downgrade in order to make tests more stable. btw if we have these problems now

[GitHub] [zookeeper] anmolnar opened a new pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60

2019-05-27 Thread GitBox
anmolnar opened a new pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961 I've seen a lot of test timeout errors with QuorumSSL tests since I upgraded master to BouncyCastle 1.61 due to a Java 9 warning. The warning has been

[GitHub] [zookeeper] ashashwat opened a new pull request #960: Fix typos and grammar in zookeeper docs

2019-05-27 Thread GitBox
ashashwat opened a new pull request #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960 Raising a PR to fix typos and grammar in zookeeper docs. This is an automated message from th

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-27 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496300939 I had enough with the failing Ant build, committed anyway. Thanks @jhuan31 ! ---

[GitHub] [zookeeper] asfgit closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-27 Thread GitBox
asfgit closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-27 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496295873 retest ant build This is an automated message from the Apache G

[GitHub] [zookeeper] szepet commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-27 Thread GitBox
szepet commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#discussion_r287851484 ## File path: zookeeper-server/src/test/resources/test-scripts.sh ## @@ -217,6 +217,9 @@ s

[GitHub] [zookeeper] szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-27 Thread GitBox
szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496270234 Yepp, sorry for the late response. I have found some other problems using the `test-scripts.sh` but hopefully managed to corr

[GitHub] [zookeeper] szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-27 Thread GitBox
szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496270234 @eolivelli @anmolnar Yepp, sorry for the late response. I have found some other problems using the `test-scripts.s

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-27 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496267890 retest ant build This is an automated message from the Apache G

[GitHub] [zookeeper] anmolnar commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-27 Thread GitBox
anmolnar commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#discussion_r287838351 ## File path: zookeeper-server/src/test/resources/test-scripts.sh ## @@ -217,6 +217,9 @@

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-27 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496253615 I think we really made something wrong with `testHostnameVerificationWithInvalidIpAddressAndInvalidHostname`. retest ant buil

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-27 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496253670 retest ant build This is an automated message from the Apache G

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-27 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496187671 retest ant build This is an automated message from the Apache G

[GitHub] [zookeeper] szepet commented on issue #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-27 Thread GitBox
szepet commented on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-496162411 @lvfangmin @anmolnar What do you think about it? (forgot to mention you in the initial comment) Of course, every idea or question is welcome he

[GitHub] [zookeeper] nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-27 Thread GitBox
nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-496153591 retest ant build This is an automated message from the Apache

[GitHub] [zookeeper] nkalmar commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information

2019-05-27 Thread GitBox
nkalmar commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947#issuecomment-496137617 Thanks @enixon , committed to master. This is an

[GitHub] [zookeeper] asfgit closed pull request #947: ZOOKEEPER-3392: Add admin command to display last snapshot information

2019-05-27 Thread GitBox
asfgit closed pull request #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947 This is an automated message from the Apache Git Service. To respond t

[GitHub] [zookeeper] szepet opened a new pull request #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-26 Thread GitBox
szepet opened a new pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959 So, the possibility of the multi version of getChildren, getData, and a common multiRead interface was already mentioned and briefly discussed in the conversatio

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-26 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496014349 retest ant build T

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-26 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496008413 retest ant build T

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-26 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495989214 retest ant build T

[GitHub] [zookeeper] maoling closed pull request #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node

2019-05-25 Thread GitBox
maoling closed pull request #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node URL: https://github.com/apache/zookeeper/pull/942 This is an automated message from the Apache

[GitHub] [zookeeper] maoling edited a comment on issue #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node

2019-05-25 Thread GitBox
maoling edited a comment on issue #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node URL: https://github.com/apache/zookeeper/pull/942#issuecomment-495974415 - "**listquota display the quota even it is set on parent/child node**" is not a

[GitHub] [zookeeper] maoling commented on issue #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node

2019-05-25 Thread GitBox
maoling commented on issue #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node URL: https://github.com/apache/zookeeper/pull/942#issuecomment-495974415 - "**listquota display the quota even it is set on parent/child node**" is not a good wa

[GitHub] [zookeeper] asfgit closed pull request #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.

2019-05-25 Thread GitBox
asfgit closed pull request #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance. URL: https://github.com/apache/zookeeper/pull/956 This is an automated message from the Apache Git Service

[GitHub] [zookeeper] eolivelli commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-25 Thread GitBox
eolivelli commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-495871830 retest ant build This is an automated message from the Apache Git Service.

[GitHub] [zookeeper] jhuan31 commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-24 Thread GitBox
jhuan31 commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495773198 A green build is hard to get these days :( This is an automated

[GitHub] [zookeeper] jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-24 Thread GitBox
jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 To address a potential flaky test in PR #849 (LearnerHandlerMetricsTest) This

[GitHub] [zookeeper] jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-24 Thread GitBox
jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] enixon commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information

2019-05-24 Thread GitBox
enixon commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947#issuecomment-495725161 @nkalmar you're correct that we're not looking to add new four letter words to 3.6 anymore and move forward with d

[GitHub] [zookeeper] enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing

2019-05-24 Thread GitBox
enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958#issuecomment-495723744 retest ant build This is an automated message from the Ap

[GitHub] [zookeeper] eolivelli commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing

2019-05-24 Thread GitBox
eolivelli commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958#issuecomment-495707052 This looks very interesting This is an automated messa

[GitHub] [zookeeper] anmolnar closed pull request #955: ZOOKEEPER-3362: Create a simple checkstyle file

2019-05-24 Thread GitBox
anmolnar closed pull request #955: ZOOKEEPER-3362: Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/955 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zookeeper] anmolnar commented on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file

2019-05-24 Thread GitBox
anmolnar commented on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/955#issuecomment-495688201 Merged. thanks. This is an automated message from the Apache Git Servi

[GitHub] [zookeeper] anmolnar closed pull request #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)

2019-05-24 Thread GitBox
anmolnar closed pull request #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5) URL: https://github.com/apache/zookeeper/pull/954 This is an automated message from the Apache

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-24 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495680030 @lvfangmin Are you happy with committing this patch? This is an

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-24 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495679764 @eolivelli Please review again and make sure your comments have been addressed. I'll commit this once we got a green build. ---

[GitHub] [zookeeper] jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-24 Thread GitBox
jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zookeeper] jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-24 Thread GitBox
jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zookeeper] jhuan31 commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-24 Thread GitBox
jhuan31 commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-495672330 Thank you @nkalmar. Fixed the unit test. This is an automated

[GitHub] [zookeeper] jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-24 Thread GitBox
jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-24 Thread GitBox
jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 To address a potential flaky test in PR #849 (LearnerHandlerMetricsTest) This

[GitHub] [zookeeper] anmolnar commented on issue #924: ZOOKEEPER-3371: Port unification for Jetty admin server

2019-05-24 Thread GitBox
anmolnar commented on issue #924: ZOOKEEPER-3371: Port unification for Jetty admin server URL: https://github.com/apache/zookeeper/pull/924#issuecomment-495612493 Please fix the failing unit test `org.apache.zookeeper.server.quorum.QuorumSSLTest.testHostnameVerificationWithInvalidIpAddr

[GitHub] [zookeeper] nkalmar commented on issue #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.

2019-05-24 Thread GitBox
nkalmar commented on issue #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance. URL: https://github.com/apache/zookeeper/pull/956#issuecomment-495567490 retest ant build This is an automa

[GitHub] [zookeeper] enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing

2019-05-23 Thread GitBox
enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958#issuecomment-495423430 This adds a new admin command that will show the syncing state of a peer. The ticket also requests better logging - I'm no

[GitHub] [zookeeper] enixon opened a new pull request #958: ZOOKEEPER-1523: Better logging during instance loading/syncing

2019-05-23 Thread GitBox
enixon opened a new pull request #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958 This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

2019-05-23 Thread GitBox
enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-495401373 retest ant build This is an automated message from the Apache Git Se

  1   2   3   4   5   6   7   8   9   10   >