[
https://issues.apache.org/jira/browse/ZOOKEEPER-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126316#comment-16126316
]
Henry Robinson commented on ZOOKEEPER-1360:
---
Not at all - haven't looked at this in years
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653114#comment-13653114
]
Henry Robinson commented on ZOOKEEPER-1697:
---
[~phunt] - this seems _much_
after )
src/java/main/org/apache/zookeeper/server/admin/Commands.java
https://reviews.apache.org/r/8094/#comment30421
Oh for Guava, and ImmutableMap.of(..) or something like it.
- Henry Robinson
On Nov. 30, 2012, 9:01 p.m., Skye Wanderman-Milne wrote
an empty Map
instead of null, in case this ever gets used?
- Henry Robinson
On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8094
/
---
(Updated Nov. 16, 2012, 11:25 p.m.)
Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry
Robinson.
Description
---
See my comment in ZOOKEEPER-1346.
This addresses bug ZOOKEEPER-1346.
https://issues.apache.org/jira/browse/ZOOKEEPER-1346
Diffs
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468901#comment-13468901
]
Henry Robinson commented on ZOOKEEPER-1346:
---
+1, great idea.
I do think
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson reassigned ZOOKEEPER-1238:
-
Assignee: Skye Wanderman-Milne
when the linger time was changed for NIO
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson reassigned ZOOKEEPER-1376:
-
Assignee: Skye Wanderman-Milne
zkServer.sh does not correctly check
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462237#comment-13462237
]
Henry Robinson commented on ZOOKEEPER-1238:
---
+1, patch looks good to me
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460911#comment-13460911
]
Henry Robinson commented on ZOOKEEPER-1376:
---
+1, patch looks good to me
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452560#comment-13452560
]
Henry Robinson commented on ZOOKEEPER-1361:
---
Hey - sorry for the delay. I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425397#comment-13425397
]
Henry Robinson commented on ZOOKEEPER-1514:
---
Hi Flavio -
I don't really
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424286#comment-13424286
]
Henry Robinson commented on ZOOKEEPER-1514:
---
Flavio - this looks fine
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423210#comment-13423210
]
Henry Robinson commented on ZOOKEEPER-1521:
---
Good catch. Here's what I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423443#comment-13423443
]
Henry Robinson commented on ZOOKEEPER-1514:
---
I'm not sure that removing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420379#comment-13420379
]
Henry Robinson commented on ZOOKEEPER-1514:
---
Hey Flavio -
Thanks
. There
is some work that has been done and a patch here:
https://issues.apache.org/jira/browse/ZOOKEEPER-423
Does anyone know if that patch will be accepted? If so, when. If not, I
can write a getTopNChildren() from scratch.
-JZ
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13396393#comment-13396393
]
Henry Robinson commented on ZOOKEEPER-1431:
---
Patch looks good, I'll commit
Henry Robinson created ZOOKEEPER-1473:
-
Summary: Committed proposal log retains triple the memory it needs
to
Key: ZOOKEEPER-1473
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1473
Project
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1473:
--
Description:
ZKDatabase.committedLog retains the past 500 transactions to enable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4958/
---
Review request for zookeeper and Henry Robinson.
Summary
---
Creating
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4958/
---
(Updated 2012-05-01 22:22:51.531968)
Review request for zookeeper and Henry
NULL, it's going to be hard to
recover)
- Henry
On 2012-05-01 22:22:51, Henry Robinson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4958
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266236#comment-13266236
]
Henry Robinson commented on ZOOKEEPER-1461:
---
See ZOOKEEPER-1305
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266237#comment-13266237
]
Henry Robinson commented on ZOOKEEPER-1305:
---
Hey Mahadev -
Seems like some
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1318:
--
Attachment: ZOOKEEPER-1318.patch
The error is a missing InvalidStateException
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1318:
--
Attachment: ZOOKEEPER-1318.patch
Updated patch - InvalidStateException was already
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253568#comment-13253568
]
Henry Robinson commented on ZOOKEEPER-1442:
---
The current method of logging
if this ever gets into a release and the
old API doesn't, otherwise that's a functionality regression I'd like to
avoid.
Henry
Thanks
Duncan
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
[
https://issues.apache.org/jira/browse/ZOOKEEPER-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson resolved ZOOKEEPER-578.
--
Resolution: Won't Fix
I don't think this is relevant any more
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241972#comment-13241972
]
Henry Robinson commented on ZOOKEEPER-1435:
---
+1 looks good to me, I'll
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241973#comment-13241973
]
Henry Robinson commented on ZOOKEEPER-1433:
---
+1, looks good to me
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239105#comment-13239105
]
Henry Robinson commented on ZOOKEEPER-1395:
---
+1 this looks sensible to me
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223084#comment-13223084
]
Henry Robinson commented on ZOOKEEPER-1161:
---
I just committed this to trunk
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222724#comment-13222724
]
Henry Robinson commented on ZOOKEEPER-1161:
---
+1, looks good to me. A couple
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1161:
--
Attachment: ZOOKEEPER-1161.patch
Two tiny nits fixed - replaced true
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1361:
--
Attachment: ZOOKEEPER-1361-no-whitespace.patch
Try this one, should have
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216992#comment-13216992
]
Henry Robinson commented on ZOOKEEPER-1361:
---
It applies to trunk for me (I
comments welcome.
/Hartmut
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1321:
--
Attachment: ZK-1321-nowhitespace.patch
Same diff with trailing whitespace left
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1321:
--
Attachment: zk-1321-trunk.patch
Correctly generated patch.
Add
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191376#comment-13191376
]
Henry Robinson commented on ZOOKEEPER-1366:
---
My feeling is that Ted's fixing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189557#comment-13189557
]
Henry Robinson commented on ZOOKEEPER-1366:
---
The nice thing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189560#comment-13189560
]
Henry Robinson commented on ZOOKEEPER-1366:
---
Oh, and my main concern here
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187069#comment-13187069
]
Henry Robinson commented on ZOOKEEPER-1321:
---
+1 looks good! Only weirdness
Reporter: Henry Robinson
As discussed on the list, it would be good to split the Java test suite into
categories so that it's easy to run a small set of unit tests against a patch,
and to leave Jenkins to run the full suite of stress tests etc.
--
This message is automatically generated
On 16 January 2012 17:36, Patrick Hunt ph...@apache.org wrote:
On Sun, Jan 15, 2012 at 11:39 PM, Henry Robinson he...@cloudera.com
wrote:
Hi -
The unit tests are taking longer and longer to run, particularly
locally. I
was poking about looking for some easy wins, and I noticed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1361:
--
Attachment: ZOOKEEPER-1361.patch
This patch cleans up some of the synchronisation
Issue Type: Bug
Affects Versions: 3.4.2
Reporter: Henry Robinson
Assignee: Henry Robinson
Fix For: 3.5.0
This block:
{code}
HashSetLong followerSet = new HashSetLong();
for(LearnerHandler f : learners)
followerSet.add(f.getSid());
{code}
is executed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1294:
--
Attachment: ZOOKEEPER-1294-2.patch
This patch fixes the deadlock issue, and passes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1294:
--
Attachment: ZOOKEEPER-1294-3.patch
Ugh, forgot to switch from Cloudera copyright
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185454#comment-13185454
]
Henry Robinson commented on ZOOKEEPER-1294:
---
So, after some investigation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1294:
--
Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change)
One
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184762#comment-13184762
]
Henry Robinson commented on ZOOKEEPER-1294:
---
These failures are legit; I'm
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179118#comment-13179118
]
Henry Robinson commented on ZOOKEEPER-1318:
---
Hi Jim -
Good catch! By all
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166457#comment-13166457
]
Henry Robinson commented on ZOOKEEPER-1314:
---
Hi Daniel -
Looks good, I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055234#comment-13055234
]
Henry Robinson commented on ZOOKEEPER-1097:
---
Just committed this to 3.3
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1097:
--
Attachment: ZOOKEEPER-1097-whitespace.patch
Quota is not correctly rehydrated
Simple leader election recipe
-
Key: ZOOKEEPER-1095
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1095
Project: ZooKeeper
Issue Type: Improvement
Reporter: Henry Robinson
Leader election
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049887#comment-13049887
]
Henry Robinson commented on ZOOKEEPER-1080:
---
What we've got here are two
Components: quorum
Reporter: Henry Robinson
Assignee: Henry Robinson
Priority: Minor
1. o.a.z.q.Vote is a struct-style class, whose fields are public and not final.
In general, we should prefer making the fields of these kind of classes final,
and hiding them
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1094:
--
Attachment: ZK-1094.patch
Small improvements to LeaderElection and Vote classes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1094:
--
Attachment: (was: ZK-1094.patch)
Small improvements to LeaderElection
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-1094:
--
Attachment: ZK-1094.patch
Small improvements to LeaderElection and Vote classes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048915#comment-13048915
]
Henry Robinson commented on ZOOKEEPER-1094:
---
Sure - if you commit ZOOKEEPER
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048949#comment-13048949
]
Henry Robinson commented on ZOOKEEPER-1080:
---
Hey Eric - this looks good
[
https://issues.apache.org/jira/browse/ZOOKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027015#comment-13027015
]
Henry Robinson commented on ZOOKEEPER-423:
--
Lukas -
Good suggestion. Could
[
https://issues.apache.org/jira/browse/ZOOKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027030#comment-13027030
]
Henry Robinson commented on ZOOKEEPER-423:
--
Thanks - I'm afraid I need a bit
. Welcome aboard Michi!
--
thanks
mahadev
@mahadevkonar
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
[
https://issues.apache.org/jira/browse/ZOOKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-423:
-
Attachment: ZOOKEEPER-423.patch
Draft patch
Add getFirstChild API
[
https://issues.apache.org/jira/browse/ZOOKEEPER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-423:
-
Attachment: (was: ZOOKEEPER-423.patch)
Add getFirstChild API
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
). All ZooKeeper
community
members are encouraged to vote, though only PMC votes will be binding.
Here's my +1 vote.
Patrick
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
://gerrit.googlecode.com/svn/documentation/2.1.6/index.html
Best regards,
Thomas Koch, http://www.koch.ro
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
[
https://issues.apache.org/jira/browse/ZOOKEEPER-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975918#action_12975918
]
Henry Robinson commented on ZOOKEEPER-965:
--
Hi Ted -
You don't have to lose
[
https://issues.apache.org/jira/browse/ZOOKEEPER-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-921:
-
Hadoop Flags: [Reviewed]
+1
Nice work, particularly nice catch on the test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-963:
-
Hadoop Flags: [Reviewed]
+1
It works! Oh happy day. I'll commit this asap to 3.3.3
[
https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975701#action_12975701
]
Henry Robinson commented on ZOOKEEPER-837:
--
Thomas - ZOOKEEPER-823 is not yet
[
https://issues.apache.org/jira/browse/ZOOKEEPER-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975702#action_12975702
]
Henry Robinson commented on ZOOKEEPER-965:
--
Hi Ted -
I took a quick look
[
https://issues.apache.org/jira/browse/ZOOKEEPER-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975704#action_12975704
]
Henry Robinson commented on ZOOKEEPER-965:
--
Hi Thomas -
I really appreciate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-965:
-
Assignee: Ted Dunning
Assigning to Ted.
Need a multi-update command to allow
81 matches
Mail list logo
