[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-08 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/500 ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers https://issues.apache.org/jira/browse/ZOOKEEPER-2959 - add getVotingView check for id in getEpochToPropose and

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-12 Thread lavacat
Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181001854 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-12 Thread lavacat
Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181002193 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception

[GitHub] zookeeper issue #500: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO a...

2018-04-12 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/500 Moved these 3 new tests into new class - LeaderWithObserverTest. Had to make createLeader and createQuorumPeer 'public static' in Zab1_0Test. Happy to refactor into common base class ---

[GitHub] zookeeper issue #500: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO a...

2018-04-12 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/500 @anmolnar added ZabUtils ---

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-19 Thread lavacat
Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182887771 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java --- @@ -0,0 +1,140 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-19 Thread lavacat
Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182889043 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-19 Thread lavacat
Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182922147 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long

[GitHub] zookeeper pull request #503: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-19 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/503 ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers https://issues.apache.org/jira/browse/ZOOKEEPER-2959 - added getVotingMembers check for id in getEpochToPropose and

[GitHub] zookeeper pull request #512: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-05-08 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/512 ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers https://issues.apache.org/jira/browse/ZOOKEEPER-2959 - added getVotingMembers id check in getEpochToPropose and

[GitHub] zookeeper pull request #503: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-05-14 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/503 ---

[GitHub] zookeeper pull request #521: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss...

2018-05-14 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/521 ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky - relaxed check of outstanding proposals queue - close clients after restart - restart client after old leader restart You can

[GitHub] zookeeper pull request #523: ZOOKEEPER-3046: added junit timeout to precede ...

2018-05-17 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/523 ZOOKEEPER-3046: added junit timeout to precede 'ant' timeout When 'ant' timeout triggers, output of the test isn't captured. Related issue ZOOKEEPER-2916 You can mer

[GitHub] zookeeper issue #521: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is fla...

2018-05-17 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/521 @anmolnar thanks, updated ---

[GitHub] zookeeper pull request #512: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-05-21 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/512 ---

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-05-21 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/500 ---

[GitHub] zookeeper issue #521: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is fla...

2018-05-31 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/521 @anmolnar Are there any concerns about this PR? I can remove "ignore LETest" commit. It was failing for me multiple times on PR test runs, but it's not on

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-06-05 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/538 Don't merge. Experimental test to collect extra data when creating 10K nodes You can merge this pull request into a Git repository by running: $ git pull https://github.com/la

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-06-05 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/538 ---

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-06-06 Thread lavacat
GitHub user lavacat reopened a pull request: https://github.com/apache/zookeeper/pull/538 Don't merge. Experimental test to collect extra data when creating 10K nodes You can merge this pull request into a Git repository by running: $ git pull https://github.com/la

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-06-06 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/538 ---

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-06-07 Thread lavacat
GitHub user lavacat reopened a pull request: https://github.com/apache/zookeeper/pull/538 Don't merge. Experimental test to collect extra data when creating 10K nodes You can merge this pull request into a Git repository by running: $ git pull https://github.com/la

[GitHub] zookeeper issue #538: Don't merge. Experimental test to collect extra data w...

2018-06-19 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/538 @hanm Thanks, I'll keep that in mind. I think I've collected the info I need. Will post my finding soon. ---

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-06-19 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/538 ---

[GitHub] zookeeper issue #521: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is fla...

2018-07-09 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/521 @anmolnar yes, only 3.5 There are some trivial conflicts on 3.4 and master. Change is still valid. I can create PRs. Do you want them now or after this is merged? ---

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-07-09 Thread lavacat
GitHub user lavacat reopened a pull request: https://github.com/apache/zookeeper/pull/538 Don't merge. Experimental test to collect extra data when creating 10K nodes You can merge this pull request into a Git repository by running: $ git pull https://github.com/la

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-07-09 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/538 ---

[GitHub] zookeeper pull request #521: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss...

2018-07-11 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/521 ---

[GitHub] zookeeper pull request #570: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss...

2018-07-15 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/570 ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky - relaxed check of outstanding proposals queue - close clients after restart - restart client after old leader restart You can

[GitHub] zookeeper pull request #571: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss...

2018-07-15 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/571 ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky - relaxed check of outstanding proposals queue - close clients after restart - restart client after old leader restart You can

[GitHub] zookeeper pull request #570: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss...

2018-07-17 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/570 ---

[GitHub] zookeeper pull request #576: ZOOKEEPER-3046: increased test timeout

2018-07-18 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/576 ZOOKEEPER-3046: increased test timeout - bump up timeout to avoid too many build failures You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] zookeeper issue #576: ZOOKEEPER-3046: increased test timeout

2018-07-19 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/576 @lvfangmin Do you mean 10 mins (60 ms)? That was me who set it before. The story of this is: this test was timing out sometimes under normal ant limits (15 mins). When ant kills the test

[GitHub] zookeeper pull request #607: WIP - ZOOKEEPER-2990: Implement probabilistic t...

2018-08-23 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/607 WIP - ZOOKEEPER-2990: Implement probabilistic tracing - stmk can be called with extra list of 10 short numbers to set the rate for each mask bit. Max rate is 1000 example: perl -e "

[GitHub] zookeeper issue #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeeper.test....

2018-10-23 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/300 @anmolnar applied the patch to latest master and run tests 10 times with 8 threads. Original error in testNodeDataChanged is gone, but it failed 4 times with 2018-10-23 09:37:31,566 [myid

[GitHub] zookeeper pull request #721: ZOOKEEPER-3046: wait for clients to reconnect a...

2018-11-25 Thread lavacat
Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/721#discussion_r236095252 --- Diff: zookeeper-server/src/test/java/org/apache/zookeeper/test/DisconnectedWatcherTest.java --- @@ -221,6 +228,7 @@ public void