GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/500
ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers
https://issues.apache.org/jira/browse/ZOOKEEPER-2959
- add getVotingView check for id in getEpochToPropose and
Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181001854
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
---
@@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception
Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181002193
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
---
@@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/500
Moved these 3 new tests into new class - LeaderWithObserverTest. Had to
make createLeader and createQuorumPeer 'public static' in Zab1_0Test. Happy to
refactor into common base class
---
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/500
@anmolnar added ZabUtils
---
Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r182887771
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java ---
@@ -0,0 +1,140 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r182889043
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long
Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r182922147
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/503
ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers
https://issues.apache.org/jira/browse/ZOOKEEPER-2959
- added getVotingMembers check for id in getEpochToPropose and
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/512
ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers
https://issues.apache.org/jira/browse/ZOOKEEPER-2959
- added getVotingMembers id check in getEpochToPropose and
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/503
---
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/521
ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky
- relaxed check of outstanding proposals queue
- close clients after restart
- restart client after old leader restart
You can
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/523
ZOOKEEPER-3046: added junit timeout to precede 'ant' timeout
When 'ant' timeout triggers, output of the test isn't captured.
Related issue ZOOKEEPER-2916
You can mer
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/521
@anmolnar thanks, updated
---
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/512
---
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/500
---
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/521
@anmolnar Are there any concerns about this PR? I can remove "ignore
LETest" commit. It was failing for me multiple times on PR test runs, but it's
not on
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/538
Don't merge. Experimental test to collect extra data when creating 10K nodes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/la
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/538
---
GitHub user lavacat reopened a pull request:
https://github.com/apache/zookeeper/pull/538
Don't merge. Experimental test to collect extra data when creating 10K nodes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/la
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/538
---
GitHub user lavacat reopened a pull request:
https://github.com/apache/zookeeper/pull/538
Don't merge. Experimental test to collect extra data when creating 10K nodes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/la
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/538
@hanm Thanks, I'll keep that in mind. I think I've collected the info I
need. Will post my finding soon.
---
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/538
---
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/521
@anmolnar yes, only 3.5
There are some trivial conflicts on 3.4 and master. Change is still valid.
I can create PRs. Do you want them now or after this is merged?
---
GitHub user lavacat reopened a pull request:
https://github.com/apache/zookeeper/pull/538
Don't merge. Experimental test to collect extra data when creating 10K nodes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/la
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/538
---
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/521
---
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/570
ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky
- relaxed check of outstanding proposals queue
- close clients after restart
- restart client after old leader restart
You can
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/571
ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky
- relaxed check of outstanding proposals queue
- close clients after restart
- restart client after old leader restart
You can
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/570
---
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/576
ZOOKEEPER-3046: increased test timeout
- bump up timeout to avoid too many build failures
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/576
@lvfangmin
Do you mean 10 mins (60 ms)? That was me who set it before. The story
of this is: this test was timing out sometimes under normal ant limits (15
mins). When ant kills the test
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/607
WIP - ZOOKEEPER-2990: Implement probabilistic tracing
- stmk can be called with extra list of 10 short numbers to set the rate
for each mask bit. Max rate is 1000
example: perl -e "
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/300
@anmolnar applied the patch to latest master and run tests 10 times with 8
threads. Original error in testNodeDataChanged is gone, but it failed 4 times
with
2018-10-23 09:37:31,566 [myid
Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/721#discussion_r236095252
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/DisconnectedWatcherTest.java
---
@@ -221,6 +228,7 @@ public void
36 matches
Mail list logo