Github user pravsingh commented on the issue:
https://github.com/apache/zookeeper/pull/572
agree with you guys. ð
---
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/496#discussion_r205904126
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
@@ -66,8 +67,8 @@ public SaslQuorumAuthLearner(boolean
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205903481
--- Diff: src/java/main/org/apache/zookeeper/metrics/Summary.java ---
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205902926
--- Diff: src/java/main/org/apache/zookeeper/metrics/Gauge.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205902898
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205903511
--- Diff: src/java/main/org/apache/zookeeper/metrics/MetricsProvider.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/572#discussion_r205901936
--- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java ---
@@ -20,8 +20,35 @@
/**
* Exit code used to exit server
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/572#discussion_r205901511
--- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java ---
@@ -20,8 +20,35 @@
/**
* Exit code used to exit server
